Description

This PR fixes a post-merge regression in the advanced chart timeframe switch flow. After the recent remount based fix, there was still a race where a new OHLCV response could arrive before the remounted WebView finished loading. In that case, the stale snapshot guard could misclassify the already fresh candle array as stale and never send SET_OHLCV_DATA, leaving the new chart instance without data.

The fix narrows the stale snapshot logic so it captures only the previously synced OHLCV array at the moment the series key changes, instead of marking again whatever data happens to be in props later. This preserves the original protection against sending the previous range into the new WebView, while also allowing fast new range responses to sync correctly as soon as the remounted WebView finishes loading.

The PR also adds a focused regression test covering the fast-response / delayed-WebView-load case.

Changelog

CHANGELOG entry: Covered fast response / delayed WebView load case in stale snapshot guard

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.