chore(runway): cherry-pick fix: fix navigation to token details from custom network cp-7.74.0#28980
Merged
Merged
Conversation
…custom network cp-7.74.0 (#28972) ## **Description** Fixes a crash that occurred when viewing token details on custom or unsupported networks (e.g., Fantom, Linea Sepolia, custom EVM chains). ### Issue When users navigated to token details on networks not supported by the Swaps/Bridge `formatAddressToAssetId`, the app would crash with: ``` Error: No XChain Swaps native asset found for chainId: eip155:59141 ``` **Reproduction Steps:** 1. Navigate to a custom network (e.g., Fantom with chainId `0xfa`) 2. Select any token on that network 3. App crashes when trying to display token details ### Solution Added a try-catch wrapper around the `formatAddressToAssetId` call in `Price.advanced.tsx`. When the function throws an error for unsupported chains: ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Fix navigation error on token details page when coming from custom network flow ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: a small defensive change that only affects advanced price chart initialization, with added tests covering unsupported-chain fallbacks. > > **Overview** > Prevents crashes in `PriceAdvanced` on unsupported/custom networks by wrapping `formatAddressToAssetId` in a `try/catch` and using an empty `assetId` when formatting fails, allowing the UI to **fall back to `PriceLegacy`** instead of throwing. > > Extends `Price.advanced.test.tsx` with coverage for custom/unsupported chainIds (including Linea Sepolia) and verifies `useOHLCVChart` is invoked with `assetId: ''` in the failure case, while supported networks still render the advanced chart. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 706896b. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - PR targets a release branch (release/*) All E2E tests pre-selected. |
|
Contributor
|
✅ E2E Fixture Validation — Schema is up to date |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes a crash that occurred when viewing token details on custom or
unsupported networks (e.g., Fantom, Linea Sepolia, custom EVM chains).
Issue
When users navigated to token details on networks not supported by the
Swaps/Bridge
formatAddressToAssetId, the app would crash with:Reproduction Steps:
0xfa)Solution
Added a try-catch wrapper around the
formatAddressToAssetIdcall inPrice.advanced.tsx. When the function throws an error for unsupportedchains:
Changelog
CHANGELOG entry: Fix navigation error on token details page when coming
from custom network flow
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Performance checks (if applicable)
SRPs
to import wallets with many accounts and tokens
performance metrics
trace()for usage andaddTokenfor an example
For performance guidelines and tooling, see the Performance
Guide.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Low Risk
Low risk: a small defensive change that only affects advanced price
chart initialization, with added tests covering unsupported-chain
fallbacks.
Overview
Prevents crashes in
PriceAdvancedon unsupported/custom networks bywrapping
formatAddressToAssetIdin atry/catchand using an emptyassetIdwhen formatting fails, allowing the UI to fall back toPriceLegacyinstead of throwing.Extends
Price.advanced.test.tsxwith coverage for custom/unsupportedchainIds (including Linea Sepolia) and verifies
useOHLCVChartisinvoked with
assetId: ''in the failure case, while supported networksstill render the advanced chart.
Reviewed by Cursor Bugbot for commit
706896b. Bugbot is set up for automated
code reviews on this repo. Configure
here.