Skip to content

chore(runway): cherry-pick fix: fix navigation to token details from custom network cp-7.74.0#28980

Merged
chloeYue merged 1 commit into
release/7.74.00from
runway-cherry-pick-7.74.0-1776437136
Apr 17, 2026
Merged

chore(runway): cherry-pick fix: fix navigation to token details from custom network cp-7.74.0#28980
chloeYue merged 1 commit into
release/7.74.00from
runway-cherry-pick-7.74.0-1776437136

Conversation

@runway-github

@runway-github runway-github Bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes a crash that occurred when viewing token details on custom or
unsupported networks (e.g., Fantom, Linea Sepolia, custom EVM chains).

Issue

When users navigated to token details on networks not supported by the
Swaps/Bridge formatAddressToAssetId, the app would crash with:

Error: No XChain Swaps native asset found for chainId: eip155:59141

Reproduction Steps:

  1. Navigate to a custom network (e.g., Fantom with chainId 0xfa)
  2. Select any token on that network
  3. App crashes when trying to display token details

Solution

Added a try-catch wrapper around the formatAddressToAssetId call in
Price.advanced.tsx. When the function throws an error for unsupported
chains:

Changelog

CHANGELOG entry: Fix navigation error on token details page when coming
from custom network flow

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
  • Use these power-user
    SRPs

    to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production
    performance metrics
  • See trace() for usage and
    addToken
    for an example

For performance guidelines and tooling, see the Performance
Guide
.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
Low risk: a small defensive change that only affects advanced price
chart initialization, with added tests covering unsupported-chain
fallbacks.

Overview
Prevents crashes in PriceAdvanced on unsupported/custom networks by
wrapping formatAddressToAssetId in a try/catch and using an empty
assetId when formatting fails, allowing the UI to fall back to
PriceLegacy
instead of throwing.

Extends Price.advanced.test.tsx with coverage for custom/unsupported
chainIds (including Linea Sepolia) and verifies useOHLCVChart is
invoked with assetId: '' in the failure case, while supported networks
still render the advanced chart.

Reviewed by Cursor Bugbot for commit
706896b. Bugbot is set up for automated
code reviews on this repo. Configure
here.

[fd69c19](https://github.com/MetaMask/metamask-mobile/commit/fd69c191bff186e20d12d204ba2189ed4f17aade)

…custom network cp-7.74.0 (#28972)

## **Description**

Fixes a crash that occurred when viewing token details on custom or
unsupported networks (e.g., Fantom, Linea Sepolia, custom EVM chains).

### Issue

When users navigated to token details on networks not supported by the
Swaps/Bridge `formatAddressToAssetId`, the app would crash with:

```
Error: No XChain Swaps native asset found for chainId: eip155:59141
```

**Reproduction Steps:**
1. Navigate to a custom network (e.g., Fantom with chainId `0xfa`)
2. Select any token on that network
3. App crashes when trying to display token details

### Solution

Added a try-catch wrapper around the `formatAddressToAssetId` call in
`Price.advanced.tsx`. When the function throws an error for unsupported
chains:


## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: Fix navigation error on token details page when coming
from custom network flow

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk: a small defensive change that only affects advanced price
chart initialization, with added tests covering unsupported-chain
fallbacks.
> 
> **Overview**
> Prevents crashes in `PriceAdvanced` on unsupported/custom networks by
wrapping `formatAddressToAssetId` in a `try/catch` and using an empty
`assetId` when formatting fails, allowing the UI to **fall back to
`PriceLegacy`** instead of throwing.
> 
> Extends `Price.advanced.test.tsx` with coverage for custom/unsupported
chainIds (including Linea Sepolia) and verifies `useOHLCVChart` is
invoked with `assetId: ''` in the failure case, while supported networks
still render the advanced chart.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
706896b. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested a review from a team as a code owner April 17, 2026 14:45
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Apr 17, 2026
@github-actions github-actions Bot added the risk-high Extensive testing required · High bug introduction risk label Apr 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - PR targets a release branch (release/*)

All E2E tests pre-selected.

View GitHub Actions results

@chloeYue chloeYue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chloeYue chloeYue enabled auto-merge (squash) April 17, 2026 14:54
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details

@chloeYue chloeYue merged commit 133322d into release/7.74.00 Apr 17, 2026
111 checks passed
@chloeYue chloeYue deleted the runway-cherry-pick-7.74.0-1776437136 branch April 17, 2026 15:47
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

risk-high Extensive testing required · High bug introduction risk size-M team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants