Skip to content

refactor: handle universal links from Braze notif deeplinks [GE-188]#28973

Merged
baptiste-marchand merged 1 commit into
mainfrom
GE-188-braze-deeplinks-skip-interstitial
Apr 17, 2026
Merged

refactor: handle universal links from Braze notif deeplinks [GE-188]#28973
baptiste-marchand merged 1 commit into
mainfrom
GE-188-braze-deeplinks-skip-interstitial

Conversation

@baptiste-marchand

@baptiste-marchand baptiste-marchand commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Description

This PR adds support for universal links from Braze push notification deeplinks. It also removes the interstitial from this source, alongside all trusted sources (carousels, push notifications, Braze push notifications and in-app notifications).

Relevant documentation:
https://www.braze.com/docs/developer_guide/push_notifications/deep_linking?tab=objective-c&sdktab=swift
https://www.braze.com/docs/partners/message_orchestration/deeplinking/branch_for_deeplinking/?tab=objective-c

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/GE-188

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Cold & Hot Start: Deeplink Flow Requirements

  1. Open deeplinks without interstitial

Send test notifications with deeplinks from Braze and NaaP

→ Expect: Direct open, no interstitial

  1. Open deeplinks with interstitial

Open deeplinks from your notes
Open a deeplink from a QR code (e.g., generated here) pointing to: https://link.metamask.io/trending

→ Expect: Interstitial displayed before opening

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes deep-link routing and interstitial behavior for several in-app origins, plus adds iOS-native Braze URL interception, which could affect notification/universal-link navigation and analytics flows if misrouted.

Overview
Enables Braze push-notification deep links on iOS to correctly resolve universal links by forwarding Branch domains from BrazeDelegate.shouldOpenURL to Branch, while suppressing Braze’s default URL opening to avoid duplicate deliveries.

Updates deep-link interstitial logic in handleUniversalLink so a defined set of trusted in-app sources (carousel, in-app notification, push notification, Braze) skip the interstitial for both public and private links; other in-app sources now show the modal. The Braze JS listener is no longer Android-gated, and corresponding tests are updated.

Bumps mobile build numbers (versionCode/CURRENT_PROJECT_VERSION/Bitrise version numbers) to 4543.

Reviewed by Cursor Bugbot for commit ee0c232. Bugbot is set up for automated code reviews on this repo. Configure here.

@baptiste-marchand baptiste-marchand requested a review from a team as a code owner April 17, 2026 13:20
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@baptiste-marchand baptiste-marchand force-pushed the GE-188-braze-deeplinks-skip-interstitial branch from c01d60d to 395a642 Compare April 17, 2026 13:20
@baptiste-marchand baptiste-marchand changed the title refactor: handle universal links from Braze notif deeplinks & remove … refactor: handle universal links from Braze notif deeplinks Apr 17, 2026
@github-actions github-actions Bot added size-M risk-medium Moderate testing recommended · Possible bug introduction risk labels Apr 17, 2026
@baptiste-marchand baptiste-marchand changed the title refactor: handle universal links from Braze notif deeplinks refactor: handle universal links from Braze notif deeplinks [GE-188] Apr 17, 2026
Comment thread app/core/Braze/BrazeDeeplinks.ts
@baptiste-marchand baptiste-marchand added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Apr 17, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ee0c232. Configure here.

Comment thread ios/MetaMask/AppDelegate.m
jbblanc
jbblanc previously approved these changes Apr 17, 2026
@baptiste-marchand baptiste-marchand force-pushed the GE-188-braze-deeplinks-skip-interstitial branch from ee0c232 to 395a642 Compare April 17, 2026 14:59
@github-actions github-actions Bot added risk-high Extensive testing required · High bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Apr 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeCard, SmokePerps, SmokeRamps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, FlaskBuildTests
  • Selected Performance tags: @PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps
  • Risk Level: high
  • AI Confidence: %
click to see 🤖 AI reasoning details

E2E Test Selection:
Fallback: AI analysis did not complete successfully. Running all tests.

Performance Test Selection:
Fallback: AI analysis did not complete successfully. Running all performance tests.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details

@samir-acle samir-acle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baptiste-marchand baptiste-marchand added this pull request to the merge queue Apr 17, 2026
Merged via the queue into main with commit 0c8c5c3 Apr 17, 2026
334 of 341 checks passed
@baptiste-marchand baptiste-marchand deleted the GE-188-braze-deeplinks-skip-interstitial branch April 17, 2026 16:41
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 17, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.75.0 Issue or pull request that will be included in release 7.75.0 label Apr 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.75.0 Issue or pull request that will be included in release 7.75.0 risk-high Extensive testing required · High bug introduction risk size-M team-engagement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants