Skip to content

fix: fix block explorer redirection cp-7.74.0#28966

Merged
sahar-fehri merged 2 commits into
mainfrom
fix/fix-block-explorer-redirection
Apr 17, 2026
Merged

fix: fix block explorer redirection cp-7.74.0#28966
sahar-fehri merged 2 commits into
mainfrom
fix/fix-block-explorer-redirection

Conversation

@sahar-fehri

@sahar-fehri sahar-fehri commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes the block explorer URL generation for Solana SPL tokens in the Security Trust screen. The params.address contains a full CAIP asset type ID (e.g., solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp/token:USD1ttGY1N17NEEHLmELoaybftRBUSErhqYiQzvEmuB) but the block explorer URL template expects just the raw token address.

This change extracts the assetReference from the CAIP asset type before passing it to getBlockExplorerTokenUrl.

Changelog

CHANGELOG entry: Fix block explorer redirection for solana.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3076?focusedCommentId=412599

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Screen.Recording.2026-04-17.at.11.51.22.mov

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: a small, localized change to external link URL generation plus targeted unit tests; main risk is incorrect CAIP parsing leading to broken explorer links for some non-EVM assets.

Overview
Fixes block explorer redirection from SecurityTrustScreen by detecting CAIP asset type addresses and passing only the parsed assetReference (e.g., Solana mint) into getBlockExplorerTokenUrl instead of the full CAIP identifier.

Updates SecurityTrustScreen.test.tsx to make route params configurable and adds assertions that EVM addresses are passed through unchanged while Solana CAIP addresses are correctly parsed before URL generation (with useBlockExplorer now mocked to verify calls).

Reviewed by Cursor Bugbot for commit a5464e1. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added size-XS risk-low Low testing needed · Low bug introduction risk labels Apr 17, 2026
@github-actions github-actions Bot added size-M and removed size-XS labels Apr 17, 2026
@sahar-fehri sahar-fehri changed the title fix: fix block explorer redirection fix: fix block explorer redirection cp-7.74.0 Apr 17, 2026
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Apr 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are limited to two files: SecurityTrustScreen.tsx and its unit test file. The production change is a narrow bug fix that adds CAIP asset type detection before constructing block explorer URLs for tokens - when a token address is in CAIP format (e.g., Solana tokens), it extracts the assetReference before passing to getBlockExplorerTokenUrl. The test file refactors mock setup and adds two new unit tests for this behavior. No E2E tests exist for SecurityTrustScreen (confirmed by searching for SecurityTrust/SECURITY_TRUST in e2e and spec files). The change does not touch any shared components (navigation, modals, confirmations), controllers, Engine, or any infrastructure that could affect other test flows. This is a pure unit-level fix with no E2E test coverage needed.

Performance Test Selection:
The change is a simple conditional check (isCaipAssetType + parseCaipAssetType) before constructing a block explorer URL. This has negligible performance impact - it's a string parsing operation that runs once when the SecurityTrustScreen renders with a non-native token. No performance tests are warranted.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@sahar-fehri sahar-fehri added this pull request to the merge queue Apr 17, 2026
Merged via the queue into main with commit 47ee978 Apr 17, 2026
69 checks passed
@sahar-fehri sahar-fehri deleted the fix/fix-block-explorer-redirection branch April 17, 2026 11:00
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 17, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.75.0 Issue or pull request that will be included in release 7.75.0 label Apr 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.75.0 Issue or pull request that will be included in release 7.75.0 risk-low Low testing needed · Low bug introduction risk size-M team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants