Skip to content

feat(perps): add no_orders translation string#28964

Merged
michalconsensys merged 2 commits into
mainfrom
perps-cancel-all-orders-view
Apr 17, 2026
Merged

feat(perps): add no_orders translation string#28964
michalconsensys merged 2 commits into
mainfrom
perps-cancel-all-orders-view

Conversation

@michalconsensys

@michalconsensys michalconsensys commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Description

Adds the no_orders translation string ("You do not have any open orders") to the perps locale section. This supports displaying a user-friendly empty state message when there are no open orders in the perpetuals trading view.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TAT-2967

Manual testing steps

Feature: Perps open orders empty state

  Scenario: User views open orders when none exist
    Given the user is on the perpetuals trading view
    And the user has no open orders

    When the user navigates to the orders tab
    Then the user sees a "You do not have any open orders" message

Screenshots/Recordings

N/A — locale string addition only, no UI change in this PR.

Before

After

Simulator Screenshot - iPhone 17 Pro Max - 2026-04-17 at 11 21 57

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: adds a single i18n string with no logic or behavioral changes.

Overview
Adds a new perps order locale entry, no_orders, with the message "You do not have any open orders" to support an open-orders empty state.

Reviewed by Cursor Bugbot for commit 6a45f62. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-perps Perps team label Apr 17, 2026
@michalconsensys michalconsensys changed the title feat(perps): add "no open orders" translation string feat(perps): add no_orders translation string Apr 17, 2026
@michalconsensys michalconsensys marked this pull request as ready for review April 17, 2026 09:24
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details

@michalconsensys michalconsensys added this pull request to the merge queue Apr 17, 2026
Merged via the queue into main with commit f4a7ed2 Apr 17, 2026
123 checks passed
@michalconsensys michalconsensys deleted the perps-cancel-all-orders-view branch April 17, 2026 10:34
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 17, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.75.0 Issue or pull request that will be included in release 7.75.0 label Apr 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.75.0 Issue or pull request that will be included in release 7.75.0 size-XS team-perps Perps team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants