Skip to content

chore(perps): remove unused estimated fee rate constant#28957

Merged
abretonc7s merged 1 commit into
mainfrom
perps/rm-unused-fee-rate
Apr 17, 2026
Merged

chore(perps): remove unused estimated fee rate constant#28957
abretonc7s merged 1 commit into
mainfrom
perps/rm-unused-fee-rate

Conversation

@geositta

@geositta geositta commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Description

Removed the unused ESTIMATED_FEE_RATE export from the perps HyperLiquid config after the reverse position fee precheck logic was deleted.

The constant was previously only used for a stale entry price based local fee estimate in flipPosition(), and once that logic was removed it became dead code with no remaining references.

The improvement is a small cleanup that keeps the perps config aligned with actual runtime usage and avoids carrying an orphaned fee constant that no longer drives any validation or execution behavior.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Pure cleanup removing an unused constant with no runtime behavior changes, aside from potential breakage for any external imports of ESTIMATED_FEE_RATE.

Overview
Removes the unused ESTIMATED_FEE_RATE export from hyperLiquidConfig.ts, eliminating dead configuration now that fee precheck/flip estimation logic is gone.

Reviewed by Cursor Bugbot for commit 744640b. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-perps Perps team label Apr 16, 2026
@geositta geositta force-pushed the perps/rm-unused-fee-rate branch from d8abdc4 to 744640b Compare April 16, 2026 23:58
@geositta geositta marked this pull request as ready for review April 16, 2026 23:58
@geositta geositta requested a review from a team as a code owner April 16, 2026 23:58
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details

@abretonc7s abretonc7s enabled auto-merge April 17, 2026 02:12
@abretonc7s abretonc7s added this pull request to the merge queue Apr 17, 2026
Merged via the queue into main with commit 9a50ca2 Apr 17, 2026
123 checks passed
@abretonc7s abretonc7s deleted the perps/rm-unused-fee-rate branch April 17, 2026 02:27
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 17, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.75.0 Issue or pull request that will be included in release 7.75.0 label Apr 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.75.0 Issue or pull request that will be included in release 7.75.0 size-XS team-perps Perps team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants