Skip to content

feat: adds auth to social api#28919

Merged
joaosantos15 merged 11 commits into
mainfrom
TSA-395-social-api-auth
Apr 17, 2026
Merged

feat: adds auth to social api#28919
joaosantos15 merged 11 commits into
mainfrom
TSA-395-social-api-auth

Conversation

@joaosantos15

@joaosantos15 joaosantos15 commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Description

Adds AuthenticationController to the social-service-messenger to be used by the core social package.

Changelog

CHANGELOG entry: no-changelog

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Adds delegation for AuthenticationController:getBearerToken into the SocialService messenger and upgrades @metamask/social-controllers to ^1.0.0, which could affect how auth tokens are fetched and used by social API calls.

Overview
Enables SocialService code to request authentication by delegating AuthenticationController:getBearerToken through getSocialServiceMessenger, so the social controllers can fetch a bearer token via the root messenger.

Upgrades @metamask/social-controllers from ^0.2.0 to ^1.0.0 (and updates yarn.lock accordingly), pulling in new transitive dependencies (notably @metamask/profile-sync-controller).

Reviewed by Cursor Bugbot for commit a42cf50. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-social-ai Social & AI team label Apr 16, 2026
@joaosantos15 joaosantos15 marked this pull request as ready for review April 16, 2026 14:13
@joaosantos15 joaosantos15 enabled auto-merge April 17, 2026 07:51
@github-actions github-actions Bot added the risk-high Extensive testing required · High bug introduction risk label Apr 17, 2026
@joaosantos15 joaosantos15 disabled auto-merge April 17, 2026 08:09
@github-actions github-actions Bot added risk-high Extensive testing required · High bug introduction risk and removed risk-high Extensive testing required · High bug introduction risk labels Apr 17, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5c5c16e. Configure here.

Comment thread package.json Outdated
@joaosantos15 joaosantos15 enabled auto-merge April 17, 2026 08:28
@github-actions github-actions Bot added risk-high Extensive testing required · High bug introduction risk and removed risk-high Extensive testing required · High bug introduction risk labels Apr 17, 2026
zone-live
zone-live previously approved these changes Apr 17, 2026
@github-actions github-actions Bot added risk-high Extensive testing required · High bug introduction risk and removed risk-high Extensive testing required · High bug introduction risk labels Apr 17, 2026
@github-actions github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-high Extensive testing required · High bug introduction risk labels Apr 17, 2026
@github-actions github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Apr 17, 2026
@github-actions github-actions Bot added risk-high Extensive testing required · High bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Apr 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeCard, SmokePerps, SmokeRamps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, FlaskBuildTests
  • Selected Performance tags: @PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps
  • Risk Level: high
  • AI Confidence: 100%
click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/social-controllers. Running all tests.

Performance Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/social-controllers. Running all tests.

View GitHub Actions results

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​social-controllers@​0.2.0 ⏵ 1.0.07410076 +193 +2100

View full report

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details

@joaosantos15 joaosantos15 added this pull request to the merge queue Apr 17, 2026
Merged via the queue into main with commit efbdbdc Apr 17, 2026
205 of 207 checks passed
@joaosantos15 joaosantos15 deleted the TSA-395-social-api-auth branch April 17, 2026 11:23
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 17, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.75.0 Issue or pull request that will be included in release 7.75.0 label Apr 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.75.0 Issue or pull request that will be included in release 7.75.0 risk-high Extensive testing required · High bug introduction risk size-XS team-social-ai Social & AI team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants