Skip to content

fix(earn): match Figma spec for claim bonus tag shape#28903

Merged
Kureev merged 2 commits into
mainfrom
kureev/MUSD-634
Apr 16, 2026
Merged

fix(earn): match Figma spec for claim bonus tag shape#28903
Kureev merged 2 commits into
mainfrom
kureev/MUSD-634

Conversation

@Kureev

@Kureev Kureev commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Description

The "3% bonus" tag in the Asset Overview "Your bonus" section (reached from the Money page / mUSD token detail view) was rendered with the legacy design-system TagBase defaults (4px border radius, 8px horizontal padding), which drift from the current Figma spec (node 9740:12682).

Rather than replace TagBase with a custom component, this PR overrides only the two style values that differ from the design so the colors and text styling continue to come from the TagSeverity.Success preset.

What changed

  • borderRadius: 4 → 8
  • paddingHorizontal: 8 → 6

Colors (success.muted background, success.default text), vertical padding, and typography already match.

Changelog

CHANGELOG entry: null

Related issues

Fixes: MUSD-634

Manual testing steps

Feature: mUSD claim bonus tag shape

  Scenario: user opens the mUSD asset detail screen
    Given the user has mUSD holdings
    When the user navigates to the mUSD asset overview
    Then the "3% bonus" tag next to the "Your bonus" heading has an 8px border radius and 6px horizontal padding
    And the tag uses the success (green) color tokens

Screenshots/Recordings

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Purely a small UI styling tweak to the mUSD bonus TagBase, with no changes to business logic, data flow, or analytics.

Overview
Updates the Asset Overview “Your bonus” section to match the Figma spec by overriding the TagBase styling for the “3% bonus” tag.

Adds a local StyleSheet and applies style={styles.bonusTag} to adjust only the tag’s borderRadius (to 8) and paddingHorizontal (to 6), leaving the existing severity-driven colors and typography unchanged.

Reviewed by Cursor Bugbot for commit 13471d9. Bugbot is set up for automated code reviews on this repo. Configure here.

@Kureev Kureev requested a review from a team as a code owner April 16, 2026 09:39
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added size-XS risk-low Low testing needed · Low bug introduction risk labels Apr 16, 2026
@Kureev Kureev self-assigned this Apr 16, 2026
@Kureev Kureev enabled auto-merge April 16, 2026 11:42
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Apr 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeTrade
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
The change is a minimal UI styling fix in AssetOverviewClaimBonus.tsx within the Earn/staking feature. It adds a StyleSheet with borderRadius: 8 and paddingHorizontal: 6 applied to a TagBase component that displays a bonus percentage tag. No logic, state management, or functional behavior is changed. The component is used in AssetOverviewContent (TokenDetails) and CashTokensFullView, both part of the Earn/staking flow. The staking/earn tests are tagged under SmokeTrade (confirmed via tests/smoke/stake/stake-action-smoke.spec.ts). No other tags are needed since this is a purely cosmetic change with no impact on confirmations, accounts, networks, or other features. SmokeConfirmations is not required as a dependent tag here since the change doesn't touch swap/bridge flows directly - it's a styling fix in the earn bonus display component.

Performance Test Selection:
This is a purely cosmetic styling change (borderRadius and paddingHorizontal on a single TagBase component). It does not affect rendering performance, data loading, state management, or any critical user flows in a measurable way. No performance tests are warranted.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
11 value mismatches detected (expected — fixture represents an existing user).
View details

@Kureev Kureev added this pull request to the merge queue Apr 16, 2026
Merged via the queue into main with commit d90a85e Apr 16, 2026
77 of 78 checks passed
@Kureev Kureev deleted the kureev/MUSD-634 branch April 16, 2026 14:46
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 16, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.74.0 Issue or pull request that will be included in release 7.74.0 label Apr 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.74.0 Issue or pull request that will be included in release 7.74.0 risk-low Low testing needed · Low bug introduction risk size-XS team-earn

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants