feat: hold time label and wiring#28873
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2e2d625. Configure here.
c78af96 to
b1ee5e5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28873 +/- ##
===========================================
- Coverage 82.28% 42.47% -39.82%
===========================================
Files 5034 5038 +4
Lines 132095 132131 +36
Branches 29484 29506 +22
===========================================
- Hits 108698 56117 -52581
- Misses 16012 70768 +54756
+ Partials 7385 5246 -2139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
|
|
✅ E2E Fixture Validation — Schema is up to date |




Description
The trader profile StatsRow currently shows a dash placeholder for avg hold time with the label "avg. hold".
Changes
TSA-408
Changelog
CHANGELOG entry: Added hold time to trader profile view
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Low risk UI/i18n wiring change plus a minor dependency bump; main risk is mismatched API fields from
@metamask/social-controllers@0.2.0causing hold time or follow-state defaults to regress.Overview
Trader profile stats now display hold time from the API by wiring
profile.stats.medianHoldMinutesintoStatsRowvia a renamed prop (holdTimeMinutes).Updates the i18n label from
avg. holdtohold time, adjustsStatsRowunit tests accordingly, and bumps@metamask/social-controllersto^0.2.0(updating default background/log snapshot state to includeSocialController.followingProfileIds).Reviewed by Cursor Bugbot for commit 6de3166. Bugbot is set up for automated code reviews on this repo. Configure here.