chore: migrating money account deposit fund alert to alert system#28724
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Key changes:
Tag selection reasoning:
The change is medium risk - it modifies the alert system for a specific transaction type (moneyAccountDeposit) and could affect user flows in Perps and Card features if the alert incorrectly blocks or fails to block transactions. Performance Test Selection: |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c92ce45. Configure here.
|
✅ E2E Fixture Validation — Schema is up to date |
|
| InsufficientPayTokenFees = 'insufficient_pay_token_fees', | ||
| InsufficientPerpsBalance = 'insufficient_perps_balance', | ||
| InsufficientPredictBalance = 'insufficient_predict_balance', | ||
| AccountNoFunds = 'account_no_funds', |
| [AlertKeys.InsufficientPayTokenNative]: 'insufficient_funds_for_gas', | ||
| [AlertKeys.InsufficientPerpsBalance]: 'insufficient_funds', | ||
| [AlertKeys.InsufficientPredictBalance]: 'insufficient_funds', | ||
| [AlertKeys.AccountNoFunds]: 'account_no_funds', |




Description
Using alert system for money account related errors.
Changelog
CHANGELOG entry:
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1182
Manual testing steps
Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Changes how
moneyAccountDeposit“no funds” is surfaced by introducing a new blocking alert and wiring it into the shared pending-amount alert pipeline, which can affect confirm-button enablement and user flow. Risk is limited to confirmations/UX and is covered by added unit tests.Overview
Moves the
moneyAccountDeposit“no funds” state into the confirmations alert system by introducing a new blockingAccountNoFundsalert (with metrics mapping) and feeding it throughusePendingAmountAlerts.Removes the old inline “no funds” red text from
CustomAmountInfo, updates tests to assert alert-driven rendering, and adds new i18n underalert_system.account_no_fundswhile deleting the legacyconfirm.no_funds_use_different_accountstring.Reviewed by Cursor Bugbot for commit c92ce45. Bugbot is set up for automated code reviews on this repo. Configure here.