feat: full-page account selector and optional picker dropdown icon#28701
Conversation
…t UI with modal - Always use full-page account list (drop selectFullPageAccountListEnabledFlag) - Swap BottomSheet overlay and BottomSheetFooter for Modal and inline footer buttons - Update unit tests for full-page and add-wallet modal behavior Made-with: Cursor
…ckerAccount - Default keeps existing dropdown arrow for other pickers - PickerAccount omits prop and always hides the icon Made-with: Cursor
| <Button | ||
| key={index} | ||
| style={ | ||
| index > 0 | ||
| ? styles.footerButtonSubsequent | ||
| : styles.footerButton | ||
| } | ||
| {...buttonProp} |
There was a problem hiding this comment.
We'll keep this as it is despite the warning from sonar
…to gar/feat/account-selector-full-page-picker-dropdown
AI PR Analysis🚫 Merge safe: false | 🟠 Risk: high
AI analysis did not complete. Manual review recommended. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 33a3e80. Configure here.
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found All E2E tests pre-selected. |
|
|
✅ E2E Fixture Validation — Schema is up to date |
georgewrmarshall
left a comment
There was a problem hiding this comment.
Approving on behalf of @MetaMask/design-system-engineers
owencraston
left a comment
There was a problem hiding this comment.
Tested loading a short accounts list, long accounts list and dapp connection. all worked as expected.
Description
This PR consolidates the account selector on the full-page experience and removes the feature flag that toggled it. The add-wallet / add-account flow no longer uses bottom sheet components; it opens in a standard
Modalwith the same headers and actions as before.Changelog
CHANGELOG entry: Updated the account selector to use the full-page list for all users.
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1695
Manual testing steps
Screenshots/Recordings
Before
N/A
After
Screen.Recording.2026-04-23.at.1.14.15.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Moderate UI/navigation refactor in the account selector flow, replacing bottom-sheet behavior with animated full-page + nested modal, which could affect dismissal/navigation and related tests across platforms.
Overview
Unifies
AccountSelectoronto the animated full-page presentation for all users by removing the full-page feature-flag path and the bottom-sheet implementation.The add-account/add-wallet actions now open via a standard
Modalwith its own header/back handling, and the footer action buttons are rendered directly (new footer styles) instead of usingBottomSheetFooter. Tests and E2E page objects were updated accordingly (including snapshot updates and using a header back button to dismiss stacked modals).Separately, the wallet
PickerAccountno longer applies dropdown-arrow sizing/styling (removing the trailing dropdown affordance).Reviewed by Cursor Bugbot for commit 34f2a20. Bugbot is set up for automated code reviews on this repo. Configure here.