Skip to content

chore: cherry pick 28423#28540

Merged
tommasini merged 2 commits into
release/7.73.0from
chore/cherry-pick-28423
Apr 8, 2026
Merged

chore: cherry pick 28423#28540
tommasini merged 2 commits into
release/7.73.0from
chore/cherry-pick-28423

Conversation

@tommasini

@tommasini tommasini commented Apr 8, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

cherry-pick #28423

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Reworks release-candidate build orchestration and notification plumbing across multiple GitHub Actions workflows; misconfiguration could cause missing/incorrect RC builds, version bumps, or Slack/PR announcements.

Overview
Auto RC builds are refactored to run through the reusable runway-ota-build-core.yml: iOS RC runs first (and performs the version bump), then Android RC runs with skip_version_bump, replacing the prior inline Bitrise-trigger script approach.

Adds a reusable slack-rc-notification.yml workflow and a new scripts/get-build-metadata.sh to read semver + iOS/Android build numbers from the checked-out branch; PR comments and Slack messages now use these values and fall back to linking the GitHub Actions run when no Android public install URL is available.

Removes the manual build-rc-create.yml workflow, updates Runway RC workflows to post Slack notifications after success, and adjusts build.yml/metadata emission to rely on the shared build-metadata script (including ensuring Node is available before reading metadata).

Reviewed by Cursor Bugbot for commit fa89d6b. Bugbot is set up for automated code reviews on this repo. Configure here.

@tommasini tommasini requested a review from a team as a code owner April 8, 2026 14:26
@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Apr 8, 2026
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk size-M and removed risk-low Low testing needed · Low bug introduction risk labels Apr 8, 2026
@sonarqubecloud

sonarqubecloud Bot commented Apr 8, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Apr 8, 2026
@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
All 11 changed files are exclusively CI/CD infrastructure changes with no impact on app source code, test infrastructure, or E2E test behavior:

  1. GitHub workflow files (.github/workflows/) - These modify the RC build pipeline: refactoring build-rc-auto.yml to use runway-ota-build-core.yml, deleting build-rc-create.yml, adding a new reusable slack-rc-notification.yml workflow, and minor updates to runway-android-rc-workflow.yml, runway-ios-production-workflow.yml, runway-ios-rc-workflow.yml, and runway-ota-build-core.yml.

  2. Scripts (scripts/) - New get-build-metadata.sh script centralizes build metadata reading; post-rc-build-comment.mjs and slack-rc-notification.mjs are updated to use generic pipeline URLs and separate iOS/Android build numbers instead of Bitrise-specific variables.

None of these changes:

  • Touch any app source code (no React Native components, controllers, hooks, or utilities)
  • Modify any E2E test files or test infrastructure (no tests/ directory changes)
  • Affect any shared components that E2E tests interact with
  • Change any build configuration that would affect the app bundle (metro.config.js, babel.config.js, package.json are untouched)
  • Impact app performance in any way

The changes are purely about how RC builds are triggered, how build metadata is read, and how Slack/PR notifications are posted after builds complete. Running E2E tests would provide no validation value for these changes.

Performance Test Selection:
All changes are CI/CD infrastructure only - no app source code, UI components, state management, or performance-sensitive code paths were modified. Performance tests are not relevant for workflow and script changes.

View GitHub Actions results

@tommasini tommasini merged commit e7967a1 into release/7.73.0 Apr 8, 2026
25 of 38 checks passed
@tommasini tommasini deleted the chore/cherry-pick-28423 branch April 8, 2026 17:15
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weitingsun weitingsun weitingsun approved these changes

Assignees

No one assigned

Labels

risk-low Low testing needed · Low bug introduction risk size-M team-mobile-platform Mobile Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tommasini @weitingsun @metamaskbot