test: Sync Feature Flag Registry - 2026-04-07 01:42 UTC#28444
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28444 +/- ##
==========================================
- Coverage 82.14% 82.14% -0.01%
==========================================
Files 4949 4949
Lines 130070 130077 +7
Branches 29004 29005 +1
==========================================
+ Hits 106851 106854 +3
- Misses 15923 15926 +3
- Partials 7296 7297 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
For all tests with the |
| // Exclude 'nba' — NBA markets render PredictGameDetailsContent which uses a different cash-out testID not yet supported by E2E page objects | ||
| predictLiveSports: { | ||
| versions: { | ||
| '7.67.0': { enabled: true, leagues: ['nfl'] }, |
There was a problem hiding this comment.
This is needed because on PROD NBA is now added to the live sports category which makes the predict tests that use Spurs vs Pelicans as test mocks to fail because it renders a different component(cash out button). A new ticket created to clean up the mocks and update the tests
| ...remoteFeatureFlagHomepageSectionsV1Enabled(), | ||
| ...remoteFeatureFlagPredictEnabled(true), | ||
| carouselBanners: false, | ||
| exploreSectionsOrder: { |
There was a problem hiding this comment.
The exploreSectionsOrder is set to {} on PROD, this causes the tests to fail because the sections are not displayed. New ticket created to investigate and fix
| testSpecificMock: async (mockServer: Mockttp) => { | ||
| await setupMockRequest(mockServer, { | ||
| requestMethod: 'GET', | ||
| url: /^https:\/\/digest\.api\.cx\.metamask\.io\/api\/v1\/asset-summary/, |
There was a problem hiding this comment.
Why is this suddenly needed? Should this be mocked in more places than just this test?
There was a problem hiding this comment.
the test started to fail without this mock because we synced the tests with all enabled feature flags on PROD. If this is not needed then the test should override the specific mocks that cause this call to happen.
There was a problem hiding this comment.
I don't have context for when this API is called, but I find it strange that this mock isn't required in other tests that use the send flow?
There was a problem hiding this comment.
I am not sure either, the test started to fail because of this API call being made from the app. This call had to be added in a lot of different tests you can see that in this PR
There was a problem hiding this comment.
Since it is required in multiple tests should it be generally mocked in the test framework? Apologies if that wasn't clear at first, that was the intention with my question.
There was a problem hiding this comment.
Ah yes you are right, I did add it to the default mocks and then forgot to clean up some tests 🙈 Will push an update
311c878
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found All E2E tests pre-selected. |
|
|
✅ E2E Fixture Validation — Schema is up to date |
Feature Flag Registry Drift Report
Feature flag drift was detected between E2E tests and production.
Download the
drift-reportartifact for the full report.