chore(fonts): remove remaining Geist-Bold references#28425
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| }, | ||
| androidFont: { | ||
| regular: 'Geist-Regular', | ||
| medium: 'Geist-Medium', | ||
| bold: 'Geist-Bold', | ||
| bold: 'Geist-SemiBold', |
There was a problem hiding this comment.
@MetaMask/card This keeps bold mapping aligned with the semibold migration, but it should be temporary. Please migrate to Text from @metamask/design-system-react-native.
| @@ -29,7 +29,7 @@ export const createStyles = (colors: any) => | |||
| questionLabel: { | |||
| fontSize: 18, | |||
| paddingHorizontal: 30, | |||
| fontFamily: 'Geist-Bold', | |||
| fontFamily: 'Geist-SemiBold', | |||
There was a problem hiding this comment.
@MetaMask/mobile-platform This keeps bold mapping aligned with the semibold migration, but it should be temporary. Please migrate to Text from @metamask/design-system-react-native.
| @@ -56,12 +56,12 @@ const VerifyIdentity = () => { | |||
| iOSFont: { | |||
| regular: 'Geist-Regular', | |||
| medium: 'Geist-Medium', | |||
| bold: 'Geist-Bold', | |||
| bold: 'Geist-SemiBold', | |||
There was a problem hiding this comment.
@MetaMask/card This keeps bold mapping aligned with the semibold migration, but it should be temporary. Please migrate to Text from @metamask/design-system-react-native.
beb5905 to
89f069d
Compare
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - draft PR All E2E tests pre-selected. |
|
|
✅ E2E Fixture Validation — Schema is up to date |
Description
Starting cleanup PR for semibold migration by removing remaining static
Geist-Bold/Geist-BoldItalicreferences and deleting obsolete bold font assets.This PR:
Geist-Boldusages withGeist-SemiBoldboldslotGeist-Bold.otfandGeist-BoldItalic.otffrom Expo font config and native asset manifestsapp/fontsChangelog
CHANGELOG entry: null
Related issues
Fixes: #28387
Related:
Manual testing steps
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Medium risk because it removes bundled font assets and native registrations; any missed
Geist-Bold/Geist-BoldItalicreferences could cause font fallback or missing-font issues at runtime.Overview
Completes the semibold migration cleanup by replacing remaining UI usages of
Geist-BoldwithGeist-SemiBold(including Veriff branding inVerifyIdentity, the malicious dapp connect button label, and Review Modal header text).Removes the
Geist-Bold.otfandGeist-BoldItalic.otfassets from Expo font configuration and both Android/iOS asset manifests, and drops the corresponding iOS Xcode project andInfo.plistfont registrations so the bold files are no longer bundled.Reviewed by Cursor Bugbot for commit 89f069d. Bugbot is set up for automated code reviews on this repo. Configure here.