ci: migrate perf builds from bitrise to GHA by cortisiko · Pull Request #28420 · MetaMask/metamask-mobile

cortisiko · 2026-04-06T17:08:26Z

Description

Performance E2E BrowserStack builds are migrated off Bitrise and onto GitHub Actions. The Android/iOS dual-build workflows now call the reusable build.yml workflow (instead of triggering/polling Bitrise), download the resulting APK/IPA artifacts, and upload them to BrowserStack while emitting BrowserStack URLs/app IDs/versions.

Build variants and configs were reshaped for BrowserStack use. New builds.yml entries add dedicated BrowserStack build profiles for with SRP vs seedless onboarding (and exp vs e2e BrowserStack flavors), plus package.json scripts to target these build names; scripts/build.sh now honors IS_BROWSERSTACK_BUILD to avoid emulator-only settings (x86_64 arch restriction and IS_SIM_BUILD=true).

Performance workflow triggering/variants were adjusted. run-performance-e2e-release.yml now runs on pushes only for metamaskbot version-bump commits and explicitly forces build_variant: rc, while the main performance workflow defaults build_variant to exp and updates concurrency grouping and conditional steps accordingly.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Medium risk due to broad CI/build pipeline changes (workflows, build profiles, artifact handling) that can break build/upload automation or alter build-time flags for e2e/perf runs.

Overview
Moves Android/iOS “dual build + BrowserStack upload” workflows from Bitrise-trigger/polling to the reusable build.yml GitHub Actions workflow, then downloads the resulting APK/IPA artifacts and uploads them to BrowserStack while emitting URLs/app IDs/versions.

Reshapes build variants and configs for BrowserStack/performance usage by adding new builds.yml build profiles (e2e BrowserStack with/without SRP; RC/EXP with/without SRP), adding matching package.json build scripts, and teaching scripts/build.sh to honor IS_BROWSERSTACK_BUILD (skip emulator-only x86_64 restrictions and avoid forcing IS_SIM_BUILD=true).

Updates performance/system workflows to default/validate build_variant including e2e, adjust concurrency grouping and gating (including release runs only on metamaskbot version-bump commits and forcing build_variant: rc), and adds IS_PERFORMANCE_TEST to disable E2E runtime overhead while keeping E2E_MOCK_OAUTH Metro mocks active; also includes small Playwright stability tweaks (hide keyboard) and hard-codes perf FF env to test for now.

^{Reviewed by Cursor Bugbot for commit 5c1e858. Bugbot is set up for automated code reviews on this repo. Configure here.}

This reverts commit 3f499c9.

This reverts commit 1e82991.

check again

This reverts commit f350f4f.

This reverts commit 467e017.

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

There are 4 total unresolved issues (including 2 from previous reviews).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit bd85377. Configure here.}

codecov-commenter · 2026-05-13T19:41:29Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.80%. Comparing base (3751d9a) to head (5c1e858).
⚠️ Report is 185 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #28420      +/-   ##
==========================================
+ Coverage   81.54%   81.80%   +0.26%     
==========================================
  Files        5343     5403      +60     
  Lines      142128   144011    +1883     
  Branches    32411    32873     +462     
==========================================
+ Hits       115899   117811    +1912     
+ Misses      18299    18173     -126     
- Partials     7930     8027      +97

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…r perf tests

… into MMQA-1633

github-actions · 2026-05-14T14:24:25Z

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found

All E2E tests pre-selected.

View GitHub Actions results

sonarqubecloud · 2026-05-14T14:42:14Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

tommasini · 2026-05-14T15:00:18Z


      - name: Upload Android AAB
-        if: matrix.platform == 'android' && env.CONFIGURATION != 'Debug'
+        if: matrix.platform == 'android' && env.CONFIGURATION != 'Debug' && steps.rename.outputs.android_aab_path != ''


This sees a nice safeguard ! Thanks!

ci: migrate perf builds from bitrise to GHA

3f499c9

metamaskbot added the team-qa QA team label Apr 6, 2026

github-actions Bot added the size-XL label Apr 6, 2026

cortisiko added 4 commits April 6, 2026 13:22

Revert "ci: migrate perf builds from bitrise to GHA"

ed12998

This reverts commit 3f499c9.

migrate workflows

c39c145

fix permissions

ecb2751

fix permission

bab58d1

cortisiko had a problem deploying to build-rc April 6, 2026 18:20 — with GitHub Actions Failure

cortisiko had a problem deploying to build-rc April 6, 2026 18:21 — with GitHub Actions Failure

cortisiko had a problem deploying to build-rc April 6, 2026 18:24 — with GitHub Actions Failure

cortisiko added 4 commits April 6, 2026 14:37

Merge branch 'main' into MMQA-1633

d123b18

change from rc to test env

1e82991

Revert "change from rc to test env"

5bee421

This reverts commit 1e82991.

try building in e2e env instead

5fbb08a

cortisiko had a problem deploying to build-e2e April 6, 2026 19:41 — with GitHub Actions Failure

clean up secrets

19d60eb

cortisiko had a problem deploying to build-e2e April 6, 2026 20:17 — with GitHub Actions Failure

add build scripts

d618a3d

cortisiko had a problem deploying to build-e2e April 6, 2026 20:43 — with GitHub Actions Failure

cortisiko had a problem deploying to build-e2e April 6, 2026 20:44 — with GitHub Actions Failure

cortisiko had a problem deploying to build-e2e April 6, 2026 20:46 — with GitHub Actions Failure

ensure builds for browserstack devices

aad97bd

Merge branch 'main' into MMQA-1633

e5e9fa9

cortisiko added the force-builds Forces e2e native builds to trigger label May 12, 2026

cursor Bot reviewed May 12, 2026

View reviewed changes

Comment thread .github/workflows/build-ios-upload-to-browserstack.yml

Comment thread .github/workflows/build-ios-upload-to-browserstack.yml Outdated

cortisiko added 2 commits May 12, 2026 18:07

remove process.env.METAMASK_ENVIRONMENT == 'e2e'

f350f4f

check again

fix linting issue

6c279a2

cursor Bot reviewed May 12, 2026

View reviewed changes

Comment thread .github/workflows/build-android-upload-to-browserstack.yml

cortisiko temporarily deployed to build-e2e May 12, 2026 22:24 — with GitHub Actions Inactive

Revert "remove process.env.METAMASK_ENVIRONMENT == 'e2e'"

5879a16

This reverts commit f350f4f.

cursor Bot reviewed May 13, 2026

View reviewed changes

Comment thread .github/workflows/build-android-upload-to-browserstack.yml

temp fix: money account balance

467e017

cursor Bot reviewed May 13, 2026

View reviewed changes

Comment thread builds.yml

Revert "temp fix: money account balance"

bd85377

This reverts commit 467e017.

cursor Bot reviewed May 13, 2026

View reviewed changes

Comment thread builds.yml

Comment thread .github/workflows/build-ios-upload-to-browserstack.yml

cortisiko added 9 commits May 13, 2026 16:03

skip cold start after wallet import for now

4171ba0

Merge branch 'main' into MMQA-1633

c50a4df

address cursor

32d5eae

create a dedicated perf env variable since we are using e2e builds fo…

fc5cbbb

…r perf tests

metro config check

84c5b31

Merge branch 'main' into MMQA-1633

34a0717

Revert "skip cold start after wallet import for now"

7c79231

Merge branch 'MMQA-1633' of https://github.com/MetaMask/metamask-mobile…

f078097

… into MMQA-1633

fix samsung tests: dismiss keyboard to create wallet

b66f55b

christopherferreira9 approved these changes May 14, 2026

View reviewed changes

Merge branch 'main' into MMQA-1633

5c1e858

tommasini reviewed May 14, 2026

View reviewed changes

tommasini approved these changes May 14, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ci: migrate perf builds from bitrise to GHA#28420

ci: migrate perf builds from bitrise to GHA#28420
cortisiko merged 56 commits into
mainfrom
MMQA-1633

cortisiko commented Apr 6, 2026 •

edited by cursor Bot

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented May 13, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

sonarqubecloud Bot commented May 14, 2026

Uh oh!

tommasini May 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

cortisiko commented Apr 6, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented May 14, 2026

🔍 Smart E2E Test Selection

Uh oh!

sonarqubecloud Bot commented May 14, 2026

Quality Gate passed

Uh oh!

tommasini May 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cortisiko commented Apr 6, 2026 •

edited by cursor Bot

Loading

codecov-commenter commented May 13, 2026 •

edited

Loading