fix(ramps): match Build Quote payment pill to payment selection modal#28392
Merged
Conversation
- Build Quote: pass selected payment method into PaymentMethodPill and render PaymentMethodIcon so the leading icon matches the method (generic card when unset).\n- Apple Pay: use branded mark assets; swap useAssetFromTheme order for PaymentMethodIcon so the mark contrasts on muted/section backgrounds (checkout button keeps original mapping).\n- Tests: PaymentMethodPill coverage; BuildQuote snapshots updated.\n- Docs: PR screenshot helper and after screenshot under docs/ramps/. Made-with: Cursor
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Made-with: Cursor
- Add parseRampPaymentType so API strings only match SDK PaymentType values.\n- PaymentMethodIcon: switch on normalized type, handle RevPay, unknown types fall back to card (not wallet).\n- PaymentMethodPill: render PaymentMethodIcon only when type is known or API icons exist; type PaymentMethodForPill for icons.\n- Tests for parser and pill edge cases. Made-with: Cursor
- before: captured with paymentMethod prop temporarily omitted (generic card in pill).\n- after: current Build Quote with fix.\n- Update pull-request-screenshots.md; PR body references raw GitHub URLs. Made-with: Cursor
- Remove docs/ramps PNGs and pull-request-screenshots.md (keep images in PR description only).\n- Ignore docs/ramps/*.png so local captures are not re-committed. Made-with: Cursor
- Use FontAwesome apple for Apple Pay; ignore API apple-pay mark glyphs - Remove Apple Pay PNG from PaymentMethodIcon (restore main-style vectors) - PaymentMethodPill: type-only icons via parseRampPaymentType - Match main default icon fallback in PaymentMethodIcon switch Made-with: Cursor
Made-with: Cursor
Use the same PaymentMethodIcon + paymentType pattern as PaymentMethodListItem (primary icon color). Drop parseRampPaymentType from the pill path. Made-with: Cursor
- Revert PaymentMethodIcon and Aggregator snapshots to match origin/main - Remove parseRampPaymentType util + test (never on main) Unified Buy v2 pill parity remains in Views/BuildQuote + PaymentMethodPill only. Made-with: Cursor
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - draft PR All E2E tests pre-selected. |
Contributor
|
✅ E2E Fixture Validation — Schema is up to date |
|
imyugioh
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unified Buy v2 Build Quote on
mainshows the generic card icon in the payment pill even when a real method (e.g. Apple Pay) is selected, because the pill did not receivepaymentMethod.This PR passes
selectedPaymentMethodintoPaymentMethodPill, which rendersPaymentMethodIconthe same way asPaymentMethodListItemin the payment selection modal:paymentMethodTypewith the same cast, andcolors.primary.defaultfor the icon (parity with a selected row in the sheet). No extra parsing helpers and no Aggregator changes.Changelog
CHANGELOG entry: Fixed payment method icon on Buy Build Quote to match the payment selection modal
Related issues
Refs: TRAM-3401
Manual testing steps
Screenshots/Recordings
Before (
mainbranch)After (this PR)
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk UI-only change: the Build Quote payment pill now renders a real payment-method icon when a payment type is available, with test/snapshot updates. No changes to quote fetching, routing, or controllers.
Overview
Build Quote’s payment pill now mirrors the payment selection modal iconography.
BuildQuotepassesselectedPaymentMethodintoPaymentMethodPill, enabling the pill to renderPaymentMethodIcon(primary color) when apaymentTypeis present, and fall back to the generic card icon otherwise.Tests were updated to include
paymentTypein the mocked payment method, add coverage for renderingPaymentMethodIconon any non-emptypaymentType, and refresh affected snapshots.Reviewed by Cursor Bugbot for commit f0bf9dd. Bugbot is set up for automated code reviews on this repo. Configure here.