Skip to content

fix: fix text size when the user increases it cp-7.73.0#28340

Merged
zone-live merged 2 commits into
mainfrom
TSA-fix-font-size-increasing
Apr 3, 2026
Merged

fix: fix text size when the user increases it cp-7.73.0#28340
zone-live merged 2 commits into
mainfrom
TSA-fix-font-size-increasing

Conversation

@zone-live

@zone-live zone-live commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Description

Before the text and layout were not adjusting when the user increased the font size in the phone, now it does:

Simulator Screenshot - iPhone 16e - 2026-04-02 at 13 00 56 Simulator Screenshot - iPhone 16e - 2026-04-02 at 13 00 45 Screenshot 2026-04-02 at 13 00 32 Simulator Screenshot - iPhone 16e - 2026-04-02 at 13 01 24

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI-only layout changes to improve Dynamic Type behavior; main potential issue is unintended spacing/overlap regressions in the SlidingTextCarousel container across devices and font scales.

Overview
Improves Market Insights entry card layout under larger system font sizes.

SlidingTextCarousel no longer relies on a fixed container height; it now uses an invisible two-line "sizer" Text to establish height from actual font metrics (and pins animated text to top: 0) so the rotating text doesn’t clip/overlap when Dynamic Type scales.

The footer disclaimer text in MarketInsightsEntryCard is also marked as shrink to avoid layout overflow next to the info icon.

Written by Cursor Bugbot for commit 30fb5ef. This will update automatically on new commits. Configure here.

@github-actions

github-actions Bot commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-social-ai Social & AI team label Apr 2, 2026
@github-actions github-actions Bot added size-S risk-low Low testing needed · Low bug introduction risk labels Apr 2, 2026
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Apr 2, 2026
@github-actions

github-actions Bot commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform, SmokePerps
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The two changed files are purely UI/layout fixes within the MarketInsightsEntryCard component:

  1. MarketInsightsEntryCard.tsx: Adds twClassName="shrink" to a footer disclaimer Text component — a minor CSS flex-shrink fix to prevent text overflow.

  2. SlidingTextCarousel.tsx: Removes the hardcoded h-[44px] height constraint and replaces it with an invisible sizer Text element that dynamically establishes container height based on actual font metrics. This enables proper Dynamic Type (accessibility font scaling) support.

These are purely cosmetic/layout changes with no logic, controller, navigation, or state management impact.

Component usage:

  • AssetOverviewContent.tsx (TokenDetails page) — part of the wallet platform/token details flow → SmokeWalletPlatform
  • PerpsMarketDetailsView.tsx (Perps market details) → SmokePerps

Per SmokePerps tag description, selecting SmokePerps also requires SmokeWalletPlatform (Trending section) and SmokeConfirmations (Add Funds deposits are on-chain transactions). However, since the changes don't touch any confirmation or transaction flows, and the risk is low, I'm including SmokeWalletPlatform as the primary coverage area. SmokePerps is included because the component is directly used in PerpsMarketDetailsView.

No accounts, identity, network, confirmations, or trade flows are affected by these changes.

Performance Test Selection:
The changes are purely cosmetic layout fixes (CSS flex-shrink and dynamic height sizing). While the SlidingTextCarousel change replaces a fixed height with dynamic sizing, this is a very localized UI component change that does not affect data loading, state management, list rendering at scale, or any critical user flow performance. No performance tests are warranted.

View GitHub Actions results

@github-actions

github-actions Bot commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

@sonarqubecloud

sonarqubecloud Bot commented Apr 2, 2026

Copy link
Copy Markdown

@zone-live zone-live changed the title fix: fix text size when the user increases it fix: fix text size when the user increases it cp-7.73.0 Apr 3, 2026
@zone-live zone-live added this pull request to the merge queue Apr 3, 2026
Merged via the queue into main with commit 43a952d Apr 3, 2026
233 of 270 checks passed
@zone-live zone-live deleted the TSA-fix-font-size-increasing branch April 3, 2026 18:45
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 3, 2026
@metamaskbot metamaskbot added the release-7.74.0 Issue or pull request that will be included in release 7.74.0 label Apr 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.74.0 Issue or pull request that will be included in release 7.74.0 risk-low Low testing needed · Low bug introduction risk size-S team-social-ai Social & AI team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants