chore(runway): cherry-pick chore(deps): suppress xmldom CDATA serialization audit advisory#28237
Conversation
…zation audit advisory (#28235) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> CI `yarn npm audit` is failing due to advisory [1115765](GHSA-wh4c-j3r5-mjhp) — an XML injection via unsafe CDATA serialization in `xmldom`. There is no fix available in our dependency tree yet. This PR temporarily suppresses the advisory in `.yarnrc.yml` `npmAuditIgnoreAdvisories` to unblock CI, following the same pattern used for the existing `bn.js` suppressions. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** N/A ## **Screenshots/Recordings** ### **Before** N/A ### **After** N/A ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- Generated with the help of the pr-description AI skill --> Made with [Cursor](https://cursor.com) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Low code-change risk, but it *suppresses a known security advisory* (`xmldom` XML injection) so vulnerabilities may go unnoticed until the dependency is upgraded. > > **Overview** > Updates `.yarnrc.yml` to add advisory `1115765` to `npmAuditIgnoreAdvisories`, suppressing the `xmldom` CDATA serialization XML-injection audit finding to unblock `yarn npm audit`/CI. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit f4adc9c. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
No E2E tests need to run for this change as it has zero impact on app behavior, UI flows, or test infrastructure. Performance Test Selection: |
|



Description
CI
yarn npm auditis failing due to advisory1115765 — an XML
injection via unsafe CDATA serialization in
xmldom. There is no fixavailable in our dependency tree yet.
This PR temporarily suppresses the advisory in
.yarnrc.ymlnpmAuditIgnoreAdvisoriesto unblock CI, following the same patternused for the existing
bn.jssuppressions.Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
N/A
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Made with Cursor
Note
Medium Risk
Low code-change risk, but it suppresses a known security advisory
(
xmldomXML injection) so vulnerabilities may go unnoticed until thedependency is upgraded.
Overview
Updates
.yarnrc.ymlto add advisory1115765tonpmAuditIgnoreAdvisories, suppressing thexmldomCDATA serializationXML-injection audit finding to unblock
yarn npm audit/CI.Written by Cursor
Bugbot for commit
f4adc9c. This will update automatically
on new commits. Configure
here.