Skip to content

chore(runway): cherry-pick chore(deps): suppress xmldom CDATA serialization audit advisory#28237

Merged
chloeYue merged 1 commit into
release/7.72.0from
runway-cherry-pick-7.72.0-1775034595
Apr 1, 2026
Merged

chore(runway): cherry-pick chore(deps): suppress xmldom CDATA serialization audit advisory#28237
chloeYue merged 1 commit into
release/7.72.0from
runway-cherry-pick-7.72.0-1775034595

Conversation

@runway-github

@runway-github runway-github Bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Description

CI yarn npm audit is failing due to advisory
1115765 — an XML
injection via unsafe CDATA serialization in xmldom. There is no fix
available in our dependency tree yet.

This PR temporarily suppresses the advisory in .yarnrc.yml
npmAuditIgnoreAdvisories to unblock CI, following the same pattern
used for the existing bn.js suppressions.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Made with Cursor


Note

Medium Risk
Low code-change risk, but it suppresses a known security advisory
(xmldom XML injection) so vulnerabilities may go unnoticed until the
dependency is upgraded.

Overview
Updates .yarnrc.yml to add advisory 1115765 to
npmAuditIgnoreAdvisories, suppressing the xmldom CDATA serialization
XML-injection audit finding to unblock yarn npm audit/CI.

Written by Cursor
Bugbot
for commit
f4adc9c. This will update automatically
on new commits. Configure
here.

[353ba9e](https://github.com/MetaMask/metamask-mobile/commit/353ba9ec9a1c3e4dac752340e51a525bd85d0e59)

…zation audit advisory (#28235)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

CI `yarn npm audit` is failing due to advisory
[1115765](GHSA-wh4c-j3r5-mjhp) — an XML
injection via unsafe CDATA serialization in `xmldom`. There is no fix
available in our dependency tree yet.

This PR temporarily suppresses the advisory in `.yarnrc.yml`
`npmAuditIgnoreAdvisories` to unblock CI, following the same pattern
used for the existing `bn.js` suppressions.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

N/A

## **Screenshots/Recordings**

### **Before**

N/A

### **After**

N/A

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- Generated with the help of the pr-description AI skill -->

Made with [Cursor](https://cursor.com)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Low code-change risk, but it *suppresses a known security advisory*
(`xmldom` XML injection) so vulnerabilities may go unnoticed until the
dependency is upgraded.
> 
> **Overview**
> Updates `.yarnrc.yml` to add advisory `1115765` to
`npmAuditIgnoreAdvisories`, suppressing the `xmldom` CDATA serialization
XML-injection audit finding to unblock `yarn npm audit`/CI.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
f4adc9c. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Apr 1, 2026
@github-actions github-actions Bot added the risk-low Low testing needed · Low bug introduction risk label Apr 1, 2026
@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 98%
click to see 🤖 AI reasoning details

E2E Test Selection:
The only change in .yarnrc.yml is adding advisory ID 1115765 to the npmAuditIgnoreAdvisories list. This suppresses a yarn security audit warning about XML injection via unsafe CDATA serialization (GHSA-wh4c-j3r5-mjhp). This is a pure CI/audit configuration change that:

  1. Does not modify any application code or dependencies
  2. Does not change any package versions
  3. Does not affect any test infrastructure or test files
  4. Does not impact any user-facing functionality
  5. Simply prevents yarn audit from flagging this advisory to unblock CI

No E2E tests need to run for this change as it has zero impact on app behavior, UI flows, or test infrastructure.

Performance Test Selection:
This change only adds a security advisory suppression to yarn audit configuration. There is no impact on app performance, rendering, data loading, or any other performance-sensitive area.

View GitHub Actions results

@chloeYue chloeYue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud

sonarqubecloud Bot commented Apr 1, 2026

Copy link
Copy Markdown

@chloeYue chloeYue merged commit c314db7 into release/7.72.0 Apr 1, 2026
113 checks passed
@chloeYue chloeYue deleted the runway-cherry-pick-7.72.0-1775034595 branch April 1, 2026 09:49
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

risk-low Low testing needed · Low bug introduction risk size-XS team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants