feat: adding money account withdraw confirmation page by jpuri · Pull Request #28181 · MetaMask/metamask-mobile

jpuri · 2026-03-31T16:02:48Z

Description

Adding money account withdraw page.

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1105

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Screen.Recording.2026-04-01.at.9.44.18.PM.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Adds a new moneyAccountWithdraw confirmation path and updates editable tx recipient (to) from the UI, which affects transaction construction and user confirmation behavior.

Overview
Adds first-class support for Money Account Withdraw confirmations across the redesigned confirmation flow (full-screen handling, alert-banner suppression, post-quote token behavior, and default footer hiding).

Introduces a new MoneyAccountWithdrawInfo screen and updates CustomAmountInfo to render a recipient AccountSelector for withdraws, updating the transaction’s editable to field and blocking confirmation until a recipient is chosen.

Refactors the recipient picker by renaming/replacing MoneyAccountSelector with a reusable AccountSelector (case-insensitive selected address matching), updates developer tooling to pass an explicit withdraw recipient, and adds the corresponding en.json title string plus tests.

^{Reviewed by Cursor Bugbot for commit a39a6d7. Bugbot is set up for automated code reviews on this repo. Configure here.}

…sk-mobile into trxn_ctrl_update

…tamask-mobile into money_acc_dev_option

…countSelector

github-actions · 2026-03-31T16:03:03Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

jpuri · 2026-04-06T09:32:11Z

@metamaskbot update-mobile-fixture

github-actions · 2026-04-06T16:33:24Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeCard, SmokeConfirmations, SmokePerps, SmokePredictions, SmokeTrade, SmokeWalletPlatform
Selected Performance tags: None (no tests recommended)
Risk Level: medium
AI Confidence: 82%

click to see 🤖 AI reasoning details

E2E Test Selection:
The PR introduces a new moneyAccountWithdraw transaction type and flow in the confirmations system, along with a rename of MoneyAccountSelector → AccountSelector. Key changes:

New MoneyAccountWithdrawInfo component: New withdrawal flow for Money Account (Card feature), routed via info-root.tsx.
CustomAmountInfo refactored: Layout changes (box gap changed from 25→16, afterPayWith prop removed, AccountSelector embedded directly for moneyAccountWithdraw). This component is shared across perps deposit/withdraw, predict deposit, and money account deposit/withdraw flows.
Constants updated: moneyAccountWithdraw added to REDESIGNED_TRANSACTION_TYPES, FULL_SCREEN_CONFIRMATIONS, POST_QUOTE_TRANSACTION_TYPES, HIDE_FOOTER_BY_DEFAULT_TYPES, TRANSACTION_TYPES_DISABLE_ALERT_BANNER.
AccountSelector rename: MoneyAccountSelector renamed to AccountSelector with test ID changes.
Locales: New "Withdraw funds" string added.

Tag selection rationale:

SmokeCard: Directly affected - new withdraw flow, deposit info simplified, AccountSelector renamed
SmokeConfirmations: Affected - footer, confirm-component, info-root, and CustomAmountInfo layout changes affect the confirmation UI system broadly
SmokePerps: Affected - CustomAmountInfo layout refactoring (box gap, structure changes) could affect perps deposit/withdraw rendering
SmokePredictions: Affected - CustomAmountInfo is used by predict-deposit-info; layout changes could affect rendering
SmokeTrade: Required by SmokeCard description ("also select SmokeTrade and SmokeConfirmations")
SmokeWalletPlatform: Required by SmokePerps and SmokePredictions descriptions ("also select SmokeWalletPlatform")

The changes are scoped to the confirmations/Card/Money Account area with no impact on accounts, identity, network, or ramps features.

Performance Test Selection:
The changes are focused on the confirmations UI for the Money Account withdraw flow - a new transaction type routing, component rename, and layout refactoring of CustomAmountInfo. These are not performance-sensitive changes (no list rendering, no data loading changes, no startup/initialization impact). The CustomAmountInfo layout changes are minor structural adjustments that don't affect rendering performance metrics.

View GitHub Actions results

github-actions · 2026-04-06T16:51:39Z

✅ E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

codecov-commenter · 2026-04-06T16:55:38Z

Codecov Report

❌ Patch coverage is 79.16667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.96%. Comparing base (62ea975) to head (a39a6d7).
⚠️ Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
...nts/info/custom-amount-info/custom-amount-info.tsx	61.53%	3 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #28181      +/-   ##
==========================================
+ Coverage   82.93%   82.96%   +0.02%     
==========================================
  Files        4881     4878       -3     
  Lines      126469   126413      -56     
  Branches    28369    28374       +5     
==========================================
- Hits       104889   104877      -12     
+ Misses      14363    14327      -36     
+ Partials     7217     7209       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sonarqubecloud · 2026-04-06T16:56:39Z

Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jpuri added 28 commits March 26, 2026 17:05

chore: update @metamask/transaction-controller to version 63.2.0

9fed848

Merge branch 'main' into trxn_ctrl_update

d166928

update

5e8913a

Merge branch 'trxn_ctrl_update' of https://github.com/MetaMask/metama…

34d36f6

…sk-mobile into trxn_ctrl_update

feat: adding dev options for money account deposit / withdraw

d55bd61

update

99990c6

Merge branch 'main' into money_acc_dev_option

87d7751

Merge branch 'money_acc_dev_option' of https://github.com/MetaMask/me…

6517501

…tamask-mobile into money_acc_dev_option

update

56761e0

update

c4c8c27

feat: adding info section for money account deposit

7815c57

update

ded7aee

update

9ebce8b

update

a54a528

Merge branch 'main' into money_acc_dev_option

5c9502e

update

a8f130b

merge

da28f73

update

6d90ddc

update

bb7f4c6

feat: add recipient account input on money account deposit page

7b1b60e

feat(deposit): replace address input with account selector in MoneyAc…

e6d338c

…countSelector

update

20e5894

test(deposit): add missing branch coverage for MoneyAccountDepositInfo

b477429

Merge branch 'money_acc_address_input' into money_acc_account_select

c546890

chore(deposit): sort imports in MoneyAccountSelector

391529e

feat(deposit): restrict MoneyAccountSelector to EVM accounts only

ca2595b

merge

fd9b21c

Merge branch 'money_acc_address_input' into money_acc_account_select

68af583

metamaskbot added the team-confirmations Push issues to confirmations team label Mar 31, 2026

update

5e5123d

cursor Bot reviewed Apr 2, 2026

View reviewed changes

Comment thread ...confirmations/components/info/money-account-deposit-info/money-account-deposit-info.test.tsx

Base automatically changed from money_acc_account_select to main April 2, 2026 13:30

merge

7235b94

jpuri enabled auto-merge April 2, 2026 13:36

github-actions Bot added size-L risk-medium Moderate testing recommended · Possible bug introduction risk and removed size-M labels Apr 2, 2026

update

db7e763

cursor Bot reviewed Apr 2, 2026

View reviewed changes

Comment thread app/components/Views/confirmations/components/AccountSelector/AccountSelector.tsx

update

adc698f

github-actions Bot added size-M risk-medium Moderate testing recommended · Possible bug introduction risk and removed size-L risk-medium Moderate testing recommended · Possible bug introduction risk labels Apr 2, 2026

cursor Bot reviewed Apr 2, 2026

View reviewed changes

Comment thread ...ws/confirmations/components/info/money-account-withdraw-info/money-account-withdraw-info.tsx

vinistevam approved these changes Apr 6, 2026

View reviewed changes

Merge branch 'main' into money_acc_withdraw

a39a6d7

github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Apr 6, 2026

jpuri added this pull request to the merge queue Apr 6, 2026

Merged via the queue into main with commit 0d42616 Apr 6, 2026
79 of 82 checks passed

github-actions Bot locked and limited conversation to collaborators Apr 6, 2026

metamaskbot added the release-7.74.0 Issue or pull request that will be included in release 7.74.0 label Apr 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: adding money account withdraw confirmation page#28181

feat: adding money account withdraw confirmation page#28181
jpuri merged 68 commits into
mainfrom
money_acc_withdraw

jpuri commented Mar 31, 2026 •

edited by cursor Bot

Loading

Uh oh!

github-actions Bot commented Mar 31, 2026

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

jpuri commented Apr 6, 2026

Uh oh!

github-actions Bot commented Apr 6, 2026

Uh oh!

github-actions Bot commented Apr 6, 2026

Uh oh!

codecov-commenter commented Apr 6, 2026

Uh oh!

sonarqubecloud Bot commented Apr 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

jpuri commented Mar 31, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Mar 31, 2026

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jpuri commented Apr 6, 2026

Uh oh!

github-actions Bot commented Apr 6, 2026

🔍 Smart E2E Test Selection

Uh oh!

github-actions Bot commented Apr 6, 2026

Uh oh!

codecov-commenter commented Apr 6, 2026

Codecov Report

Uh oh!

sonarqubecloud Bot commented Apr 6, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jpuri commented Mar 31, 2026 •

edited by cursor Bot

Loading