chore: social - traders list leaderboard by zone-live · Pull Request #28170 · MetaMask/metamask-mobile

zone-live · 2026-03-31T14:15:00Z

Description

Wires up the Social Leaderboard to live data from the Social API.
Integrate the social-controllers (SocialService + SocialController) into the Engine, adds useTopTraders hook using useQuery from @metamask/react-data-query to fetch leaderboard data through the Data Services pattern.
Also adds the homepage TopTradersSection (horizontal card carousel) and the full TopTradersView (ranked list) with skeleton loading states.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Adds a new Social data service/controller to the Engine and wires UI screens to fetch live leaderboard data from a new SOCIAL_API_URL, which could impact app startup/state persistence and introduce new network failure modes.

Overview
Adds live Social Leaderboard integration by introducing Engine-managed SocialService and SocialController (new messengers, init wiring, persisted state, and data-service registration) and configuring a new SOCIAL_API_URL build/env constant.

Updates the homepage TopTradersSection to fetch and render the top 3 traders (cards + skeleton loading, refresh via ref, hide when empty/flag off) and upgrades TopTradersView to display the full ranked list with a network filter entry point and follow toggles.

Includes new UI components (TopTraderCard, TraderRow, skeletons, NetworkFilterButton), a formatPnl formatter, the useTopTraders hook built on @metamask/react-data-query, plus expanded unit tests and updated mocks/strings.

^{Reviewed by Cursor Bugbot for commit 5881e59. Bugbot is set up for automated code reviews on this repo. Configure here.}

github-actions · 2026-03-31T14:15:26Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2026-03-31T14:24:04Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/@metamask/social-controllers@0.1.0

View full report

zone-live · 2026-04-01T13:15:07Z

@SocketSecurity ignore npm/@metamask-previews/social-controllers@0.0.0-preview-ac7a6cc51

socket-security · 2026-04-02T13:58:07Z

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

npm/@metamask/social-controllers@0.1.0

View full report

zone-live · 2026-04-02T14:03:55Z

@SocketSecurity ignore npm/@metamask/social-controllers@0.1.0

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 5f9424f. Configure here.}

github-actions · 2026-04-13T09:20:20Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeCard, SmokePerps, SmokeRamps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, FlaskBuildTests
Selected Performance tags: @PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps
Risk Level: high
AI Confidence: 100%

click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/social-controllers. Running all tests.

Performance Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/social-controllers. Running all tests.

View GitHub Actions results

sonarqubecloud · 2026-04-13T09:39:32Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-04-13T09:50:50Z

✅ E2E Fixture Validation — Schema is up to date
11 value mismatches detected (expected — fixture represents an existing user).
View details

zone-live added 9 commits March 27, 2026 15:27

chore: adds the initial setup for leaderboard

3731883

chore: review points

56fe30f

chore: tests update

b315bbc

chore: update

60c8de0

chore: UI update

e615d55

Merge branch 'main' into TSA-114-traders-list-leaderboard

434c01b

chore: button foolow | following

84d9e79

chore: integrates core controller and service in the Top Traders feature

8d75c90

chore: api url

154509c

Merge branch 'main' into TSA-114-traders-list-leaderboard

0f5f7d0

github-actions Bot added the size-XL label Mar 31, 2026

chore: mock useQuery

0d54e09

zone-live added the team-social-ai Social & AI team label Mar 31, 2026

zone-live added 6 commits March 31, 2026 18:11

Merge branch 'main' into TSA-114-traders-list-leaderboard

8f74d86

chore: lock update

7de904b

chore: adds mocked data

dac5f62

chore: adds mocked data

e9a1a06

chore: calls the Social Dev API

f5cb2b0

Merge branch 'main' into TSA-114-traders-list-leaderboard

0529476

MetaMask deleted a comment from socket-security Bot Apr 1, 2026

zone-live added 7 commits April 1, 2026 14:36

chore: update test

360ecef

chore: update initial-background-state.json

8f4558a

chore: update snapshots

7422558

chore: fix addCommas

955b334

chore: update and clean up

0764134

chore: update and clean up

3d3ddd5

Merge branch 'main' into TSA-114-traders-list-leaderboard

bbe85b2

cursor Bot reviewed Apr 2, 2026

View reviewed changes

Comment thread app/components/Views/SocialLeaderboard/TopTradersView/TopTradersView.tsx

chore: remove preview package and add correct one

5554c47

github-actions Bot added risk-high Extensive testing required · High bug introduction risk and removed risk-high Extensive testing required · High bug introduction risk labels Apr 2, 2026

Merge branch 'main' into TSA-114-traders-list-leaderboard

e2b056d

github-actions Bot added risk-high Extensive testing required · High bug introduction risk and removed risk-high Extensive testing required · High bug introduction risk labels Apr 13, 2026

cursor Bot reviewed Apr 13, 2026

View reviewed changes

Comment thread app/components/Views/Homepage/Sections/TopTraders/TopTradersSection.tsx

Comment thread app/components/Views/Homepage/Sections/TopTraders/TopTradersSection.tsx

chore: review update and lint fix

5f9424f

github-actions Bot added risk-high Extensive testing required · High bug introduction risk and removed risk-high Extensive testing required · High bug introduction risk labels Apr 13, 2026

cursor Bot reviewed Apr 13, 2026

View reviewed changes

Comment thread app/components/Views/SocialLeaderboard/TopTradersView/TopTradersView.test.tsx

Comment thread app/core/AppConstants.ts Outdated

chore: review update

5881e59

github-actions Bot added risk-high Extensive testing required · High bug introduction risk and removed risk-high Extensive testing required · High bug introduction risk labels Apr 13, 2026

zone-live requested a review from joaosantos15 April 13, 2026 10:19

zone-live enabled auto-merge April 13, 2026 10:22

joaosantos15 approved these changes Apr 13, 2026

View reviewed changes

tommasini approved these changes Apr 13, 2026

View reviewed changes

zone-live added this pull request to the merge queue Apr 13, 2026

Merged via the queue into main with commit cc65ec5 Apr 13, 2026
112 of 113 checks passed

zone-live deleted the TSA-114-traders-list-leaderboard branch April 13, 2026 12:53

github-actions Bot locked and limited conversation to collaborators Apr 13, 2026

metamaskbot added the release-7.74.0 Issue or pull request that will be included in release 7.74.0 label Apr 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: social - traders list leaderboard#28170

chore: social - traders list leaderboard#28170
zone-live merged 40 commits into
mainfrom
TSA-114-traders-list-leaderboard

zone-live commented Mar 31, 2026 •

edited by cursor Bot

Loading

Uh oh!

github-actions Bot commented Mar 31, 2026

Uh oh!

socket-security Bot commented Mar 31, 2026 •

edited

Loading

Uh oh!

zone-live commented Apr 1, 2026

Uh oh!

Uh oh!

socket-security Bot commented Apr 2, 2026 •

edited

Loading

Uh oh!

zone-live commented Apr 2, 2026

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

sonarqubecloud Bot commented Apr 13, 2026

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

zone-live commented Mar 31, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Mar 31, 2026

Uh oh!

socket-security Bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zone-live commented Apr 1, 2026

Uh oh!

Uh oh!

socket-security Bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zone-live commented Apr 2, 2026

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 13, 2026

🔍 Smart E2E Test Selection

Uh oh!

sonarqubecloud Bot commented Apr 13, 2026

Quality Gate passed

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zone-live commented Mar 31, 2026 •

edited by cursor Bot

Loading

socket-security Bot commented Mar 31, 2026 •

edited

Loading

socket-security Bot commented Apr 2, 2026 •

edited

Loading