Skip to content

test: adds a retry to the android system images install#28107

Merged
christopherferreira9 merged 2 commits into
mainfrom
cferreira/add-retry-android-system-images-install
Apr 6, 2026
Merged

test: adds a retry to the android system images install#28107
christopherferreira9 merged 2 commits into
mainfrom
cferreira/add-retry-android-system-images-install

Conversation

@christopherferreira9

@christopherferreira9 christopherferreira9 commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Description

This PR adds the retry mechanism to the Android System images through nick-fields/retry

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk workflow-only change that adds retries around sdkmanager to mitigate flaky installs; main risk is slightly longer CI time when retries trigger.

Overview
Improves CI resilience for Android E2E APK builds by running the sdkmanager system image install step via nick-fields/retry (up to 3 attempts with a 10-minute timeout and 30s backoff).

No build logic changes beyond wrapping this one workflow step in a retryable action.

Written by Cursor Bugbot for commit faee66a. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner March 30, 2026 17:48
@christopherferreira9 christopherferreira9 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Mar 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added size-S risk-low Low testing needed · Low bug introduction risk labels Mar 30, 2026
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 30, 2026
@christopherferreira9 christopherferreira9 changed the title tests: adds a retry to the android system images install test: adds a retry to the android system images install Mar 30, 2026
@christopherferreira9 christopherferreira9 added the skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run label Mar 30, 2026
@github-actions github-actions Bot added risk-high Extensive testing required · High bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 30, 2026
@github-actions github-actions Bot added risk-high Extensive testing required · High bug introduction risk and removed risk-high Extensive testing required · High bug introduction risk labels Mar 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

@christopherferreira9 christopherferreira9 added this pull request to the merge queue Apr 6, 2026
Merged via the queue into main with commit 3e7f8c0 Apr 6, 2026
170 of 227 checks passed
@christopherferreira9 christopherferreira9 deleted the cferreira/add-retry-android-system-images-install branch April 6, 2026 15:06
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 6, 2026
@metamaskbot metamaskbot added the release-7.74.0 Issue or pull request that will be included in release 7.74.0 label Apr 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.74.0 Issue or pull request that will be included in release 7.74.0 risk-high Extensive testing required · High bug introduction risk size-S skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants