Skip to content

revert(perps): add Perps Withdraw confirmation flow and post-quote config#28105

Merged
christopherferreira9 merged 1 commit into
mainfrom
revert-28046-perps-withdraw-confirmation
Mar 30, 2026
Merged

revert(perps): add Perps Withdraw confirmation flow and post-quote config#28105
christopherferreira9 merged 1 commit into
mainfrom
revert-28046-perps-withdraw-confirmation

Conversation

@christopherferreira9

@christopherferreira9 christopherferreira9 commented Mar 30, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Reverts #28046 which was blocking E2E.

Note

Medium Risk
Reverts perps-withdraw-specific confirmation/pay behavior and downgrades @metamask/transaction-pay-controller, which can subtly affect transaction-pay quoting/config and related UI/metrics.

Overview
Reverts the perps withdraw confirmation integration by removing TransactionType.perpsWithdraw special-casing across confirmations (alert banner/footer visibility, back-navigation, insufficient-balance ignoring, bridge-fee tooltip messaging, custom-amount calculations, and pay metrics/tests).

Simplifies useTransactionPayPostQuote to always set refundTo via the Predict Safe proxy and removes the Hyperliquid/perps-withdraw config path.

Adjusts CI to tighten the iOS JS bundle size threshold (54 → 53) and downgrades @metamask/transaction-pay-controller (with corresponding lockfile/state snapshot updates, including removal of some persisted state fields like providerAutoSelected/tokenWarnings).

Written by Cursor Bugbot for commit d322782. This will update automatically on new commits. Configure here.

@christopherferreira9 christopherferreira9 requested review from a team as code owners March 30, 2026 17:13
@github-actions

github-actions Bot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Mar 30, 2026
@github-actions github-actions Bot added size-M risk-high Extensive testing required · High bug introduction risk labels Mar 30, 2026
@github-actions

github-actions Bot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeCard, SmokePerps, SmokeRamps, SmokeMultiChainAPI, SmokePredictions, FlaskBuildTests
  • Selected Performance tags: @PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps
  • Risk Level: high
  • AI Confidence: 100%
click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/transaction-pay-controller. Running all tests.

Performance Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/transaction-pay-controller. Running all tests.

View GitHub Actions results

@socket-security

socket-security Bot commented Mar 30, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​assets-controller@​3.2.1 ⏵ 3.0.070 +11008096100
Updatednpm/​@​metamask/​base-controller@​9.0.1 ⏵ 9.0.01001007388 -5100
Updatednpm/​@​metamask/​address-book-controller@​7.1.1 ⏵ 7.1.01001007392 -1100
Updatednpm/​@​metamask/​preferences-controller@​23.1.0 ⏵ 23.0.0100 +11007595 -1100
Updatednpm/​@​metamask/​approval-controller@​9.0.1 ⏵ 9.0.01001007691 -1100
Updatednpm/​@​metamask/​remote-feature-flag-controller@​4.2.0 ⏵ 4.1.099 +11007693100
Updatednpm/​@​metamask/​gas-fee-controller@​26.1.1 ⏵ 26.1.0991007692100
Updatednpm/​@​metamask/​multichain-network-controller@​3.0.6 ⏵ 3.0.5981007698 +1100
Updatednpm/​@​metamask/​snaps-rpc-methods@​15.0.1 ⏵ 15.0.098 +11007696 +250
Updatednpm/​@​metamask/​keyring-controller@​25.1.1 ⏵ 25.1.09810078 +195 +1100
Updatednpm/​@​metamask/​ramps-controller@​12.1.0 ⏵ 12.0.196 +11007898100
Updatednpm/​@​metamask/​bridge-controller@​69.2.3 ⏵ 69.1.1961007999100
Updatednpm/​@​metamask/​permission-controller@​12.3.0 ⏵ 12.2.199 +11007992 -1100
Updatednpm/​@​metamask/​eth-json-rpc-middleware@​23.1.1 ⏵ 23.1.098 +11008096 +5100
Updatednpm/​@​metamask/​transaction-pay-controller@​19.0.0 ⏵ 17.1.098 +11008099100
Addednpm/​@​metamask/​transaction-controller@​63.3.0951008199100
Updatednpm/​@​metamask/​profile-sync-controller@​28.0.2 ⏵ 28.0.0971008796 -1100
Updatednpm/​@​metamask/​storage-service@​1.0.1 ⏵ 1.0.0100 +110010090 -1100
Updatednpm/​@​metamask/​json-rpc-engine@​10.2.4 ⏵ 10.2.39910010092 -2100
Updatednpm/​@​metamask/​network-controller@​30.0.1 ⏵ 30.0.0100 +5100100 +23100 +5100

View full report

@christopherferreira9 christopherferreira9 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Mar 30, 2026
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 30, 2026
@christopherferreira9 christopherferreira9 changed the title Revert "feat(perps): add Perps Withdraw confirmation flow and post-quote config" revert(perps): add Perps Withdraw confirmation flow and post-quote config Mar 30, 2026
@sonarqubecloud

sonarqubecloud Bot commented Mar 30, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
63.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

✅ E2E Fixture Validation — Schema is up to date
18 value mismatches detected (expected — fixture represents an existing user).
View details

@christopherferreira9 christopherferreira9 added this pull request to the merge queue Mar 30, 2026
Merged via the queue into main with commit e52b1aa Mar 30, 2026
227 of 238 checks passed
@christopherferreira9 christopherferreira9 deleted the revert-28046-perps-withdraw-confirmation branch March 30, 2026 18:48
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 30, 2026
@metamaskbot metamaskbot added the release-7.73.0 Issue or pull request that will be included in release 7.73.0 label Mar 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ccharly ccharly ccharly approved these changes

@NicolasMassart NicolasMassart NicolasMassart approved these changes

@dan437 dan437 dan437 approved these changes

+1 more reviewer

@pkowalski pkowalski pkowalski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.73.0 Issue or pull request that will be included in release 7.73.0 risk-high Extensive testing required · High bug introduction risk size-M team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@christopherferreira9 @ccharly @NicolasMassart @pkowalski @dan437 @metamaskbot