fix: backfill-consent-event cp-7.73.0 by ieow · Pull Request #28080 · MetaMask/metamask-mobile

ieow · 2026-03-30T07:20:38Z

Description

Social login (Google / Apple) users who completed onboarding before the
ANALYTICS_PREFERENCE_SELECTED event was emitted on the marketing-consent
screen never had that event fired for them. This PR introduces a one-time
post-rehydration backfill so those users are counted correctly in analytics.

How it works (three-step design kept intentionally pure):

Migration 131 – runs at startup before the Redux store is live. If the
persisted state contains a SeedlessOnboardingController.authConnection
value, it writes a
marker into onboarding.seedless.pendingSocialLoginMarketingConsentBackfill.
The migration never fires analytics itself; it only stamps the persisted
state so the side effect can be done safely after rehydration.
Redux slice – a new SET_PENDING_SOCIAL_LOGIN_MARKETING_CONSENT_BACKFILL
action/reducer/selector manages the marker in state.onboarding.seedless.
Saga – backfillSocialLoginMarketingConsent runs once inside
startAppServices (after setAppServicesReady). It reads the marker from
the live store, fires ANALYTICS_PREFERENCE_SELECTED with
saveDataRecording: true, calls updateDataRecordingFlag, and clears the
marker. If the marketing consent is no longer enabled at run time (e.g. user
toggled it off between migrations) the marker is cleared without sending any
analytics. If trackEvent throws, the marker is left in place so a future
run can retry.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: One-time marketing consent analytics backfill for social login users

  Background:
    Given I have a device with a previously installed version of MetaMask Mobile
    And I am a social login (Google or Apple) user
    And I previously accepted marketing data collection during onboarding

  Scenario: backfill event fires once on first launch after upgrade
    Given the app has not yet run migration 129
    And state.security.dataCollectionForMarketing is true
    And state.engine.backgroundState.SeedlessOnboardingController.authConnection is "google"

    When user launches the app and the store rehydrates
    Then migration 129 sets onboarding.seedless.pendingSocialLoginMarketingConsentBackfill to "google"
    And the backfill saga fires an ANALYTICS_PREFERENCE_SELECTED event with has_marketing_consent true
    And the pending marker is cleared to null
    And on subsequent app launches no duplicate event is fired

  Scenario: backfill is skipped when user has opted out of marketing consent
    Given state.security.dataCollectionForMarketing is false
    And state.engine.backgroundState.SeedlessOnboardingController.authConnection is "google"

    When user launches the app and the store rehydrates
    Then migration 129 does NOT set the pending marker
    And no ANALYTICS_PREFERENCE_SELECTED event is fired

  Scenario: stale marker is cleared without analytics when consent is revoked before launch
    Given the pending marker was set in a previous session (e.g. "google")
    And the user has since revoked marketing consent (dataCollectionForMarketing is false)

    When the app launches and the saga runs
    Then the pending marker is cleared to null
    And no ANALYTICS_PREFERENCE_SELECTED event is fired

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Adds a new persisted onboarding marker, a state migration, and a login-triggered saga that sends analytics/updates consent flags; mistakes could cause missed or duplicate analytics and unexpected consent state changes after rehydration.

Overview
Adds a one-time post-rehydration analytics backfill for legacy social login (Google/Apple) users who never emitted ANALYTICS_PREFERENCE_SELECTED for marketing consent.

This introduces a new onboarding state marker (pendingSocialLoginMarketingConsentBackfill) with action/reducer/selector support, sets it via new migration 131 based on SeedlessOnboardingController.authConnection, and runs a new backfillSocialLoginMarketingConsentSaga after LOGIN to optionally query OAuth marketing opt-in, emit the analytics identify/event (with saveDataRecording: true), update recording via updateDataRecordingFlag, then clear the marker and sync setDataCollectionForMarketing.

Wallet deletion now also clears the marker, and tests were added/updated across onboarding reducer/selectors, migrations, and sagas.

^{Reviewed by Cursor Bugbot for commit 2a0bacd. Bugbot is set up for automated code reviews on this repo. Configure here.}

github-actions · 2026-03-30T07:20:48Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

There are 3 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit e1c2f11. Configure here.}

Cal-L

Lgtm

github-actions · 2026-04-07T23:18:54Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeWalletPlatform, SmokeAccounts, SmokeIdentity
Selected Performance tags: None (no tests recommended)
Risk Level: medium
AI Confidence: 78%

click to see 🤖 AI reasoning details

E2E Test Selection:

The PR introduces a one-time analytics backfill mechanism for social login (seedless onboarding) users. Key changes:

Store migration 131: Runs on every app startup and marks existing social login users with a pendingSocialLoginMarketingConsentBackfill marker in the onboarding Redux state. This migration is safe but touches the persisted state that all E2E tests rely on.
New Redux action/reducer/selector: Adds pendingSocialLoginMarketingConsentBackfill to the onboarding state. The initialOnboardingState is updated, which affects all tests that initialize with default state.
New saga (backfillSocialLoginMarketingConsentSaga): Hooks into UserActionType.LOGIN and fires an analytics event for social login users. This runs after every login in the app, potentially affecting login flow timing.
Authentication.ts: The deleteWallet flow now dispatches setPendingSocialLoginMarketingConsentBackfill(null) to clear the marker. This affects wallet deletion/reset flows tested in E2E.

Tag Selection Rationale:

SmokeWalletPlatform: Covers wallet lifecycle analytics (wallet creation, SRP import events), which is directly related to the analytics backfill being added. Also covers the login flow where the saga fires.
SmokeAccounts: Covers SRP export flows, account management, and wallet deletion flows that are affected by the Authentication.ts change (clearing the backfill marker on wallet delete).
SmokeIdentity: The changes touch seedless onboarding (social login) state and sync features. SmokeIdentity covers account syncing and multi-SRP flows that interact with the onboarding state. Per tag descriptions, when changes touch multi-SRP architecture or account sync, SmokeIdentity should be selected alongside SmokeAccounts and SmokeWalletPlatform.

The changes are primarily analytics/tracking infrastructure and don't affect core wallet functionality like transactions, swaps, or network management, so other tags are not warranted.

Performance Test Selection:
The changes are analytics backfill infrastructure (a one-time saga that fires after login for social login users). While the saga adds a small async operation post-login, it's a one-time backfill that won't affect regular users or repeated login performance. The migration is lightweight (only reads and writes a string marker). No significant performance impact is expected on account lists, onboarding flows, login times, or other measured performance metrics.

View GitHub Actions results

sonarqubecloud · 2026-04-07T23:36:48Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-04-07T23:38:30Z

✅ E2E Fixture Validation — Schema is up to date
15 value mismatches detected (expected — fixture represents an existing user).
View details

tylerc-consensys

lgtm

ieow added 3 commits March 30, 2026 14:32

fix: backfill consent event

f5e49e0

fix: saga test invocation

b0a252b

fix: update to use selector

cef1d6e

metamaskbot added the team-onboarding Onboarding team label Mar 30, 2026

github-actions Bot added the size-L label Mar 30, 2026

cursor Bot reviewed Mar 30, 2026

View reviewed changes

Comment thread app/store/migrations/129.ts Outdated

Comment thread app/reducers/onboarding/index.test.ts

fix: typing

996d104

cursor Bot reviewed Mar 30, 2026

View reviewed changes

Comment thread app/store/migrations/129.ts Outdated

ieow added 2 commits March 30, 2026 16:01

fix: remove not needed call

a2db843

fix: migration bug

288acc4

cursor Bot reviewed Mar 31, 2026

View reviewed changes

Comment thread app/store/sagas/backfillSocialLoginMarketingConsent.ts

fix: update event location properties and update tests

e587992

ieow changed the title ~~Cw/backfill-consent-event~~ fix: backfill-consent-event Mar 31, 2026

fix: update cursor comment

aa6ff94

cursor Bot reviewed Mar 31, 2026

View reviewed changes

Comment thread app/store/sagas/backfillSocialLoginMarketingConsent.ts Outdated

fix: update account type

f19adb7

ieow marked this pull request as ready for review March 31, 2026 09:35

ieow requested review from a team as code owners March 31, 2026 09:35

fix: updated_after_onboarding update

0e9fc9d

github-actions Bot added the risk-medium Moderate testing recommended · Possible bug introduction risk label Mar 31, 2026

ieow added 2 commits April 1, 2026 18:58

fix: move to migration 130

8d64256

Merge branch 'main' into cw/backfill-consent-event

31e95fe

github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Apr 1, 2026

cursor Bot reviewed Apr 1, 2026

View reviewed changes

Comment thread app/store/migrations/130.ts Outdated

fix: migration 130

16e6960

github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Apr 1, 2026

github-actions Bot added the risk-medium Moderate testing recommended · Possible bug introduction risk label Apr 7, 2026

cursor Bot reviewed Apr 7, 2026

View reviewed changes

Comment thread app/store/sagas/backfillSocialLoginMarketingConsent.ts

Comment thread app/store/migrations/131.ts

ieow added this to PR review queue Apr 7, 2026

github-project-automation Bot moved this to Needs dev review in PR review queue Apr 7, 2026

fix: call saga function

e68cb7c

github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Apr 7, 2026

Cal-L approved these changes Apr 7, 2026

View reviewed changes

Merge branch 'main' into cw/backfill-consent-event

b23f3cc

github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Apr 7, 2026

Merge branch 'main' into cw/backfill-consent-event

2a0bacd

github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Apr 7, 2026

ieow changed the title ~~fix: backfill-consent-event~~ fix: backfill-consent-event cp-7.73.0 Apr 7, 2026

ieow enabled auto-merge April 8, 2026 00:43

ieow self-assigned this Apr 8, 2026

tylerc-consensys approved these changes Apr 8, 2026

View reviewed changes

ieow added this pull request to the merge queue Apr 8, 2026

github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Apr 8, 2026

Merged via the queue into main with commit 505770f Apr 8, 2026
120 checks passed

ieow deleted the cw/backfill-consent-event branch April 8, 2026 03:17

github-actions Bot locked and limited conversation to collaborators Apr 8, 2026

metamaskbot added the release-7.78.0 label Apr 8, 2026

weitingsun added release-7.74.0 Issue or pull request that will be included in release 7.74.0 and removed release-7.78.0 labels Apr 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: backfill-consent-event cp-7.73.0#28080

fix: backfill-consent-event cp-7.73.0#28080
ieow merged 27 commits into
mainfrom
cw/backfill-consent-event

ieow commented Mar 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 30, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Cal-L left a comment

Uh oh!

github-actions Bot commented Apr 7, 2026

Uh oh!

sonarqubecloud Bot commented Apr 7, 2026

Uh oh!

github-actions Bot commented Apr 7, 2026

Uh oh!

tylerc-consensys left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

ieow commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Mar 30, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Cal-L left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 7, 2026

🔍 Smart E2E Test Selection

Uh oh!

sonarqubecloud Bot commented Apr 7, 2026

Quality Gate passed

Uh oh!

github-actions Bot commented Apr 7, 2026

Uh oh!

tylerc-consensys left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ieow commented Mar 30, 2026 •

edited

Loading