Skip to content

refactor: remove BIP-44 internal logic#28061

Merged
gantunesr merged 2 commits into
mainfrom
gar/refactor/remove-bip44-flag
Mar 30, 2026
Merged

refactor: remove BIP-44 internal logic#28061
gantunesr merged 2 commits into
mainfrom
gar/refactor/remove-bip44-flag

Conversation

@gantunesr

@gantunesr gantunesr commented Mar 27, 2026

Copy link
Copy Markdown
Member

Description

Remove BIP-44 remote feature flag internal logic

Changelog

CHANGELOG entry: null

Related issues

Fixes: None

Manual testing steps

Not applicable

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Removes remote/version-gated feature-flag checks and forces multichain accounts state 2 on, which could unintentionally enable behavior for all users/environments and bypass rollout safeguards.

Overview
Multichain accounts feature-flag gating has been removed. isMultichainAccountsRemoteFeatureEnabled, isMultichainAccountsState2Enabled, and selectMultichainAccountsState2Enabled now unconditionally return true, eliminating remote flag, app-version, and local override logic.

Tests were simplified to assert the new always-enabled behavior, and related constants/type-guards/helpers were deleted.

Written by Cursor Bugbot for commit c5bda50. This will update automatically on new commits. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

@gantunesr gantunesr marked this pull request as ready for review March 30, 2026 11:54
@gantunesr gantunesr requested a review from a team as a code owner March 30, 2026 11:54

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment thread app/multichain-accounts/remote-feature-flag.ts
@gantunesr gantunesr added this pull request to the merge queue Mar 30, 2026
Merged via the queue into main with commit 8f72a1b Mar 30, 2026
117 of 119 checks passed
@gantunesr gantunesr deleted the gar/refactor/remove-bip44-flag branch March 30, 2026 13:09
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 30, 2026
@metamaskbot metamaskbot added the release-7.73.0 Issue or pull request that will be included in release 7.73.0 label Mar 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.73.0 Issue or pull request that will be included in release 7.73.0 size-M team-accounts-framework Accounts team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants