chore: adds the initial setup for leaderboard feature by zone-live · Pull Request #28053 · MetaMask/metamask-mobile

zone-live · 2026-03-27T15:30:00Z

Description

Adds the remote flag aiSocialLeaderboardEnabled and selector. When enabled, the homepage shows a Top Traders section (header + empty horizontal carousel placeholder) and registers the Top Traders as a stack screen with back/search and placeholder "Top traders". No leaderboard data or API yet this, is just the initial setup for the feature.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: changes are additive, feature-flag gated, and primarily UI/navigation scaffolding with tests and strings; no data fetching or critical flows are modified.

Overview
Adds initial Social Leaderboard scaffolding behind a remote flag. Introduces a version-gated aiSocialLeaderboardEnabled selector and registry entry, and conditionally registers a new Routes.SOCIAL_LEADERBOARD.VIEW stack screen (TopTradersView).

Homepage gains a new flag-controlled section. Adds TopTradersSection (header + empty horizontal carousel placeholder), includes it in homepage section ordering/refresh and analytics section naming, and updates tests/localization to cover the new route, flag behavior, and section index/total calculations.

^{Written by Cursor Bugbot for commit 5e5c1da. This will update automatically on new commits. Configure here.}

github-actions · 2026-03-27T15:30:10Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2026-03-30T15:19:02Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeWalletPlatform, SmokePerps, SmokePredictions
Selected Performance tags: None (no tests recommended)
Risk Level: medium
AI Confidence: 82%

click to see 🤖 AI reasoning details

E2E Test Selection:
The PR introduces a new "Social Leaderboard / Top Traders" feature with the following changes:

Homepage.tsx: New TopTradersSection added to the homepage sections list between Tokens and Perps sections. This modifies the section ordering and the getSectionIndex logic used by all homepage sections.
MainNavigator.js: New TopTradersView route added conditionally (only when isSocialLeaderboardEnabled is true). This is a critical navigation file that affects all navigation flows.
useHomeViewedEvent.ts: New TOP_TRADERS section name added to HomeSectionNames enum - this affects analytics tracking for all homepage sections.
Routes.ts: New SOCIAL_LEADERBOARD route constants added (additive only).
Feature flag: aiSocialLeaderboardEnabled is disabled by default (inProd: false, enabled: false), so the new UI won't appear in tests unless explicitly enabled.

Why SmokeWalletPlatform: This tag directly covers the Trending discovery tab and homepage sections. The Homepage.tsx changes (section ordering, section index calculation) and the HomeSectionNames enum change could affect how existing sections (Perps, Predictions, Tokens) are tracked and displayed. The MainNavigator change also affects navigation infrastructure used by Trending tests.

Why SmokePerps: Perps is a section inside the Trending tab. The homepage section ordering change (new TOP_TRADERS section inserted between TOKENS and PERPS) could affect getSectionIndex for Perps, potentially impacting analytics or rendering order. Per tag description: "changes to Perps views (headers, lists, full views) affect Trending. When selecting SmokePerps, also select SmokeWalletPlatform."

Why SmokePredictions: Similarly, Predictions is a section inside the Trending tab. The section index changes could affect Predictions section tracking. Per tag description: "Predictions is also a section inside the Trending tab (SmokeWalletPlatform); changes to Predictions views affect Trending."

The feature is disabled by default so risk to existing tests is low-medium. No SmokeConfirmations needed as this is a UI scaffold with no transaction flows yet.

Performance Test Selection:
No performance tests needed. The new TopTradersSection is a UI scaffold with an empty ScrollView (no data loading), the feature is disabled by default, and there are no changes to data fetching, state management, or rendering-heavy components that would impact performance metrics.

View GitHub Actions results

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

Bigshmow

LGTM

github-actions · 2026-03-30T15:40:45Z

✅ E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

sonarqubecloud · 2026-03-30T15:42:58Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

chore: adds the initial setup for leaderboard

3731883

metamaskbot added the team-social-ai Social & AI team label Mar 27, 2026

github-actions Bot added size-M risk-medium Moderate testing recommended · Possible bug introduction risk labels Mar 27, 2026

cursor Bot reviewed Mar 27, 2026

View reviewed changes

Comment thread app/components/Views/SocialLeaderboard/TopTradersView/TopTradersView.test.tsx

Comment thread app/components/Views/SocialLeaderboard/TopTradersView/TopTradersView.test.tsx

Comment thread app/components/Views/SocialLeaderboard/TopTradersView/TopTradersView.tsx

chore: review points

56fe30f

github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Mar 27, 2026

chore: tests update

b315bbc

github-actions Bot added size-L risk-medium Moderate testing recommended · Possible bug introduction risk and removed size-M risk-medium Moderate testing recommended · Possible bug introduction risk labels Mar 27, 2026

chore: update

60c8de0

github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Mar 27, 2026

Merge branch 'main' into TSA-326-leaderboard-initial-setup

5e5c1da

github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Mar 30, 2026

cursor Bot reviewed Mar 30, 2026

View reviewed changes

Comment thread app/components/Views/SocialLeaderboard/TopTradersView/TopTradersView.test.tsx

Bigshmow approved these changes Mar 30, 2026

View reviewed changes

zone-live added this pull request to the merge queue Mar 30, 2026

Merged via the queue into main with commit 9ebed6c Mar 30, 2026
93 of 95 checks passed

zone-live deleted the TSA-326-leaderboard-initial-setup branch March 30, 2026 17:56

github-actions Bot locked and limited conversation to collaborators Mar 30, 2026

metamaskbot added the release-7.73.0 Issue or pull request that will be included in release 7.73.0 label Mar 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: adds the initial setup for leaderboard feature#28053

chore: adds the initial setup for leaderboard feature#28053
zone-live merged 5 commits into
mainfrom
TSA-326-leaderboard-initial-setup

zone-live commented Mar 27, 2026 •

edited by cursor Bot

Loading

Uh oh!

github-actions Bot commented Mar 27, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Mar 30, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Bigshmow left a comment

Uh oh!

github-actions Bot commented Mar 30, 2026

Uh oh!

sonarqubecloud Bot commented Mar 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

zone-live commented Mar 27, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Mar 27, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Mar 30, 2026

🔍 Smart E2E Test Selection

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Bigshmow left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 30, 2026

Uh oh!

sonarqubecloud Bot commented Mar 30, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zone-live commented Mar 27, 2026 •

edited by cursor Bot

Loading