feat: add marketing event for seedless users cp-7.72.0#28015
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - draft PR All E2E tests pre-selected. |
Contributor
|
✅ E2E Fixture Validation — Schema is up to date |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry: Improved analytics consistency during social login onboarding.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Adds new analytics tracking and user-trait updates in the OAuth onboarding success path, including an awaited call that could impact timing or failure behavior before navigation.
Overview
Adds explicit MetaMetrics instrumentation for seedless/social (OAuth) onboarding on the
ChoosePasswordsuccess path: emitsANALYTICS_PREFERENCE_SELECTEDwith marketing-consent +account_type(derived from the OAuthprovider) and updates the user profile viaaddTraitsToUserwith device/user settings metadata and configured chain IDs.Updates
ChoosePasswordtests to mock the expanded analytics API (identify,addTraitsToUser, event builder output), passproviderin OAuth route params, and assert the new tracking/trait calls occur when completing OAuth wallet creation.Written by Cursor Bugbot for commit 24d270a. Configure here.