Skip to content

test: update predict and confirmations components with proper testIDS#28011

Merged
cortisiko merged 2 commits into
mainfrom
Curtis-expand-testIDs-for-confirmations-predictions
Mar 27, 2026
Merged

test: update predict and confirmations components with proper testIDS#28011
cortisiko merged 2 commits into
mainfrom
Curtis-expand-testIDs-for-confirmations-predictions

Conversation

@cortisiko

@cortisiko cortisiko commented Mar 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Updates Predict Market Details tab testIDs to be stable and semantic by switching from index-based IDs to typed tab-key IDs ('positions' | 'outcomes' | 'about'), and updates PredictMarketDetailsTabBar plus its unit tests to use the new getPredictMarketDetailsSelector.tabBarTab(tabKey) API.

Adds explicit testIDs to the confirmations NetworkFilter tabs by introducing network-filter.testIds.ts and passing a required testID prop into NetworkFilterTab for the “All networks” option and each per-chain tab.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: changes are limited to test ID generation and wiring for UI elements, with no business logic or data flow modifications.

Overview
Updates Predict Market Details tab testIDs to be stable and semantic by switching from index-based IDs to typed tab-key IDs ('positions' | 'outcomes' | 'about'), and updates PredictMarketDetailsTabBar plus its unit tests to use the new getPredictMarketDetailsSelector.tabBarTab(tabKey) API.

Adds explicit testIDs to the confirmations NetworkFilter tabs by introducing network-filter.testIds.ts and passing a required testID prop into NetworkFilterTab for the “All networks” option and each per-chain tab.

Written by Cursor Bugbot for commit bea4356. This will update automatically on new commits. Configure here.

@cortisiko cortisiko requested review from a team as code owners March 27, 2026 04:30
@metamaskbot metamaskbot added the team-qa QA team label Mar 27, 2026
@github-actions github-actions Bot added size-S risk-low Low testing needed · Low bug introduction risk labels Mar 27, 2026
cursor[bot]
cursor Bot reviewed Mar 27, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment thread app/components/UI/Predict/Predict.testIds.ts
@cortisiko cortisiko added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Mar 27, 2026
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 27, 2026
@github-actions

github-actions Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePredictions, SmokeWalletPlatform, SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are focused on test ID infrastructure:

  1. Predict tab bar testID refactor (Predict.testIds.ts, PredictMarketDetailsTabBar.tsx, PredictMarketDetails.test.tsx): The getPredictMarketDetailsSelector.tabBarTab() function signature changed from numeric index to named string key ('positions', 'outcomes', 'about'). This changes the actual rendered testID values from predict-market-details-tab-bar-tab-0/1/2 to predict-market-details-tab-bar-tab-positions/outcomes/about. Any E2E tests using these selectors must be validated to ensure they use the updated IDs. This directly impacts SmokePredictions tests.

  2. Network filter testIDs added (network-filter.testIds.ts new file, network-filter.tsx updated): New testID props added to the NetworkFilterTab component in the confirmations flow. This enables E2E tests to target network filter tabs by chain ID. This directly impacts SmokeConfirmations tests.

Dependent tags per descriptions:

  • SmokePredictions → requires SmokeWalletPlatform (Trending section) and SmokeConfirmations (on-chain transactions)
  • SmokeConfirmations is already selected

No performance impact expected — these are purely test ID/selector changes with no logic or rendering changes.

Performance Test Selection:
These changes are purely test ID/selector additions and refactoring. No UI rendering logic, data loading, state management, or performance-sensitive code paths were modified. No performance tests are warranted.

View GitHub Actions results

@github-actions

github-actions Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

✅ E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

@cortisiko cortisiko enabled auto-merge March 27, 2026 05:47
@sonarqubecloud

sonarqubecloud Bot commented Mar 27, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

caieu
caieu approved these changes Mar 27, 2026
View reviewed changes

@caieu caieu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko added this pull request to the merge queue Mar 27, 2026
Merged via the queue into main with commit 3e308f8 Mar 27, 2026
104 checks passed
@cortisiko cortisiko deleted the Curtis-expand-testIDs-for-confirmations-predictions branch March 27, 2026 11:43
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2026
@metamaskbot metamaskbot added the release-7.73.0 Issue or pull request that will be included in release 7.73.0 label Mar 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@caieu caieu caieu approved these changes

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.73.0 Issue or pull request that will be included in release 7.73.0 risk-low Low testing needed · Low bug introduction risk size-S team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cortisiko @caieu @pedronfigueiredo @metamaskbot