fix(predict): invalidate EthQuery cache before Claim/Withdraw Safe TX signing#28001
Merged
Conversation
… signing Adds invalidateQueryCache calls before prepareClaim and signWithdraw to prevent GS026/GS013 errors caused by stale nonces from EthQuery's 15-minute query cache.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - draft PR All E2E tests pre-selected. |
Contributor
|
✅ E2E Fixture Validation — Schema is up to date |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
~2% of Claim/Withdraw transactions are failing with Safe GS026 or GS013 errors. Root cause:
EthQuerycaches query results for up to 15 minutes, which can serve a stale nonce when signing Safe transactions. This fix callsinvalidateQueryCachebeforeprepareClaimandsignWithdrawso the Safe TX is always signed with a fresh nonce.Changelog
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/PRED-769
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches Predict claim/withdraw signing flow; while the change is small, it alters pre-sign network behavior and could impact transaction submission timing or error handling.
Overview
Prevents stale Safe nonces during Predict Claim and Withdraw by invalidating the underlying
EthQuerycache immediately beforeprepareClaimandsignWithdrawrun.This adds an
invalidateQueryCachecall (viablockTracker.checkForLatestBlock()) to force fresh chain state before signing, reducing intermittent SafeGS026/GS013failures.Written by Cursor Bugbot for commit 2144104. This will update automatically on new commits. Configure here.