chore: show entries closed toast when passed cutoff date by sophieqgu · Pull Request #28000 · MetaMask/metamask-mobile

sophieqgu · 2026-03-26T21:04:09Z

Description

https://consensyssoftware.atlassian.net/browse/RWDS-1109

Changelog

CHANGELOG entry: prevent ondo campaign opt in based on cut off date

Screenshots/Recordings

Note

Medium Risk
Changes opt-in eligibility and leaderboard rendering based on a new depositCutoffDate, which can affect user ability to join campaigns and what data is fetched/rendered. Risk is moderate due to time-based logic and UI state/loading interactions, but scoped to Rewards campaign details.

Overview
Adds depositCutoffDate support for ONDO_HOLDING campaigns and introduces isOptinAllowed to centralize the time-based opt-in gating.

Updates OndoCampaignDetailsView and CampaignJoinCTA to hide the join CTA once entries close, show a new dismissible CampaignEntriesClosedBanner, and treat active-but-closed campaigns similar to completed campaigns for leaderboard fetching/rendering (with a skeleton while participant status loads).

Extends types and i18n strings for the new cutoff field and banner text, and adds/updates unit tests to cover cutoff, banner visibility, and loading behaviors.

^{Written by Cursor Bugbot for commit 94596b3. This will update automatically on new commits. Configure here.}

github-actions · 2026-03-26T21:04:20Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

https://consensyssoftware.atlassian.net/browse/RWDS-1109 ## Changelog ### Added - `CampaignEntriesClosedBanner` component shown when deposit cutoff date has passed - Entries-closed toast notification via `useRewardsToast` ### Changed - `CampaignJoinCTA` hides the join button when opt-in is no longer allowed past cutoff date - `useGetCampaignParticipantStatus` reflects cutoff-date awareness - `OndoCampaignDetailsView` renders the entries-closed banner and leaderboard for campaigns past cutoff ## Screenshots  Co-authored-by: VGR-GIT <vangulckrik@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

…larity The variable canOptIn was true when opt-in was NOT allowed (entries closed), making its name the exact opposite of its value. Renamed to areEntriesClosed to match the actual semantics. Also fixes a latent bug in leaderboardCampaignId: the original !canOptIn evaluated to true when entries were still open, contradicting the documented intent of enabling the leaderboard for "active campaign past cutoff date". The fix uses areEntriesClosed directly so the leaderboard fetches correctly when entries are closed. Co-authored-by: VGR-GIT <vangulckrik@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Show CampaignHowItWorks when entries are still open (!areEntriesClosed), not after they close. Fix the inverted condition in OndoCampaignDetailsView and update the two affected test cases to match the correct behaviour. Co-authored-by: VGR-GIT <vangulckrik@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

github-actions · 2026-03-27T11:06:56Z

🔍 Smart E2E Test Selection

Selected E2E tags: None (no tests recommended)
Selected Performance tags: None (no tests recommended)
Risk Level: low
AI Confidence: 90%

click to see 🤖 AI reasoning details

E2E Test Selection:
All changes are confined to the Rewards feature area (Ondo campaign details view, campaign utility functions, a new banner component, and a hook fix). Specifically:

types.ts: Purely additive — adds optional depositCutoffDate field to two interfaces. No breaking changes to the rewards controller or Engine.
CampaignTile.utils.ts: New isOptinAllowed() utility function — isolated to campaign logic.
OndoCampaignDetailsView.tsx: UI logic changes for "entries closed" state — affects only the Ondo campaign details screen.
CampaignEntriesClosedBanner.tsx: New dismissible banner component — purely additive.
CampaignJoinCTA.tsx: Minor logic update to hide CTA when opt-in is not allowed.
useGetCampaignParticipantStatus.ts: Fix for initial loading state initialization.
locales/en.json: Two new strings added — no existing strings modified.

No existing E2E tests cover the Rewards/Ondo campaign functionality (confirmed by searching e2e and tests directories). The changes do not touch any shared infrastructure: no TabBar, no navigation structure changes, no confirmation flows, no wallet core, no controllers with side effects. The rewards controller type change is non-breaking (optional field addition). No E2E tags are applicable or necessary for these changes.

Performance Test Selection:
No performance-sensitive changes. The modifications are limited to UI component logic (banner display, CTA visibility), a utility function, and a hook initialization fix. No list rendering changes, no state management overhaul, no startup/initialization impact, no data loading pipeline changes.

View GitHub Actions results

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

sonarqubecloud · 2026-03-27T11:32:52Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Show entries closed toast when passed cutoff date

b07677a

sophieqgu requested a review from a team as a code owner March 26, 2026 21:04

metamaskbot added the team-rewards Rewards team label Mar 26, 2026

sophieqgu changed the title ~~Show entries closed toast when passed cutoff date~~ chore: show entries closed toast when passed cutoff date Mar 26, 2026

github-actions Bot added size-L risk-low Low testing needed · Low bug introduction risk labels Mar 26, 2026

cursor Bot reviewed Mar 26, 2026

View reviewed changes

Comment thread app/components/UI/Rewards/hooks/useRewardsToast.tsx Outdated

Comment thread app/components/UI/Rewards/hooks/useRewardsToast.tsx Outdated

sophieqgu added 2 commits March 26, 2026 17:23

Fix bug

c589dce

Fix tests

c51f8eb

github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 26, 2026

cursor Bot reviewed Mar 26, 2026

View reviewed changes

Comment thread app/components/UI/Rewards/hooks/useRewardsToast.tsx Outdated

Comment thread app/components/UI/Rewards/hooks/useRewardsToast.tsx Outdated

Comment thread app/components/UI/Rewards/components/Campaigns/CampaignJoinCTA.test.tsx Outdated

Fix tests

711379a

github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 26, 2026

github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 27, 2026

cursor Bot reviewed Mar 27, 2026

View reviewed changes

Comment thread app/components/UI/Rewards/Views/OndoCampaignDetailsView.tsx

github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 27, 2026

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 27, 2026

github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 27, 2026

cursor Bot reviewed Mar 27, 2026

View reviewed changes

Comment thread app/components/UI/Rewards/Views/OndoCampaignDetailsView.tsx

VGR-GIT enabled auto-merge March 27, 2026 11:19

EugeniyBykov approved these changes Mar 27, 2026

View reviewed changes

VGR-GIT added this pull request to the merge queue Mar 27, 2026

Merged via the queue into main with commit 98aae07 Mar 27, 2026
70 checks passed

VGR-GIT deleted the Enforce-deposit-cutoff-date branch March 27, 2026 11:54

github-actions Bot locked and limited conversation to collaborators Mar 27, 2026

metamaskbot added the release-7.73.0 Issue or pull request that will be included in release 7.73.0 label Mar 27, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: show entries closed toast when passed cutoff date#28000

chore: show entries closed toast when passed cutoff date#28000
VGR-GIT merged 7 commits into
mainfrom
Enforce-deposit-cutoff-date

sophieqgu commented Mar 26, 2026 •

edited by VGR-GIT

Loading

Uh oh!

github-actions Bot commented Mar 26, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Mar 27, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

sonarqubecloud Bot commented Mar 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

sophieqgu commented Mar 26, 2026 • edited by VGR-GIT Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Screenshots/Recordings

Uh oh!

github-actions Bot commented Mar 26, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Mar 27, 2026

🔍 Smart E2E Test Selection

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud Bot commented Mar 27, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sophieqgu commented Mar 26, 2026 •

edited by VGR-GIT

Loading