Skip to content

refactor(analytics): C3-b migrate TabBar analytics from useMetrics to useAnalytics#27983

Merged
NicolasMassart merged 1 commit into
mainfrom
refactor/26686_c3_component-library-tabbar
Mar 27, 2026
Merged

refactor(analytics): C3-b migrate TabBar analytics from useMetrics to useAnalytics#27983
NicolasMassart merged 1 commit into
mainfrom
refactor/26686_c3_component-library-tabbar

Conversation

@NicolasMassart

@NicolasMassart NicolasMassart commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

Description

Replaces the deprecated useMetrics hook with the new useAnalytics hook in TabBar.tsx.

This is part of the broader C3 analytics migration (#26686) that standardises all analytics calls across the mobile app to use the new useAnalytics abstraction instead of useMetrics. The hook interface is identical (trackEvent, createEventBuilder), so no behaviour changes.

Changelog

CHANGELOG entry: null

Related issues

Refs: #26814

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk refactor that swaps a deprecated analytics hook for its replacement while keeping the same trackEvent/createEventBuilder interface; main risk is accidental import/path or hook wiring issues affecting event emission.

Overview
Updates TabBar.tsx to use the new useAnalytics hook instead of the deprecated useMetrics, leaving the existing trackEvent/createEventBuilder usage intact (e.g., for the wallet actions button click event).

Written by Cursor Bugbot for commit c31f62f. This will update automatically on new commits. Configure here.

@NicolasMassart NicolasMassart self-assigned this Mar 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Mar 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@NicolasMassart NicolasMassart changed the title refactor: migrate TabBar analytics from useMetrics to useAnalytics refactor(analytics): C3b migrate TabBar analytics from useMetrics to useAnalytics Mar 26, 2026
@NicolasMassart NicolasMassart changed the title refactor(analytics): C3b migrate TabBar analytics from useMetrics to useAnalytics refactor(analytics): C3-b migrate TabBar analytics from useMetrics to useAnalytics Mar 26, 2026
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Mar 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

@sonarqubecloud

Copy link
Copy Markdown

@NicolasMassart NicolasMassart marked this pull request as ready for review March 27, 2026 10:44
@NicolasMassart NicolasMassart requested a review from a team as a code owner March 27, 2026 10:44

@georgewrmarshall georgewrmarshall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NicolasMassart NicolasMassart added this pull request to the merge queue Mar 27, 2026
@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Mar 27, 2026
Merged via the queue into main with commit 34a7b88 Mar 27, 2026
142 checks passed
@NicolasMassart NicolasMassart deleted the refactor/26686_c3_component-library-tabbar branch March 27, 2026 18:04
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Mar 27, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2026
@metamaskbot metamaskbot added the release-7.73.0 Issue or pull request that will be included in release 7.73.0 label Mar 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.73.0 Issue or pull request that will be included in release 7.73.0 size-XS team-mobile-platform Mobile Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants