Skip to content

fix: fix charting url#27972

Merged
sahar-fehri merged 2 commits into
mainfrom
fix/fix-charting-url
Mar 26, 2026
Merged

fix: fix charting url#27972
sahar-fehri merged 2 commits into
mainfrom
fix/fix-charting-url

Conversation

@sahar-fehri

@sahar-fehri sahar-fehri commented Mar 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Update chart URL

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk config-only change, but it affects where the in-app advanced charts load their static assets, so a bad URL would break chart rendering across builds.

Overview
Updates MM_CHARTING_LIBRARY_URL in builds.yml to point to the new hosted TradingView Advanced Charts asset location (charting-assets.static.metamask.io/.../v30.1.0/) instead of the previous S3 URL.

Written by Cursor Bugbot for commit 31b605a. This will update automatically on new commits. Configure here.

@sahar-fehri sahar-fehri requested a review from a team as a code owner March 26, 2026 13:23
@github-actions

github-actions Bot commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added size-XS risk-low Low testing needed · Low bug introduction risk labels Mar 26, 2026
cursor[bot]
cursor Bot reviewed Mar 26, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment thread builds.yml Outdated
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 26, 2026
@github-actions

github-actions Bot commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePerps, SmokeWalletPlatform, SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The only change in this PR is updating the MM_CHARTING_LIBRARY_URL environment variable in builds.yml from an S3 bucket URL (https://va-mmcx-terminal.s3.us-east-2.amazonaws.com/charting_library/) to a versioned CDN URL (https://charting-assets.static.metamask.io/tradingview/advanced-charts/v30.1.0/). This URL is consumed by app/components/UI/Charts/AdvancedChart/AdvancedChartTemplate.ts which powers the TradingView advanced charting library used in the Perps trading feature. The change is a pure configuration/infrastructure update with no app logic changes. The primary risk is that the new CDN URL could be unreachable or serve different/incompatible assets, breaking Perps chart rendering. SmokePerps is the directly impacted test suite. Per tag dependency rules: SmokePerps requires SmokeWalletPlatform (Perps is a section inside Trending) and SmokeConfirmations (Add Funds deposits are on-chain transactions).

Performance Test Selection:
This change only updates a CDN URL for the TradingView charting library in the build configuration. It does not affect UI rendering performance, data loading, state management, or any of the critical user flows measured by performance tests. No performance tests are warranted.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented Mar 26, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sahar-fehri sahar-fehri enabled auto-merge March 26, 2026 15:13
@sahar-fehri sahar-fehri added this pull request to the merge queue Mar 26, 2026
Merged via the queue into main with commit d0ed881 Mar 26, 2026
65 of 66 checks passed
@sahar-fehri sahar-fehri deleted the fix/fix-charting-url branch March 26, 2026 16:25
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 26, 2026
@metamaskbot metamaskbot added the release-7.72.0 Issue or pull request that will be included in release 7.72.0 label Mar 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@NicolasMassart NicolasMassart NicolasMassart approved these changes

@andrepimenta andrepimenta andrepimenta approved these changes

Assignees

No one assigned

Labels

release-7.72.0 Issue or pull request that will be included in release 7.72.0 risk-low Low testing needed · Low bug introduction risk size-XS team-assets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sahar-fehri @NicolasMassart @andrepimenta @metamaskbot