Skip to content

chore: add candlestick icon to component library#27961

Merged
brianacnguyen merged 2 commits into
mainfrom
update/candlestick-icon
Mar 27, 2026
Merged

chore: add candlestick icon to component library#27961
brianacnguyen merged 2 commits into
mainfrom
update/candlestick-icon

Conversation

@brianacnguyen

@brianacnguyen brianacnguyen commented Mar 26, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

This PR adds the candlestick icon to the component-library

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-656

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2026-03-25.at.23.20.12.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: adds a new SVG asset and wires it into the generated icon enum/mapping, with no changes to runtime logic beyond selecting an additional icon name.

Overview
Adds a new Candlestick icon to the component library by introducing assets/candlestick.svg, extending IconName with Candlestick, and wiring the new asset into assetByIconName.

Also includes minor import/mapping reordering in the generated icon asset/type files (e.g., Search, MetamaskFoxOutline) with no functional behavior change.

Written by Cursor Bugbot for commit 0cd4fb7. This will update automatically on new commits. Configure here.

@brianacnguyen brianacnguyen self-assigned this Mar 26, 2026
@brianacnguyen brianacnguyen requested a review from a team as a code owner March 26, 2026 06:23
@brianacnguyen brianacnguyen added No QA Needed Apply this label when your PR does not need any QA effort. team-design-system All issues relating to design system in Mobile no changelog required No changelog entry is required for this change labels Mar 26, 2026
@github-actions

github-actions Bot commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added size-S risk-low Low testing needed · Low bug introduction risk labels Mar 26, 2026
@github-actions github-actions Bot removed the risk-low Low testing needed · Low bug introduction risk label Mar 26, 2026
@github-actions

github-actions Bot commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePerps, SmokeWalletPlatform, SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
The PR adds a new Candlestick SVG icon to the component library icon system. Changes are:

  1. New candlestick.svg asset file
  2. IconName.Candlestick enum entry added to Icon.types.ts
  3. Import and asset mapping added to Icon.assets.ts
  4. Minor alphabetical reordering of existing entries (MetamaskFoxFilled/Outline, Search/SearchFilled) — safe since these are string-valued enums

The Candlestick icon is used in:

  • TradeWalletActions.tsx (Perps entry point in the trade menu)
  • WalletActions.tsx (wallet actions menu)
  • TrendingView/sections.config.tsx (Trending tab Perps section)
  • Rewards/eventDetailsUtils for Perps activity types

SmokePerps is selected because the icon is directly used in the Perps entry point. SmokeWalletPlatform is selected because the icon appears in WalletActions and TrendingView (Perps section inside Trending). SmokeConfirmations is required as a dependency when selecting SmokePerps (per tag description: 'When selecting SmokePerps, also select SmokeWalletPlatform and SmokeConfirmations').

No existing icons are modified — this is purely additive. Risk is low.

Performance Test Selection:
Adding a new static SVG icon to the icon library has no meaningful performance impact. No rendering loops, data fetching, or state management changes are involved. Performance tests are not warranted.

View GitHub Actions results

@github-actions github-actions Bot added the risk-low Low testing needed · Low bug introduction risk label Mar 26, 2026
@github-actions

github-actions Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

✅ E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

@brianacnguyen brianacnguyen enabled auto-merge March 27, 2026 00:11
@sonarqubecloud

sonarqubecloud Bot commented Mar 27, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@brianacnguyen brianacnguyen added this pull request to the merge queue Mar 27, 2026
Merged via the queue into main with commit 4de0801 Mar 27, 2026
100 checks passed
@brianacnguyen brianacnguyen deleted the update/candlestick-icon branch March 27, 2026 00:44
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2026
@metamaskbot metamaskbot added the release-7.73.0 Issue or pull request that will be included in release 7.73.0 label Mar 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels

no changelog required No changelog entry is required for this change No QA Needed Apply this label when your PR does not need any QA effort. release-7.73.0 Issue or pull request that will be included in release 7.73.0 risk-low Low testing needed · Low bug introduction risk size-S team-design-system All issues relating to design system in Mobile

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brianacnguyen @georgewrmarshall @metamaskbot