feat: Clean up Rewards pages and add metrics by Montoya · Pull Request #27952 · MetaMask/metamask-mobile

Montoya · 2026-03-25T22:06:13Z

Description

This PR hides a date field on campaign cards and makes a disclaimer smaller and more brief within the Rewards tab. It also adds metrics for mUSD buttons in the mUSD view.

Changelog

CHANGELOG entry: null

Related issues

Fixes: n/a

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Simulator Screenshot - iPhone 16e - 2026-03-25 at 18 05 28

Simulator Screenshot - iPhone 16e - 2026-03-25 at 18 05 24

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI/UX adjustments plus new analytics events for mUSD actions; main risk is minor layout/regression around campaign tiles and metrics event wiring.

Overview
Rewards campaign tiles: Removes the top "date" row content from CampaignTile (keeps the campaign-tile-date-label container as an empty placeholder) and updates the tile test to no longer assert specific date text.

mUSD calculator tab: Shortens and visually de-emphasizes the disclaimer (new rewards.musd.disclaimer_brief string, smaller text variant) and adds MetaMetrics tracking for the Buy and Swap buttons using REWARDS_PAGE_BUTTON_CLICKED with button_type values buy_musd/swap_to_musd (new RewardsMetricsButtons enum entries), with tests updated accordingly.

^{Written by Cursor Bugbot for commit 127a21b. This will update automatically on new commits. Configure here.}

This prevents the deeplink interstitial

It's mUSD for all

github-actions · 2026-03-25T22:06:24Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2026-03-25T22:55:23Z

✅ E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

cursor · 2026-03-26T01:24:36Z

-    expect(getByTestId('campaign-tile-date-label')).toHaveTextContent(
-      'Ends Mar 15, 2:30 PM',
-    );
+    expect(getByTestId('campaign-tile-date-label')).toBeDefined();


Weak toBeDefined() assertion replaces meaningful text check

Low Severity

The updated test uses toBeDefined() to assert element presence, which is a no-op since getByTestId throws if the element is not found — toBeDefined() can never fail here. The unit testing guidelines explicitly require toBeOnTheScreen() instead of toBeDefined() for element assertions, as toBeDefined() is a weak matcher that doesn't properly verify render state.

^{Triggered by project rule: Unit Testing Guidelines}

This is acceptable. The element is empty for now.

github-actions · 2026-03-26T02:13:30Z

🔍 Smart E2E Test Selection

Selected E2E tags: None (no tests recommended)
Selected Performance tags: None (no tests recommended)
Risk Level: low
AI Confidence: 92%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are entirely isolated to the Rewards UI component area with no existing E2E test coverage:

CampaignTile.tsx: Minor UI change - commented out date label icon and text from campaign tile header (cosmetic, no logic change)
MusdCalculatorTab.tsx: Added analytics tracking for "Buy mUSD" and "Swap to mUSD" buttons, and updated disclaimer text to a shorter version using a new localization key
utils.ts: Added two new enum values (BUY_MUSD, SWAP_TO_MUSD) to RewardsMetricsButtons - purely additive
en.json: Added a new localization string disclaimer_brief - additive, non-breaking
Test files: Unit test updates only

No E2E tests exist for the Rewards/Campaigns/mUSD features (confirmed by searching e2e/ directory). The changes don't touch any shared infrastructure, navigation, controllers, or components used by other E2E test flows. The analytics additions are purely additive. No performance-sensitive code paths are modified. Risk is low - these are isolated UI/analytics changes with no cross-cutting impact.

Performance Test Selection:
No performance-sensitive code paths are modified. Changes are limited to UI component rendering (removing a small UI element, adding analytics event calls) and localization strings. No list rendering, data loading, state management, or critical user flow performance is impacted.

View GitHub Actions results

sonarqubecloud · 2026-03-26T02:38:10Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Montoya added 7 commits March 25, 2026 15:52

Force default value for campaignParticipantStatuses

76a7ed1

Use swap navigation instead of deeplink

2e1f99f

This prevents the deeplink interstitial

Put disclaimer under buttons

92968f7

Page title for mUSD calculator is just mUSD

bd1ab98

Populate locales

a746935

It's mUSD for all

Make the disclaimer on the mUSD Calculator smaller

25c3711

Do not show date label

7095256

Merge branch 'main' into rewards-views-cleanup

48fa832

Montoya added size-XS team-rewards Rewards team release-7.72.0 Issue or pull request that will be included in release 7.72.0 labels Mar 25, 2026

github-actions Bot added size-S and removed size-XS labels Mar 25, 2026

Montoya marked this pull request as ready for review March 25, 2026 22:36

Montoya requested a review from a team as a code owner March 25, 2026 22:37

cursor Bot reviewed Mar 25, 2026

View reviewed changes

Comment thread app/components/UI/Rewards/components/Campaigns/CampaignTile.tsx

Merge branch 'main' into rewards-views-cleanup

466e3ad

github-actions Bot added the risk-low Low testing needed · Low bug introduction risk label Mar 25, 2026

cursor Bot reviewed Mar 25, 2026

View reviewed changes

Comment thread app/components/UI/Rewards/components/Campaigns/CampaignTile.tsx

Comment thread app/components/UI/Rewards/components/Tabs/MusdCalculatorTab/MusdCalculatorTab.tsx

Montoya added 3 commits March 25, 2026 21:19

Update campaign tile test to match empty content

596b8ed

Update test to match new string

5441ebd

Comment out unused variables

fa7cd9f

Montoya enabled auto-merge March 26, 2026 01:23

github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 26, 2026

cursor Bot reviewed Mar 26, 2026

View reviewed changes

Add tracking for mUSD buttons

127a21b

Montoya changed the title ~~feat: Rewards views cleanup~~ feat: Clean up Rewards pages and add metrics Mar 26, 2026

github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 26, 2026

VGR-GIT approved these changes Mar 26, 2026

View reviewed changes

Montoya added this pull request to the merge queue Mar 26, 2026

Merged via the queue into main with commit ec3d218 Mar 26, 2026
70 checks passed

Montoya deleted the rewards-views-cleanup branch March 26, 2026 09:10

github-actions Bot locked and limited conversation to collaborators Mar 26, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Clean up Rewards pages and add metrics#27952

feat: Clean up Rewards pages and add metrics#27952
Montoya merged 13 commits into
mainfrom
rewards-views-cleanup

Montoya commented Mar 25, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

cursor Bot Mar 26, 2026

Uh oh!

Montoya Mar 26, 2026

Uh oh!

github-actions Bot commented Mar 26, 2026

Uh oh!

sonarqubecloud Bot commented Mar 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Montoya commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Mar 26, 2026

Choose a reason for hiding this comment

Weak toBeDefined() assertion replaces meaningful text check

Uh oh!

Montoya Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 26, 2026

🔍 Smart E2E Test Selection

Uh oh!

sonarqubecloud Bot commented Mar 26, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Montoya commented Mar 25, 2026 •

edited

Loading

Weak `toBeDefined()` assertion replaces meaningful text check