refactor(analytics): C5 migrate to useAnalytics in PredictGTMModal#27923
Merged
Conversation
Migrates PredictGTMModal from useMetrics to useAnalytics hook. Part of the analytics cleanup workstream (#26686).
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - draft PR All E2E tests pre-selected. |
Contributor
|
✅ E2E Fixture Validation — Schema is up to date |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of the analytics C5 migration phase: replaces
useMetricswith the newuseAnalyticshook inPredictGTMModal.The
useMetricshook is being deprecated in favour ofuseAnalytics, which provides the sametrackEvent/createEventBuilderAPI through a unified interface. This commit updates the component and its unit test to use the new hook and thecreateMockUseAnalyticsHooktest helper.Changelog
CHANGELOG entry: null
Related issues
Fixes: #27883
Manual testing steps
N/A — pure internal refactor with no user-facing behaviour change. Existing unit tests cover the analytics event firing.
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk internal refactor that swaps the analytics hook used by
PredictGTMModal; behavior should be unchanged aside from potential wiring/mocking issues in event tracking.Overview
Updates
PredictGTMModalto use the newuseAnalyticshook instead ofuseMetricswhile keeping the sametrackEvent/createEventBuilderflow for the modal’s analytics events.Refactors
PredictGTMModal.test.tsxaccordingly by mockinguseAnalyticsand using the sharedcreateMockUseAnalyticsHookhelper, plus minor jest mocking cleanup forStorageWrapper.getItem.Written by Cursor Bugbot for commit 55c10d9. This will update automatically on new commits. Configure here.