fix(bridge): support cursor-aware custom slippage input by bfullam · Pull Request #27920 · MetaMask/metamask-mobile

bfullam · 2026-03-25T15:20:22Z

Description

This PR makes the custom slippage modal cursor-aware. It adds a dedicated slippage cursor hook that reuses the shared raw cursor editing utilities, wires controlled selection / onSelectionChange through InputStepper, preserves the existing slippage-specific max and decimal validation rules, resets cursor state when the stepper buttons change the value, and sanitizes trailing decimals such as 2. before saving the selected slippage.

Changelog

CHANGELOG entry: Fixed custom slippage input so keypad edits respect cursor placement and trailing decimals are sanitized before saving.

Related issues

Fixes:

Manual testing steps

Feature: custom slippage cursor-aware editing

  Scenario: user inserts a digit at a chosen cursor position
    Given the user opens Bridge and opens the custom slippage modal
    And the custom slippage value is "12.5"

    When the user places the caret between "1" and "2"
    And the user taps "5" on the keypad
    Then the displayed custom slippage value updates to "152.5"

  Scenario: user resets the cursor by using the stepper buttons
    Given the user opens Bridge and opens the custom slippage modal
    And the user places the caret in the middle of the custom slippage value

    When the user taps the "+" stepper button
    And the user taps "5" on the keypad
    Then the next keypad edit follows the new stepper-updated value instead of the old caret position

  Scenario: user confirms a value with a trailing decimal
    Given the user opens Bridge and opens the custom slippage modal
    And the custom slippage value is "2."

    When the user taps "Confirm"
    Then the saved slippage value is "2"

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches user input/editing logic in the Bridge slippage flow (cursor mapping + keypad handling), which can introduce subtle edge-case regressions, but scope is localized and covered by new tests.

Overview
Makes the Bridge CustomSlippageModal cursor-aware by introducing useCustomSlippageCursor, which tracks and maps selection between formatted and raw values and applies keypad edits at the current caret position (while preserving max/decimal validation and over-max flagging).

Extends InputStepper to accept controlled selection/onSelectionChange, wires these through the slippage modal, resets cursor state when +/- stepper buttons adjust the value, and sanitizes trailing decimals (e.g., 2. -> 2) before dispatching setSlippage. Tests are updated/added to cover cursor insertion/backspace behavior, trailing-decimal sanitization, and the new selection plumbing.

^{Written by Cursor Bugbot for commit b963576. This will update automatically on new commits. Configure here.}

github-actions · 2026-03-25T15:20:34Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

github-actions · 2026-03-25T16:15:27Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeTrade, SmokeConfirmations
Selected Performance tags: None (no tests recommended)
Risk Level: low
AI Confidence: 92%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are entirely scoped to the Bridge SlippageModal UI components:

InputStepper - Added optional selection and onSelectionChange props to support cursor-aware text input
useCustomSlippageCursor - New hook managing cursor position state for the slippage keypad input
CustomSlippageModal - Refactored to use the new cursor hook, with trailing decimal sanitization on confirm

These changes improve the UX of the custom slippage input in the Bridge flow (cross-chain bridging), allowing users to edit at specific cursor positions rather than always appending. The changes are low-risk UI refinements with no impact on core logic, controllers, navigation, or shared components.

SmokeTrade is selected because the Bridge cross-chain feature is directly affected (slippage modal is part of the bridge flow).
SmokeConfirmations is selected per the tag description: "when selecting SmokeTrade for swap/bridge, also select SmokeConfirmations."

No other tags are warranted as the changes don't touch accounts, identity, network management, snaps, ramps, or any other feature areas.

Performance Test Selection:
The changes are minor UI input handling improvements (cursor position management for a text input in the slippage modal). There is no impact on rendering performance, data loading, state management at scale, or any of the performance-sensitive flows covered by the available performance test tags.

View GitHub Actions results

github-actions · 2026-03-25T16:32:48Z

✅ E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

sonarqubecloud · 2026-03-25T16:43:07Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

bfullam requested a review from a team as a code owner March 25, 2026 15:20

metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Mar 25, 2026

github-actions Bot added size-L risk-low Low testing needed · Low bug introduction risk labels Mar 25, 2026

bfullam changed the title ~~Add cursor-aware editing to custom slippage input~~ fix(bridge): support cursor-aware custom slippage input Mar 25, 2026

chore: add useCustomSlippageCursor so slippage follows cursor usage

250e552

bfullam force-pushed the swaps-slippage-input-cursor branch from c0a13c5 to 250e552 Compare March 25, 2026 15:47

github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 25, 2026

cursor Bot reviewed Mar 25, 2026

View reviewed changes

Comment thread app/components/UI/Bridge/components/SlippageModal/useCustomSlippageCursor.ts

test: remove redundant InputStepper selection passthrough tests

1b1faee

github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 25, 2026

test: remove redundant slippage input stepper assertion

b963576

github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Mar 25, 2026

infiniteflower approved these changes Mar 26, 2026

View reviewed changes

bfullam added this pull request to the merge queue Mar 27, 2026

Merged via the queue into main with commit 5b49b16 Mar 27, 2026
96 checks passed

bfullam deleted the swaps-slippage-input-cursor branch March 27, 2026 14:20

github-actions Bot locked and limited conversation to collaborators Mar 27, 2026

metamaskbot added the release-7.73.0 Issue or pull request that will be included in release 7.73.0 label Mar 27, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(bridge): support cursor-aware custom slippage input#27920

fix(bridge): support cursor-aware custom slippage input#27920
bfullam merged 3 commits into
mainfrom
swaps-slippage-input-cursor

bfullam commented Mar 25, 2026 •

edited by cursor Bot

Loading

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

sonarqubecloud Bot commented Mar 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

bfullam commented Mar 25, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Mar 25, 2026

🔍 Smart E2E Test Selection

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

sonarqubecloud Bot commented Mar 25, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bfullam commented Mar 25, 2026 •

edited by cursor Bot

Loading