Skip to content

fix: hides perps buttons in ai insights when user has a position cp-7.71.0#27919

Merged
joaosantos15 merged 1 commit into
mainfrom
TSA-fix-perps-ai-buttons
Mar 25, 2026
Merged

fix: hides perps buttons in ai insights when user has a position cp-7.71.0#27919
joaosantos15 merged 1 commit into
mainfrom
TSA-fix-perps-ai-buttons

Conversation

@joaosantos15

@joaosantos15 joaosantos15 commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Description

This PR is a bug fix for #27916 where:

  • In the AI Market Insights in Perps, the action buttons are wrong when user has an open position: the action buttons should be the same in AI market insight page and market page, ie. “modify” and “Close” when user has an open position

Fix:

  • When the user has an existing perps position, the MarketInsights footer action buttons (Long/Short) are hidden since the relevant actions (modify/close) live on the Perps market details page
  • The "AI summary for information only" disclaimer is moved inline below the feedback section when the footer is hidden, so it remains visible
  • Position state is passed via route params (hasPerpsPosition) from the caller rather than fetched async inside MarketInsightsView, preventing a flash where buttons briefly appear then disappear while the position loads

Changelog

CHANGELOG entry: Fixed a bug that was causing incorrect Perps action buttons to be displayed

Related issues

Fixes: #27916

Manual testing steps

- Open MarketInsights from token details → Swap/Buy buttons visible with disclaimer in footer
- Open MarketInsights from perps with no position → Long/Short buttons visible with disclaimer in footer
- Open MarketInsights from perps with an existing position → no footer buttons, disclaimer shown below "Was this helpful?"
- Verify no flash/layout shift on the perps + position flow

Screenshots/Recordings

Before

ScreenRecording_03-25-2026.13-32-38_1.MP4

After

SCR-20260325-nzfa

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI/navigation tweak that changes which CTAs are shown based on a new route param; main risk is incorrect param wiring causing missing actions or disclaimer placement in the Perps insights flow.

Overview
Fixes Perps AI Market Insights showing inappropriate Long/Short CTAs when the user already has an open position.

Adds a hasPerpsPosition route param (set by PerpsMarketDetailsView) and uses it in MarketInsightsView to hide the footer action buttons for Perps-with-position while keeping the informational disclaimer visible by moving it inline under the feedback section for that case.

Written by Cursor Bugbot for commit 833593b. This will update automatically on new commits. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-social-ai Social & AI team label Mar 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@joaosantos15 joaosantos15 changed the title fix: hides perps buttons in ai insights when user has a position fix: hides perps buttons in ai insights when user has a position cp-7.71.0 Mar 25, 2026
@joaosantos15 joaosantos15 marked this pull request as ready for review March 25, 2026 15:00
@joaosantos15 joaosantos15 requested a review from a team as a code owner March 25, 2026 15:00

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@joaosantos15 joaosantos15 enabled auto-merge March 25, 2026 15:06
@joaosantos15 joaosantos15 disabled auto-merge March 25, 2026 15:06
@joaosantos15 joaosantos15 enabled auto-merge March 25, 2026 15:12
@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

@sonarqubecloud

Copy link
Copy Markdown

@joaosantos15 joaosantos15 added this pull request to the merge queue Mar 25, 2026
Merged via the queue into main with commit 8a7bced Mar 25, 2026
240 of 242 checks passed
@joaosantos15 joaosantos15 deleted the TSA-fix-perps-ai-buttons branch March 25, 2026 16:19
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 25, 2026
@metamaskbot metamaskbot added the release-7.72.0 Issue or pull request that will be included in release 7.72.0 label Mar 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.72.0 Issue or pull request that will be included in release 7.72.0 size-M team-social-ai Social & AI team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Perps action buttons display incorrect state when user has position

4 participants