fix: hides perps buttons in ai insights when user has a position cp-7.71.0#27919
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - draft PR All E2E tests pre-selected. |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
aganglada
approved these changes
Mar 25, 2026
zone-live
approved these changes
Mar 25, 2026
Contributor
|
✅ E2E Fixture Validation — Schema is up to date |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
This PR is a bug fix for #27916 where:
Fix:
Changelog
CHANGELOG entry: Fixed a bug that was causing incorrect Perps action buttons to be displayed
Related issues
Fixes: #27916
Manual testing steps
- Open MarketInsights from token details → Swap/Buy buttons visible with disclaimer in footer - Open MarketInsights from perps with no position → Long/Short buttons visible with disclaimer in footer - Open MarketInsights from perps with an existing position → no footer buttons, disclaimer shown below "Was this helpful?" - Verify no flash/layout shift on the perps + position flowScreenshots/Recordings
Before
ScreenRecording_03-25-2026.13-32-38_1.MP4
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk UI/navigation tweak that changes which CTAs are shown based on a new route param; main risk is incorrect param wiring causing missing actions or disclaimer placement in the Perps insights flow.
Overview
Fixes Perps AI Market Insights showing inappropriate
Long/ShortCTAs when the user already has an open position.Adds a
hasPerpsPositionroute param (set byPerpsMarketDetailsView) and uses it inMarketInsightsViewto hide the footer action buttons for Perps-with-position while keeping the informational disclaimer visible by moving it inline under the feedback section for that case.Written by Cursor Bugbot for commit 833593b. This will update automatically on new commits. Configure here.