Skip to content

chore: visual update and animation market insights#27914

Merged
zone-live merged 16 commits into
mainfrom
TSA-visual-update-and-animation-market-insights
Mar 25, 2026
Merged

chore: visual update and animation market insights#27914
zone-live merged 16 commits into
mainfrom
TSA-visual-update-and-animation-market-insights

Conversation

@zone-live

@zone-live zone-live commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Description

Screenshot 2026-03-25 at 16 08 01
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-25.at.16.09.21.mov

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Adds new Reanimated/SVG border animation and a polling-based useViewportTracking hook, which may impact UI performance or behave differently across layouts if measurement/visibility is off.

Overview
Updates the Market Insights entry card visuals by switching to a new rounded, muted-background card layout and replacing the prior header/arrow treatment with an inline AI icon plus footer text.

Introduces an AnimatedGradientBorder (SVG + Reanimated) that sweeps a gradient stroke around the card when it becomes fully visible, driven by new useViewportTracking viewport detection.

Adds targeted tests for the new trace behavior, layout/dimension updates, and the viewport-tracking hook; also excludes the legacy MarketInsightsEntryCardOriginal.tsx and the animation component from coverage/sonar, and moves the entry card placement earlier in AssetOverviewContent.

Written by Cursor Bugbot for commit f96c206. This will update automatically on new commits. Configure here.

@zone-live zone-live requested a review from a team as a code owner March 25, 2026 13:34
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-social-ai Social & AI team label Mar 25, 2026
@github-actions github-actions Bot added size-L risk-low Low testing needed · Low bug introduction risk labels Mar 25, 2026
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 25, 2026
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 25, 2026
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 25, 2026
@github-actions github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 25, 2026
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Mar 25, 2026
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 25, 2026
@zone-live zone-live added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Mar 25, 2026
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 25, 2026
@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 25, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 88%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are entirely contained within the MarketInsights feature area:

  1. AnimatedGradientBorder.tsx (new): A new SVG-based animated border component using react-native-reanimated. Purely visual, no business logic impact.
  2. AnimatedGradientBorder.constants.ts (new): Animation constants only.
  3. MarketInsightsEntryCard.tsx: UI refactor - new layout with animated border, viewport tracking for animation trigger. No changes to data flow, navigation, or shared components.
  4. useViewportTracking.ts (new): A viewport detection hook using polling. Scoped to MarketInsights.
  5. AssetOverviewContent.tsx: Minor repositioning of the MarketInsightsEntryCard render location (moved earlier in the JSX tree, before Tron section). No logic changes.
  6. jest.config.js: Added coverage exclusions for the new/original files - no impact on E2E tests.
  7. sonar-project.properties: Minor config change.

No E2E tests exist for MarketInsights or TokenDetails in the spec files (confirmed via grep). The changes don't touch any shared infrastructure: no navigation changes, no modal/bottom sheet changes, no controller changes, no confirmation flows, no account/network management. The risk is low and no E2E tags are applicable.

Performance Test Selection:
The AnimatedGradientBorder uses react-native-reanimated for a one-time sweep animation triggered by viewport visibility. While it introduces animation, it is a lightweight, single-occurrence animation on a single card component within the token details page. It does not affect account lists, app startup, login flows, swap flows, or any other performance-critical paths. No performance tests are warranted.

View GitHub Actions results

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was added in another PR?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was, a while ago, but we're still updating the position in the view based on feedback 😅

@zone-live zone-live enabled auto-merge March 25, 2026 19:25
@sonarqubecloud

Copy link
Copy Markdown

@zone-live zone-live added this pull request to the merge queue Mar 25, 2026
Merged via the queue into main with commit dfdfbce Mar 25, 2026
62 checks passed
@zone-live zone-live deleted the TSA-visual-update-and-animation-market-insights branch March 25, 2026 19:47
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 25, 2026
@metamaskbot metamaskbot added the release-7.72.0 Issue or pull request that will be included in release 7.72.0 label Mar 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.72.0 Issue or pull request that will be included in release 7.72.0 risk-low Low testing needed · Low bug introduction risk size-L skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-social-ai Social & AI team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants