feat(swaps): add verified badges to asset picker by bfullam · Pull Request #27878 · MetaMask/metamask-mobile

bfullam · 2026-03-24T15:38:55Z

Description

This adds a verified trust signal to the swap/bridge asset picker when the backend returns isVerified on popular and search token results. The change threads the new field through the bridge token models, preserves it during token-to-balance merging, renders the verified badge inline in picker rows, and adds focused coverage for popular tokens, search results, and row rendering.

Changelog

CHANGELOG entry: Added verified badges to swap asset picker tokens

Related issues

Fixes:
Refs: SWAPS-4219

Manual testing steps

Feature: Swap asset picker verified trust signals

  Background:
    Given I am logged into MetaMask Mobile
    And I can open the swap or bridge asset picker

  Scenario: user sees a verified badge for a popular token
    Given the popular token response includes a token with isVerified set to true

    When user opens the source or destination asset picker
    Then the verified token should display a verified badge in its list row
    And tokens without isVerified should not display the badge

  Scenario: user sees a verified badge for a searched token
    Given the search token response includes a token with isVerified set to true

    When user searches for that token in the asset picker
    Then the search result should display a verified badge in its list row
    And the token should remain selectable as usual

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI/model threading of a new optional isVerified flag; main risk is minor layout/test regressions in the token picker row rendering.

Overview
Adds support for an optional isVerified trust signal on Bridge API token results and threads it into the in-app BridgeToken model.

Updates the token picker row (TokenSelectorItem) to render a small verified icon next to the token symbol when token.isVerified is true, and extends unit tests/fixtures to assert the flag is preserved through popular/search fetching and balance-merging, and is passed through BridgeTokenSelector into row rendering.

^{Written by Cursor Bugbot for commit 02a4efd. This will update automatically on new commits. Configure here.}

github-actions · 2026-03-24T15:39:16Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

github-actions · 2026-03-24T18:22:18Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeTrade, SmokeConfirmations
Selected Performance tags: None (no tests recommended)
Risk Level: medium
AI Confidence: 88%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes introduce an isVerified field to the Bridge token types and UI components:

app/components/UI/Bridge/types.ts - Added optional isVerified?: boolean to BridgeToken interface
app/components/UI/Bridge/hooks/usePopularTokens.ts - Added isVerified to PopularToken interface
app/components/UI/Bridge/components/TokenSelectorItem.tsx - Added conditional rendering of a verified icon (VerifiedFilled) next to token symbols in the Bridge token selector when token.isVerified is true
tests/helpers/swap/constants.ts (CRITICAL) - Added isVerified: true to ETH in GET_POPULAR_TOKENS_MAINNET_RESPONSE, which is used by both bridge-mocks.ts and swap-mocks.ts in E2E tests

The E2E test helper change (tests/helpers/swap/constants.ts) is the most impactful - it updates the mock API response used by bridge and swap E2E smoke tests. The GET_POPULAR_TOKENS_MAINNET_RESPONSE is consumed by bridge-mocks.ts (used in bridge-action-smoke.spec.ts, swap-trending-tokens.spec.ts) and swap-mocks.ts (used in swap-action-smoke.spec.ts, swap-deeplink-smoke.spec.ts, gasless-swap.spec.ts).

SmokeTrade is selected because the changes directly affect bridge and swap token selector UI and E2E mock data.
SmokeConfirmations is required per SmokeTrade tag description: "When selecting SmokeTrade for swap or bridge flows, also select SmokeConfirmations."

No other tags are needed - the changes are isolated to the Bridge/Swap token selector component and its test infrastructure. The changes are additive (new optional field + new UI element) and don't affect core wallet, accounts, network, or other flows.

Performance Test Selection:
The changes add a small conditional icon render to the Bridge token selector item. This is a minor UI addition (a single Icon component rendered conditionally) that is unlikely to have measurable performance impact on list rendering. No performance tests are warranted for this change.

View GitHub Actions results

github-actions · 2026-03-24T18:51:26Z

✅ E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

sonarqubecloud · 2026-03-24T20:47:00Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

feat: add verified badge

17198d3

bfullam requested a review from a team as a code owner March 24, 2026 15:38

metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Mar 24, 2026

github-actions Bot added size-M risk-medium Moderate testing recommended · Possible bug introduction risk labels Mar 24, 2026

bfullam changed the title ~~Add verified badges to swap asset picker tokens~~ feat(swaps): add verified badges to asset picker Mar 24, 2026

chore: use design system and infoDefault coloring

06aaada

github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Mar 24, 2026

GeorgeGkas previously approved these changes Mar 24, 2026

View reviewed changes

bfullam enabled auto-merge March 24, 2026 16:13

cursor Bot reviewed Mar 24, 2026

View reviewed changes

Comment thread app/components/UI/Bridge/components/TokenSelectorItem.test.tsx Outdated

test: strengthen verified icon assertions in token selector

851f574

bfullam dismissed GeorgeGkas’s stale review via 851f574 March 24, 2026 16:35

github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Mar 24, 2026

cursor Bot reviewed Mar 24, 2026

View reviewed changes

Comment thread app/components/UI/Bridge/components/TokenSelectorItem.tsx

fix: remove redundant token selector spacing

02a4efd

github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Mar 24, 2026

bfullam disabled auto-merge March 24, 2026 18:25

SteP-n-s approved these changes Mar 25, 2026

View reviewed changes

bfullam added this pull request to the merge queue Mar 27, 2026

Merged via the queue into main with commit 73e9352 Mar 27, 2026
167 of 171 checks passed

bfullam deleted the swaps-verified-badge branch March 27, 2026 14:21

github-actions Bot locked and limited conversation to collaborators Mar 27, 2026

metamaskbot added the release-7.73.0 Issue or pull request that will be included in release 7.73.0 label Mar 27, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(swaps): add verified badges to asset picker#27878

feat(swaps): add verified badges to asset picker#27878
bfullam merged 4 commits into
mainfrom
swaps-verified-badge

bfullam commented Mar 24, 2026 •

edited by cursor Bot

Loading

Uh oh!

github-actions Bot commented Mar 24, 2026

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented Mar 24, 2026

Uh oh!

github-actions Bot commented Mar 24, 2026

Uh oh!

sonarqubecloud Bot commented Mar 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

bfullam commented Mar 24, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Mar 24, 2026

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Mar 24, 2026

🔍 Smart E2E Test Selection

Uh oh!

github-actions Bot commented Mar 24, 2026

Uh oh!

sonarqubecloud Bot commented Mar 24, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bfullam commented Mar 24, 2026 •

edited by cursor Bot

Loading