Skip to content

feat: migrate Button (web3auth scope)#27810

Merged
kirillzyusko merged 3 commits into
mainfrom
feat/migrate-button-web3auth-scope
Mar 26, 2026
Merged

feat: migrate Button (web3auth scope)#27810
kirillzyusko merged 3 commits into
mainfrom
feat/migrate-button-web3auth-scope

Conversation

@kirillzyusko

@kirillzyusko kirillzyusko commented Mar 23, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Replace deprecated Button usage with DSRN package.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-445

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-25.at.17.16.56.mov

After

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-25.at.17.17.12.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches critical onboarding/login entry points by swapping button components and props; risk is mainly UI/interaction regressions (disabled/loading/accessibility) rather than logic changes.

Overview
Migrates several onboarding/authentication screens from the deprecated component-library Button to the design-system Button (DSRN), updating props (variant, isFullWidth, isDisabled, isLoading) and switching to children-based labels.

Link-style buttons that aren’t yet migrated remain on the old component (OldButton). Tests and snapshots are updated accordingly, including switching assertions to toBeDisabled()/toBeEnabled() and reflecting the new button render/accessibility structure.

Written by Cursor Bugbot for commit 40ba4e7. This will update automatically on new commits. Configure here.

@kirillzyusko kirillzyusko self-assigned this Mar 23, 2026
@github-actions

github-actions Bot commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@kirillzyusko kirillzyusko force-pushed the feat/migrate-button-web3auth-scope branch 2 times, most recently from 0832765 to b5fd3e6 Compare March 24, 2026 18:03
@kirillzyusko kirillzyusko force-pushed the feat/migrate-button-web3auth-scope branch from b5fd3e6 to 40ba4e7 Compare March 24, 2026 19:49
@github-actions

github-actions Bot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@github-actions

github-actions Bot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

✅ E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

@sonarqubecloud

sonarqubecloud Bot commented Mar 24, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kirillzyusko kirillzyusko marked this pull request as ready for review March 25, 2026 16:17
@kirillzyusko kirillzyusko requested a review from a team as a code owner March 25, 2026 16:17
ieow
ieow approved these changes Mar 26, 2026
View reviewed changes

@ieow ieow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

grvgoel81
grvgoel81 reviewed Mar 26, 2026
View reviewed changes
Comment thread app/components/Views/OAuthRehydration/index.tsx

{isSeedlessPasswordOutdated ? (
<Button
<OldButton

@grvgoel81 grvgoel81 Mar 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was previously using Button, but now uses OldButton which is deprecated. Any specific reason for it?

@kirillzyusko kirillzyusko Mar 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is no direct equivalent of Link varinat in design repo at the moment. Closest options are Tertiary or TextButton, but there is also no 1:1 migration. So I wanted to split up the work and for all .Link variants keep the old component and migrate it later when we'll have a clear path on migration 😊

Comment thread app/components/Views/ImportFromSecretRecoveryPhrase/index.js
import { MetricsEventBuilder } from '../../../core/Analytics/MetricsEventBuilder';
import Checkbox from '../../../component-library/components/Checkbox';
import Button, {
import OldButton, {

@grvgoel81 grvgoel81 Mar 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was previously using Button, but now uses OldButton which is deprecated. Any specific reason for it?

@kirillzyusko kirillzyusko added this pull request to the merge queue Mar 26, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 26, 2026
@kirillzyusko kirillzyusko added this pull request to the merge queue Mar 26, 2026
Merged via the queue into main with commit 2cfeb08 Mar 26, 2026
137 of 138 checks passed
@kirillzyusko kirillzyusko deleted the feat/migrate-button-web3auth-scope branch March 26, 2026 13:09
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 26, 2026
@metamaskbot metamaskbot added the release-7.72.0 Issue or pull request that will be included in release 7.72.0 label Mar 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@grvgoel81 grvgoel81 grvgoel81 left review comments

@ieow ieow ieow approved these changes

Assignees

@kirillzyusko kirillzyusko

Labels

release-7.72.0 Issue or pull request that will be included in release 7.72.0 size-M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kirillzyusko @ieow @grvgoel81 @metamaskbot