feat: migrate Button (confirmations scope)#27805
Merged
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
e7ae3ab to
45edb92
Compare
45edb92 to
845cb73
Compare
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - draft PR All E2E tests pre-selected. |
Contributor
|
✅ E2E Fixture Validation — Schema is up to date |
|
OGPoyraz
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Replace deprecated
Buttonusage with DSRN package.Changelog
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-445
Manual testing steps
Screenshots/Recordings
Before
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-25.at.15.55.23.mov
After
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-25.at.15.55.44.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Moderate risk because it swaps the underlying
Buttonimplementation across multiple confirmation keyboards/modals, which could subtly change disabled/press behavior and layout in transaction-critical screens.Overview
Migrates confirmation-flow buttons from the deprecated component-library
Buttonto@metamask/design-system-react-native, updating APIs (e.g.,labelto children,disabledtoisDisabled,widthtoisFullWidth, and newButtonVariantenums) across keyboards, developer options, transaction retry, and gas/alert/spending-cap modals.Updates associated tests and snapshots to match the new rendered structure/props, including switching assertions to
toBeDisabled()/toBeEnabled().Written by Cursor Bugbot for commit 845cb73. This will update automatically on new commits. Configure here.