Skip to content

feat: migrate Button (confirmations scope)#27805

Merged
kirillzyusko merged 4 commits into
mainfrom
feat/migrate-button-confirmations-scope
Mar 25, 2026
Merged

feat: migrate Button (confirmations scope)#27805
kirillzyusko merged 4 commits into
mainfrom
feat/migrate-button-confirmations-scope

Conversation

@kirillzyusko

@kirillzyusko kirillzyusko commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Description

Replace deprecated Button usage with DSRN package.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-445

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-25.at.15.55.23.mov

After

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-25.at.15.55.44.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Moderate risk because it swaps the underlying Button implementation across multiple confirmation keyboards/modals, which could subtly change disabled/press behavior and layout in transaction-critical screens.

Overview
Migrates confirmation-flow buttons from the deprecated component-library Button to @metamask/design-system-react-native, updating APIs (e.g., label to children, disabled to isDisabled, width to isFullWidth, and new ButtonVariant enums) across keyboards, developer options, transaction retry, and gas/alert/spending-cap modals.

Updates associated tests and snapshots to match the new rendered structure/props, including switching assertions to toBeDisabled() / toBeEnabled().

Written by Cursor Bugbot for commit 845cb73. This will update automatically on new commits. Configure here.

@kirillzyusko kirillzyusko self-assigned this Mar 23, 2026
@kirillzyusko kirillzyusko added the team-confirmations Push issues to confirmations team label Mar 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@kirillzyusko kirillzyusko force-pushed the feat/migrate-button-confirmations-scope branch 2 times, most recently from e7ae3ab to 45edb92 Compare March 24, 2026 17:58
@kirillzyusko kirillzyusko force-pushed the feat/migrate-button-confirmations-scope branch from 45edb92 to 845cb73 Compare March 24, 2026 19:46
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

@sonarqubecloud

Copy link
Copy Markdown

@kirillzyusko kirillzyusko marked this pull request as ready for review March 25, 2026 14:57
@kirillzyusko kirillzyusko requested a review from a team as a code owner March 25, 2026 14:57
@kirillzyusko kirillzyusko enabled auto-merge March 25, 2026 18:48
@kirillzyusko kirillzyusko added this pull request to the merge queue Mar 25, 2026
Merged via the queue into main with commit 01706bd Mar 25, 2026
221 of 223 checks passed
@kirillzyusko kirillzyusko deleted the feat/migrate-button-confirmations-scope branch March 25, 2026 19:10
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 25, 2026
@metamaskbot metamaskbot added the release-7.72.0 Issue or pull request that will be included in release 7.72.0 label Mar 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.72.0 Issue or pull request that will be included in release 7.72.0 size-M team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants