fix(ramps): select BuildQuote quote with normalized provider id#27779
Closed
amitabh94 wants to merge 1 commit into
Closed
fix(ramps): select BuildQuote quote with normalized provider id#27779amitabh94 wants to merge 1 commit into
amitabh94 wants to merge 1 commit into
Conversation
Made-with: Cursor
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - draft PR All E2E tests pre-selected. |
Contributor
|
✅ E2E Fixture Validation — Schema is up to date |
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Unified Buy v2 BuildQuote (amount input) derives
selectedQuotefrom the quotes APIsuccessarray. The previous logic used only the first quote and requiredquote.provider === selectedProvider.id.Quotes can still be scoped to the selected provider via request params while returning
providerstrings that do not exactly match controller state (for example/providers/transakvstransak). In that caseselectedQuotewasnulleven though a valid quote existed, which surfaced as “We’ve encountered an error” / no-quotes UI (hasNoQuotes) and looked intermittent when amounts refetched.This change selects the quote with
normalizeProviderCodeon both sides and uses.findoversuccessso the correct row is matched regardless of path vs short id formatting.Changelog
CHANGELOG entry: Fixed Buy amount screen sometimes showing a generic error when quotes returned for the selected provider but provider id strings differed in format.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist