Skip to content

chore: Exempt metamaskbotv2 from CLA check cp-7.71.0#27758

Merged
chloeYue merged 1 commit into
mainfrom
fix-patroll-cla-failure
Mar 20, 2026
Merged

chore: Exempt metamaskbotv2 from CLA check cp-7.71.0#27758
chloeYue merged 1 commit into
mainfrom
fix-patroll-cla-failure

Conversation

@Gudahtt

@Gudahtt Gudahtt commented Mar 20, 2026

Copy link
Copy Markdown
Member

Description

The CLABot workflow has been updated to exempt metamaskv2 (i.e. commits created by Patroll tokens) from the CLA check.

We saw the CLA check fail recently on a release branch due to some commits appearing for the first time from Patroll (see #27708 (comment)). This change will fix that CI failure.

Changelog

CHANGELOG entry: null

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk workflow change limited to expanding the CLA bot allowlist; main impact is potentially skipping CLA enforcement for this additional bot account.

Overview
Updates the CLA Signature Bot GitHub Actions workflow to add metamaskbotv2[bot] to the CLA exemption allowlist, preventing CLA check failures on PRs/merge groups created by that bot.

Written by Cursor Bugbot for commit f1f4342. This will update automatically on new commits. Configure here.

The CLABot workflow has been updated to exempt `metamaskv2` (i.e.
commits created by Patroll tokens) from the CLA check.

We saw the CLA check fail recently on a release branch due to some
commits appearing for the first time from Patroll (see
#27708 (comment)).
This change will fix that CI failure.
@Gudahtt Gudahtt requested a review from a team as a code owner March 20, 2026 17:59
@metamaskbot metamaskbot added the team-core-platform Core Platform team label Mar 20, 2026
Comment thread .github/workflows/cla.yml
# This branch can't have protections, commits are made directly to the specified branch.
branch: 'cla-signatures'
allowlist: 'dependabot[bot],metamaskbot,crowdin-bot,runway-github[bot],cursorbot,cursoragent'
allowlist: 'dependabot[bot],metamaskbot,metamaskbotv2[bot],crowdin-bot,runway-github[bot],cursorbot,cursoragent'

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've needed metamaskbotv2[bot] on the allowlist on extension for a bit longer, see here for reference: https://github.com/MetaMask/metamask-extension/blob/c5247c5d3b45d85a99258ac3dbcdc2554615edfa/.github/workflows/cla.yml#L30

@github-actions github-actions Bot added size-XS risk-low Low testing needed · Low bug introduction risk labels Mar 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 99%
click to see 🤖 AI reasoning details

E2E Test Selection:
The change to .github/workflows/cla.yml is purely a CI configuration update with two trivial modifications:

  1. Removal of trailing whitespace on a blank line (cosmetic)
  2. Addition of metamaskbotv2[bot] to the CLA bot allowlist

This workflow only handles Contributor License Agreement checking for pull requests. It has absolutely no impact on:

  • Application code or functionality
  • E2E test flows or test infrastructure
  • Performance-sensitive code paths
  • Any user-facing features

No E2E tests need to run for this change. The CLA workflow is completely isolated from the app's test suite.

Performance Test Selection:
The change is a pure CI configuration update to the CLA bot allowlist. There is no application code change, no UI rendering change, no data loading change, and no impact on any performance-sensitive code paths. No performance tests are needed.

View GitHub Actions results

@Gudahtt Gudahtt changed the title chore: Exempt metamaskbotv2 from CLA check chore: Exempt metamaskbotv2 from CLA check cp-7.71.0 Mar 20, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment thread .github/workflows/cla.yml
@sonarqubecloud

Copy link
Copy Markdown

@chloeYue chloeYue enabled auto-merge March 20, 2026 20:27
@chloeYue chloeYue added this pull request to the merge queue Mar 20, 2026
Merged via the queue into main with commit 0f0a400 Mar 20, 2026
90 checks passed
@chloeYue chloeYue deleted the fix-patroll-cla-failure branch March 20, 2026 20:49
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 20, 2026
@metamaskbot metamaskbot added the release-7.72.0 Issue or pull request that will be included in release 7.72.0 label Mar 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.72.0 Issue or pull request that will be included in release 7.72.0 risk-low Low testing needed · Low bug introduction risk size-XS team-core-platform Core Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants