Skip to content

fix(bridge): align swap token inputs with quote details#27730

Merged
bfullam merged 1 commit into
mainfrom
swaps-fix-input-padding
Mar 20, 2026
Merged

fix(bridge): align swap token inputs with quote details#27730
bfullam merged 1 commit into
mainfrom
swaps-fix-input-padding

Conversation

@bfullam

@bfullam bfullam commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

Description

After the quote card was updated to match Figma (#21656), horizontal padding was removed from quoteContainer, so QuoteDetailsCard content uses a 16px gutter from QuoteDetailsCard.styles.ts. The swap token row wrapper (inputsContainer in BridgeView.styles.ts) still used 24px, so the large amount text and fiat values sat 8px further in than the Rate / Network fee / Slippage rows.

This change sets inputsContainer.paddingHorizontal to 16 so the swap inputs share the same left edge as the quote details (and match the trending section’s px-4 gutter). Addresses SWAPS-4268.

Changelog

CHANGELOG entry: Fixed swap amount fields not lining up horizontally with swap quote details on mobile

Related issues

Fixes:

Refs: SWAPS-4268

Manual testing steps

Feature: Swap / Bridge quote layout

  Scenario: swap amounts align with quote details
    Given I am on the Swap screen with tokens selected and a non-zero source amount
    And an active quote is shown with the quote details card visible

    When I view the source and destination amount rows and the rows below (Rate, Network fee, Slippage, etc.)

    Then the left edge of the amount and fiat text should align with the left edge of the detail labels

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bfullam bfullam requested a review from a team as a code owner March 20, 2026 11:21
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Mar 20, 2026
@bfullam bfullam changed the title chore: padding fix(bridge): align swap token inputs with quote details Mar 20, 2026
@github-actions github-actions Bot added the risk-low Low testing needed · Low bug introduction risk label Mar 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeTrade
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

E2E Test Selection:
The change is a single-line CSS styling modification in BridgeView.styles.ts, reducing the inputsContainer horizontal padding from 24 to 16 pixels. This is a purely cosmetic/layout change with no functional impact. It cannot break any business logic, state management, or user flows. The only relevant test tag is SmokeTrade, which covers bridge flows, to verify the UI still renders correctly and the bridge feature remains functional after the padding adjustment. No other tags are needed as this change is isolated to the Bridge view's styling. Per SmokeTrade tag description, SmokeConfirmations should also be included since bridge flows involve transaction confirmations.

Performance Test Selection:
This is a minor padding change (24px to 16px) in a style file. While it affects UI layout, it's too minor to meaningfully impact rendering performance metrics. No performance tests are warranted for this cosmetic change.

View GitHub Actions results

@bfullam bfullam enabled auto-merge March 20, 2026 11:24
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

@bfullam bfullam added this pull request to the merge queue Mar 20, 2026
Merged via the queue into main with commit fbfbf17 Mar 20, 2026
178 of 183 checks passed
@bfullam bfullam deleted the swaps-fix-input-padding branch March 20, 2026 14:36
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 20, 2026
@metamaskbot metamaskbot added the release-7.72.0 Issue or pull request that will be included in release 7.72.0 label Mar 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.72.0 Issue or pull request that will be included in release 7.72.0 risk-low Low testing needed · Low bug introduction risk size-XS team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants