Skip to content

chore: upgrade Xcode to 26.3 to satisfy iOS 26 SDK requirement#27726

Merged
tommasini merged 3 commits into
mainfrom
chore/xcode-26.3-build
Apr 6, 2026
Merged

chore: upgrade Xcode to 26.3 to satisfy iOS 26 SDK requirement#27726
tommasini merged 3 commits into
mainfrom
chore/xcode-26.3-build

Conversation

@tommasini

@tommasini tommasini commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

Description

Apple requires all iOS and iPadOS apps to be built with the iOS 26 SDK (Xcode 26 or later) starting April 28, 2026. The current workflows used Xcode 16.3 (iOS 18.4 SDK), which will cause App Store Connect rejections after that date.

This PR bumps the pinned Xcode version from 16.3 to 26.3 in both affected workflow files. Xcode 26.3 ships with the iOS 26.2 SDK and runs on macOS Sequoia 15.6+, so no runner image change is needed.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor


Note

Medium Risk
Medium risk because it changes the iOS build/test toolchain used in CI and could break workflows if the runner image or Xcode app path/version isn’t available or introduces new build incompatibilities.

Overview
Updates CI to build and run iOS workflows with Xcode 26.3 instead of 16.3, adjusting both the main build workflow (build.yml) and the iOS API-specs E2E workflow (run-e2e-api-specs.yml) to select /Applications/Xcode_26.3.app.

Reviewed by Cursor Bugbot for commit 2682bc6. Bugbot is set up for automated code reviews on this repo. Configure here.

@tommasini tommasini self-assigned this Mar 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Mar 20, 2026
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Mar 20, 2026
@tommasini tommasini marked this pull request as ready for review March 20, 2026 09:21
@tommasini tommasini requested a review from a team as a code owner March 20, 2026 09:21

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Mar 20, 2026
@tommasini tommasini enabled auto-merge March 23, 2026 18:56
@github-actions github-actions Bot added the risk-medium Moderate testing recommended · Possible bug introduction risk label Mar 23, 2026
@github-actions github-actions Bot removed the risk-medium Moderate testing recommended · Possible bug introduction risk label Apr 6, 2026
@github-actions

github-actions Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeCard, SmokePerps, SmokeRamps, SmokeMultiChainAPI, SmokePredictions, FlaskBuildTests
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: high
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
Both changed files update the Xcode version from 16.3 to 26.3 in CI workflows:

  1. .github/workflows/build.yml: Updates XCODE_VERSION env var for the iOS build step.
  2. .github/workflows/run-e2e-api-specs.yml: Updates the xcode-select path for the E2E API specs runner.

This is a CI infrastructure change affecting the iOS build environment. Since the Xcode version bump could potentially affect iOS compilation, simulator behavior, framework compatibility, or test runner behavior, it is prudent to run the full suite of E2E tests to validate that the new Xcode version (26.3) does not break any existing test flows on iOS. No app source code was changed, so the risk is limited to the iOS build/test environment, but the breadth of potential impact across all iOS test suites justifies running all available tags as a conservative validation measure.

Performance Test Selection:
No app source code, UI components, controllers, or performance-sensitive logic was changed. The changes are purely CI workflow updates (Xcode version bump). Performance tests are not warranted as there is no impact on app runtime performance.

View GitHub Actions results

@github-actions github-actions Bot added the risk-high Extensive testing required · High bug introduction risk label Apr 6, 2026
@sonarqubecloud

sonarqubecloud Bot commented Apr 6, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
18 value mismatches detected (expected — fixture represents an existing user).
View details

@tommasini tommasini added this pull request to the merge queue Apr 6, 2026
Merged via the queue into main with commit 408e6d9 Apr 6, 2026
86 of 87 checks passed
@tommasini tommasini deleted the chore/xcode-26.3-build branch April 6, 2026 14:30
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Apr 6, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 6, 2026
@metamaskbot metamaskbot added the release-7.74.0 Issue or pull request that will be included in release 7.74.0 label Apr 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.74.0 Issue or pull request that will be included in release 7.74.0 risk-high Extensive testing required · High bug introduction risk size-XS team-mobile-platform Mobile Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants