Skip to content

docs(ButtonLink): clarify deprecation guidance (TextButton vs Tertiary Button)#27700

Merged
georgewrmarshall merged 1 commit into
mainfrom
cursor/buttonlink-deprecation-message-bbf5
Mar 20, 2026
Merged

docs(ButtonLink): clarify deprecation guidance (TextButton vs Tertiary Button)#27700
georgewrmarshall merged 1 commit into
mainfrom
cursor/buttonlink-deprecation-message-bbf5

Conversation

@georgewrmarshall

@georgewrmarshall georgewrmarshall commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Description

Clarify the @deprecated notice on ButtonLink so migration paths are explicit and unambiguous:

  • Use TextButton for inline links within text flows
  • Use Button with variant={ButtonVariant.Tertiary} for standalone link‑style buttons (CTAs, headers, separators)

Adds concise inline examples and links to design‑system docs. No runtime behavior changes (comment‑only).

Context: Slack thread

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

N/A (documentation‑only change)

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Slack Thread

Open in Web Open in Cursor 

…ks and Button with variant={ButtonVariant.Tertiary} for standalone buttons

Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
@metamaskbot metamaskbot added the team-design-system All issues relating to design system in Mobile label Mar 19, 2026
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

@georgewrmarshall georgewrmarshall self-assigned this Mar 19, 2026
@georgewrmarshall

Copy link
Copy Markdown
Contributor Author

@cursoragent update PR description to follow template .github/pull-request-template.md

@georgewrmarshall georgewrmarshall marked this pull request as ready for review March 19, 2026 17:19
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner March 19, 2026 17:19
@cursor

cursor Bot commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

• I read .github/pull-request-template.md and reformatted the PR description to match it exactly, including sections for Description, Changelog, Related issues, Manual testing steps, Screenshots/Recordings, and the checklists.

• I preserved the key context and added the Slack thread link under Description. I included the required line CHANGELOG entry: null since this is a documentation-only change.

• Nothing else changed in code; CI should re-evaluate with the updated PR body.

Open in Web Open in Cursor 

@metamaskbot metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 19, 2026
@georgewrmarshall georgewrmarshall added this pull request to the merge queue Mar 20, 2026
Merged via the queue into main with commit d86db93 Mar 20, 2026
226 of 230 checks passed
@georgewrmarshall georgewrmarshall deleted the cursor/buttonlink-deprecation-message-bbf5 branch March 20, 2026 16:37
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 20, 2026
@metamaskbot metamaskbot added the release-7.72.0 Issue or pull request that will be included in release 7.72.0 label Mar 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.72.0 Issue or pull request that will be included in release 7.72.0 size-S team-design-system All issues relating to design system in Mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants