fix(wallet): resolve analytics and UX regressions by PatrykLucka · Pull Request #27670 · MetaMask/metamask-mobile

PatrykLucka · 2026-03-19T07:55:30Z

Description

This PR resolves three tickets in wallet/cash/multichain flows:

TMCU-565: fixed Token Details Opened source for aggregated mUSD row to home_section.
TMCU-556: added missing cta_click_target: 'cta_button' to mUSD Conversion CTA Clicked.
TMCU-429: standardized multichain address-copy toast text to Address copied to clipboard.

Changelog

CHANGELOG entry: Fixed several wallet regressions affecting mUSD analytics tracking and address copy messaging consistency

Related issues

Refs: TMCU-565
Refs: TMCU-556
Refs: TMCU-429

Manual testing steps

Feature: Wallet segment regressions

  Scenario: mUSD aggregated row tracks correct source
    Given user is on Wallet Home with Cash section visible
    When user taps the mUSD aggregated row
    Then token details opens
    And source is tracked as home_section

  Scenario: Get mUSD CTA includes click target
    Given user sees Get mUSD CTA in Cash section
    When user taps Get mUSD
    Then MUSD_CONVERSION_CTA_CLICKED is tracked
    And payload includes cta_click_target with value cta_button

  Scenario: Multichain address copy shows consistent toast
    Given user opens Multichain Address List
    When user copies an address
    Then toast shows Address copied to clipboard

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: changes are limited to analytics payload/source attribution and a toast string, with small navigation param updates covered by tests.

Overview
Fixes wallet analytics regressions by introducing TokenDetailsSource.HomeSection and using it when navigating to Token Details from the homepage Cash mUSD aggregated row; Token Details open tracking now treats this source like token-list entry points for A/B attribution.

Adds missing cta_click_target: 'cta_button' to the MUSD_CONVERSION_CTA_CLICKED event from the Cash “Get mUSD” CTA (and updates tests accordingly). Standardizes the multichain address-copy toast message to notifications.address_copied_to_clipboard.

^{Written by Cursor Bugbot for commit 12a5ade. This will update automatically on new commits. Configure here.}

Co-authored-by: Patryk Łucka <PatrykLucka@users.noreply.github.com>

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

There are 3 total unresolved issues (including 1 from previous review).

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

…urce

github-actions · 2026-03-20T09:04:20Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2026-03-20T09:05:58Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeAccounts, SmokeWalletPlatform
Selected Performance tags: None (no tests recommended)
Risk Level: low
AI Confidence: 85%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes in this PR are minor and low-risk:

TokenDetails/constants/constants.ts + TokenDetails.tsx: Added a new HomeSection = 'home_section' enum value to TokenDetailsSource and updated analytics tracking to include it as a valid "from token list" source. This is a pure analytics/tracking change with no functional impact.
Homepage/Sections/Cash/MusdAggregatedRow.tsx: Changed the source parameter from MobileTokenListPage to HomeSection when navigating to the Asset/TokenDetails screen from the mUSD row in the Cash section on the Homepage. This is a tracking/analytics fix to correctly identify the navigation source.
Homepage/Sections/Cash/CashGetMusdEmptyState.tsx: Added cta_click_target: 'cta_button' to analytics event properties. Pure analytics enhancement.
MultichainAccounts/AddressList/AddressList.tsx: Fixed a toast message string key from multichain_accounts.address_list.copied (which doesn't exist in the codebase) to notifications.address_copied_to_clipboard (which does exist). This is a bug fix for a missing i18n string that would have caused a broken/missing toast message when copying an address in the multichain accounts address list.
Test files: Unit test updates matching the above changes.

Tag selection rationale:

SmokeAccounts: The AddressList fix affects the multichain accounts address list copy functionality, which is part of account management. The AddressList is used in MultichainAccountActions and AccountGroupDetails components.
SmokeWalletPlatform: The Cash section mUSD changes are on the Homepage, and the TokenDetails source tracking affects wallet platform features. The Cash/mUSD section is part of the homepage wallet experience.

No other tags are needed as there are no changes to confirmations, network management, trading flows, or other feature areas. The changes are isolated to analytics tracking and a minor string key fix.

Performance Test Selection:
No performance impact expected. Changes are limited to analytics event properties, an enum value addition, and a string key fix for a toast message. None of these affect rendering performance, data loading, or critical user flow timing.

View GitHub Actions results

github-actions · 2026-03-20T09:23:07Z

✅ E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

sonarqubecloud · 2026-03-20T09:33:03Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

PatrykLucka added the team-mobile-ux Mobile UX team label Mar 19, 2026

PatrykLucka self-assigned this Mar 19, 2026

github-actions Bot added size-S risk-low Low testing needed · Low bug introduction risk labels Mar 19, 2026

PatrykLucka changed the title ~~fix(wallet): resolve auto-fix analytics and UX regressions~~ fix(wallet): resolve analytics and UX regressions Mar 19, 2026

PatrykLucka marked this pull request as ready for review March 19, 2026 07:57

PatrykLucka requested review from a team as code owners March 19, 2026 07:57

cursor Bot reviewed Mar 19, 2026

View reviewed changes

Comment thread app/components/UI/TokenDetails/Views/TokenDetails.tsx

montelaidev reviewed Mar 19, 2026

View reviewed changes

Comment thread app/components/Views/MultichainAccounts/AddressList/AddressList.tsx

Comment thread app/components/UI/TokenDetails/Views/TokenDetails.tsx

Prithpal-Sooriya previously approved these changes Mar 19, 2026

View reviewed changes

cursoragent and others added 3 commits March 19, 2026 21:24

fix(cash): use home_section source for mUSD row (TMCU-565)

35ae082

Co-authored-by: Patryk Łucka <PatrykLucka@users.noreply.github.com>

fix(cash): add cta click target for mUSD CTA (TMCU-556)

4640c98

Co-authored-by: Patryk Łucka <PatrykLucka@users.noreply.github.com>

fix(multichain): unify address copy toast text (TMCU-429)

79c60fc

Co-authored-by: Patryk Łucka <PatrykLucka@users.noreply.github.com>

PatrykLucka dismissed Prithpal-Sooriya’s stale review via 79c60fc March 19, 2026 20:25

PatrykLucka force-pushed the fix/tmcu-auto-fix-manual branch from a20d356 to 79c60fc Compare March 19, 2026 20:25

github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 19, 2026

cursor Bot reviewed Mar 19, 2026

View reviewed changes

Comment thread app/components/Views/Homepage/Sections/Cash/MusdAggregatedRow.test.tsx

Comment thread app/components/Views/Homepage/Sections/Cash/MusdAggregatedRow.test.tsx Outdated

refactor(tests): update MusdAggregatedRow test to use home_section so…

12a5ade

…urce

github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 20, 2026

montelaidev approved these changes Mar 20, 2026

View reviewed changes

PatrykLucka enabled auto-merge March 20, 2026 09:41

bergarces approved these changes Mar 20, 2026

View reviewed changes

PatrykLucka added this pull request to the merge queue Mar 20, 2026

Merged via the queue into main with commit 1ba34e2 Mar 20, 2026
99 checks passed

PatrykLucka deleted the fix/tmcu-auto-fix-manual branch March 20, 2026 10:09

github-actions Bot locked and limited conversation to collaborators Mar 20, 2026

metamaskbot added the release-7.72.0 Issue or pull request that will be included in release 7.72.0 label Mar 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(wallet): resolve analytics and UX regressions#27670

fix(wallet): resolve analytics and UX regressions#27670
PatrykLucka merged 4 commits into
mainfrom
fix/tmcu-auto-fix-manual

PatrykLucka commented Mar 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Mar 20, 2026

Uh oh!

github-actions Bot commented Mar 20, 2026

Uh oh!

github-actions Bot commented Mar 20, 2026

Uh oh!

sonarqubecloud Bot commented Mar 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

PatrykLucka commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Mar 20, 2026

Uh oh!

github-actions Bot commented Mar 20, 2026

🔍 Smart E2E Test Selection

Uh oh!

github-actions Bot commented Mar 20, 2026

Uh oh!

sonarqubecloud Bot commented Mar 20, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

PatrykLucka commented Mar 19, 2026 •

edited

Loading