Skip to content

release: 7.68.3#27505

Merged
chloeYue merged 7 commits into
stablefrom
release/7.68.3
Mar 17, 2026
Merged

release: 7.68.3#27505
chloeYue merged 7 commits into
stablefrom
release/7.68.3

Conversation

@weitingsun

@weitingsun weitingsun commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

Description

OTA was broken with old environment variables check. This PR aims to solve that by introdocing a new environment variable.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes how feature flags are resolved in CI/OTA builds by ignoring local env overrides when BUILDS_ENABLED_WITH_GH_ACTIONS_TEMPORARY is set, which could unintentionally change enabled/disabled behavior if the new flag is misconfigured. Otherwise the changes are small and localized to release/config code paths.

Overview
Bumps the OTA release version to v7.68.3 and adds 7.68.3 release notes/compare link in CHANGELOG.md.

Adjusts feature-flag resolution so GitHub Actions OTA builds (when BUILDS_ENABLED_WITH_GH_ACTIONS_TEMPORARY=true and not E2E) use remote flags only, preventing MM_EXTENSION_UX_PNA25 and MM_ADDITIONAL_NETWORK_BLACKLIST env overrides from affecting those builds. Adds a small buildTimeDefaultsConfig helper to centralize that build-time gating check.

Written by Cursor Bugbot for commit adfa229. This will update automatically on new commits. Configure here.

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
OTA was broken with old environment variables check. This PR aims to
solve that by introdocing a new environment variable.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Changes how several services choose API endpoints/environments by
switching from `GITHUB_ACTIONS`/`E2E` checks to a new
`BUILDS_ENABLED_WITH_GH_ACTIONS_TEMPORARY` flag, which could route
builds to different backend environments if misconfigured.
> 
> **Overview**
> Introduces a new build-time env flag,
`BUILDS_ENABLED_WITH_GH_ACTIONS_TEMPORARY`, and uses it to decide when
to take **build-provided** URLs/environments (from `builds.yml`) versus
deriving them from `METAMASK_ENVIRONMENT`.
> 
> Updates Baanx Card URL mapping, ramps SDK environment selection
(Aggregator + Deposit), ramps controller init, and rewards API URL
override logic to key off this flag, and refreshes/adjusts tests
accordingly (including removing the previous special-casing tied to
`E2E`).
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
4249918. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@weitingsun weitingsun requested review from a team as code owners March 16, 2026 21:06
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@weitingsun weitingsun changed the base branch from main to release/7.68.0 March 16, 2026 21:06
tommasini
tommasini previously approved these changes Mar 16, 2026
@weitingsun weitingsun changed the base branch from release/7.68.0 to stable March 16, 2026 21:08
@weitingsun weitingsun dismissed tommasini’s stale review March 16, 2026 21:08

The base branch was changed.

himanshuchawla009 and others added 2 commits March 16, 2026 14:31
The encryptorAdapter introduced in PR #26258 overrides encryptWithKey to
return browser-passworder format ({ data }) instead of the mobile Encryptor
format ({ cipher }). However, decrypt and decryptWithDetail were not
overridden — they were spread from the mobile Encryptor, which reads the
cipher field. This caused a crash on the next unlock after any background
JWT token refresh:

  TypeError: The first argument must be one of type string, Buffer...
  Received type undefined (quick-crypto.ts:101)

Fix: add normalizeVaultFormat which injects cipher = data when a vault has
data but no cipher, and override decrypt and decryptWithDetail in the
adapter to normalize before delegating to the underlying Encryptor.

Also harden decryptWithKey to accept both data and cipher fields (for
pre-adapter vaults that only carry cipher), and throw explicitly when
both fields are absent.

Adds end-to-end tests that reproduce the bug scenario: background token
refresh writes a data-format vault via encryptWithKey, then decrypt /
decryptWithDetail must recover it on the next unlock.
@weitingsun weitingsun requested a review from a team as a code owner March 16, 2026 21:32
@weitingsun weitingsun requested review from a team, tommasini and vpintorico March 16, 2026 21:52
vpintorico
vpintorico previously approved these changes Mar 16, 2026
Cal-L
Cal-L previously approved these changes Mar 16, 2026

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@weitingsun weitingsun dismissed stale reviews from Cal-L and vpintorico via 9fc9bd9 March 16, 2026 22:25
tommasini
tommasini previously approved these changes Mar 16, 2026
Comment thread app/constants/ota.ts Outdated
Cal-L
Cal-L previously approved these changes Mar 17, 2026

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@weitingsun weitingsun changed the base branch from stable to release/7.68.0 March 17, 2026 03:20
Cal-L
Cal-L previously approved these changes Mar 17, 2026

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@weitingsun weitingsun changed the base branch from release/7.68.0 to stable March 17, 2026 03:22
@weitingsun weitingsun dismissed Cal-L’s stale review March 17, 2026 03:22

The base branch was changed.

Cal-L
Cal-L previously approved these changes Mar 17, 2026

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@sleepytanya sleepytanya added area-qa Relating to QA work (Quality Assurance) team-qa QA team release-7.71.0 Issue or pull request that will be included in release 7.71.0 size-XL and removed area-qa Relating to QA work (Quality Assurance) team-qa QA team size-XL release-7.71.0 Issue or pull request that will be included in release 7.71.0 labels Mar 17, 2026
chloeYue and others added 2 commits March 17, 2026 09:25
Resolved conflicts between stable (7.69.0) and release/7.68.3:

Build/version: take release/7.68.3 versions
- app/constants/ota.ts: keep v7.68.3

Source code: take release/7.68.3 (hotfix-specific changes)
- remote-feature-flag-build-time-defaults-config.ts: keep (deleted on stable)
- featureFlagController selectors: keep release/7.68.3 versions

Merge with "Create a merge commit" — do NOT squash.

Made-with: Cursor
## **Description**

Sync stable branch into release/7.68.3 to include releases (7.69.0,
7.68.2, 7.68.1, 7.68.0, 7.67.x) that were merged to stable.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**


## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Made with Cursor


Made with [Cursor](https://cursor.com)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Medium risk due to broad GitHub Actions workflow refactors (build
caching/artifacts, new gating/skip conditions, new fixture jobs) that
could break CI or release pipelines if misconfigured.
> 
> **Overview**
> Syncs release tooling and CI workflows to a newer stable state,
including a **major GitHub Actions refactor** for builds: adds
`skip_version_bump`, moves dependency setup into a reusable
`setup-node-modules` workflow, and switches build jobs to consume
platform-specific `node_modules` tarball artifacts with extra
verification and iOS-specific pod/keychain handling.
> 
> Expands CI automation and reporting: adds **bundle size checks**,
workflow linting, shard test JSON output with aggregated unit/CV test
counts, and a new `qa-stats` workflow plus `collect-qa-stats.mjs` to
download artifacts from the triggering run and publish `qa-stats.json`.
> 
> Adds E2E fixture workflows: a CI fixture validation run with PR
annotations/comments (`e2e-report-fixture-validation.mjs`), plus a
bot-triggered `update-e2e-fixtures` workflow that downloads the CI-built
iOS app, exports/updates fixtures, and pushes changes back to the PR
(non-fork only).
> 
> Also updates tooling/config: bumps Ruby to `3.2.9`, updates Android
version to `7.69.0` and adjusts packaging excludes, adds performance E2E
Sentry env wiring, tightens CODEOWNERS/ESLint overrides, updates
Storybook story registration, and applies Yarn patches for bridge
metrics `ab_tests` support and BrowserStack local toggle behavior.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
39a655c. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
This PR updates the change log for 7.68.3. (Hotfix - no test plan
generated.)

## **Description**

Adds a new `7.68.3` section to `CHANGELOG.md` documenting two hotfixes:
- Fixed seedless onboarding vault decryption crash by handling both
vault formats in encryptorAdapter (#27393)
- Fixed OTA environment variable configuration to use new build flag
(#26668)

Updates the changelog reference links so `Unreleased` now compares from
`v7.68.3` and includes a new `7.68.3` compare link.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

N/A - changelog only

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Made with Cursor


Made with [Cursor](https://cursor.com)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Changelog-only update with no runtime code changes; risk is limited to
potential version/compare-link inaccuracies in release notes.
> 
> **Overview**
> Adds a new `7.68.3` section to `CHANGELOG.md` documenting two hotfixes
(seedless onboarding vault decryption crash handling and OTA env var
build-flag update).
> 
> Updates the version reference links by introducing a new `[7.68.3]`
compare link.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
2bbdafb. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment thread CHANGELOG.md
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - base branch is not main (base: stable)

All E2E tests pre-selected.

View GitHub Actions results

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ E2E Fixture Validation — Structural changes detected

Category Count
New keys 68
Missing keys 11
Type mismatches 0
Value mismatches 7 (informational)

The committed fixture schema is out of date. To update, comment:

@metamaskbot update-mobile-fixture

View full details | Download diff report

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
36.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@chloeYue chloeYue added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Mar 17, 2026
@chloeYue chloeYue merged commit b4978f3 into stable Mar 17, 2026
204 of 211 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 17, 2026
@metamaskbot metamaskbot added the release-7.68.3 Issue or pull request that will be included in release 7.68.3 label Mar 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.68.3 Issue or pull request that will be included in release 7.68.3 size-S skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-mobile-delivery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants