Skip to content

ci: add default look back days for post merge validation workflow#27478

Merged
jvbriones merged 1 commit into
mainfrom
chore-post-merge-validation
Mar 16, 2026
Merged

ci: add default look back days for post merge validation workflow#27478
jvbriones merged 1 commit into
mainfrom
chore-post-merge-validation

Conversation

@jvbriones

@jvbriones jvbriones commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

Description

Updates a GitHub Actions workflow to accept an optional dispatch input and pass it through with a safe default

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: only updates a GitHub Actions workflow to accept an optional dispatch input and pass it through with a safe default, without touching application code.

Overview
Adds a workflow_dispatch input (lookback-days, default 1) to the Post Merge Validation GitHub Actions workflow.

Passes this value through to the MetaMask/github-tools post-merge-validation@v1 action (falling back to 1 when not provided) to control how far back the workflow searches for PRs.

Written by Cursor Bugbot for commit a214512. This will update automatically on new commits. Configure here.

@jvbriones jvbriones requested a review from a team as a code owner March 16, 2026 11:28
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jvbriones jvbriones changed the title chore: add default look back days for post merge validation workflow … ci: add default look back days for post merge validation workflow Mar 16, 2026
@metamaskbot metamaskbot added the team-qa QA team label Mar 16, 2026
@jvbriones jvbriones added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Mar 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeCard, SmokePerps, SmokeRamps, SmokeMultiChainAPI, SmokePredictions, FlaskBuildTests
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 70%
click to see 🤖 AI reasoning details

E2E Test Selection:
The only changed file is a critical CI workflow file: .github/workflows/post-merge-validation.yml. There are no application code changes (no modifications in app/, controllers, Engine, UI components, or test infrastructure). Therefore, there is no direct functional impact on wallet features.

However, because this is a CI workflow change that likely orchestrates post-merge validation and test execution, the primary risk is pipeline misconfiguration (e.g., jobs not triggered, incorrect test matrix, environment issues, missing artifacts, or mis-scoped tags). To safely validate that the workflow still executes all required coverage correctly, we should run the full E2E smoke suite.

Running the full set of smoke tags ensures:

  • All major feature verticals (accounts, confirmations, trading, network expansion, snaps, identity, etc.) are properly triggered by the updated workflow.
  • Tag-based filtering and job routing inside CI still function correctly.
  • No regressions in workflow configuration (e.g., conditional execution, environment setup, secrets, build variants like Flask).

There is no indication of feature-specific changes that would justify narrowing scope to a subset of tags. Since this change affects CI orchestration rather than product logic, broad validation is the safest minimal-risk strategy.

No additional dependent tag adjustments were required beyond including all available E2E smoke tags.

Performance tests are not selected because:

  • No app runtime code, rendering logic, controllers, or startup paths were modified.
  • No performance test infrastructure (tests/performance/) was changed.
  • Workflow-level changes do not affect app performance characteristics.

Thus, full E2E smoke coverage is recommended, with no performance test execution required.

Performance Test Selection:
No application code, rendering logic, controllers, or performance test infrastructure was modified. The change is limited to a CI workflow file, which does not affect runtime performance characteristics of the app. Therefore, no performance tests are required.

View GitHub Actions results

@jvbriones jvbriones enabled auto-merge March 16, 2026 11:40
@sonarqubecloud

Copy link
Copy Markdown

@jvbriones jvbriones added this pull request to the merge queue Mar 16, 2026
Merged via the queue into main with commit d5b137a Mar 16, 2026
113 of 118 checks passed
@jvbriones jvbriones deleted the chore-post-merge-validation branch March 16, 2026 12:32
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 16, 2026
@metamaskbot metamaskbot added the release-7.71.0 Issue or pull request that will be included in release 7.71.0 label Mar 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.71.0 Issue or pull request that will be included in release 7.71.0 size-XS team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants