Skip to content

refactor: simplify button styles in AdditionalNetworkItem component#27475

Merged
PatrykLucka merged 1 commit into
mainfrom
TMCU-521-we-should-remove-the-bg-on-the-icon-on-networks
Mar 16, 2026
Merged

refactor: simplify button styles in AdditionalNetworkItem component#27475
PatrykLucka merged 1 commit into
mainfrom
TMCU-521-we-should-remove-the-bg-on-the-icon-on-networks

Conversation

@PatrykLucka

@PatrykLucka PatrykLucka commented Mar 16, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Removes background on the "+" icon in the new Network management view.

Changelog

CHANGELOG entry: Remove background from Additional Networks in Network Management

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TMCU-521

Manual testing steps

Feature: Network management

  Scenario: user can access network management and sees updated additional network icons
    Given the app is opened and the user is logged in
    When the user goes to Account Menu and opens Networks
    Then the Networks management screen is shown
    And each additional network item shows its icon without a rounded muted background

Screenshots/Recordings

Before

Screenshot 2026-03-16 at 11 27 32

After

Screenshot 2026-03-16 at 11 27 41

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI-only change that adjusts styling for the add (+) button with no logic or data flow changes.

Overview
Updates AdditionalNetworkItem so the add (+) Pressable no longer renders with a muted rounded background, leaving only sizing/alignment and pressed opacity styling.

Written by Cursor Bugbot for commit c27272c. This will update automatically on new commits. Configure here.

@PatrykLucka PatrykLucka self-assigned this Mar 16, 2026
@github-actions

github-actions Bot commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-ux Mobile UX team label Mar 16, 2026
@github-actions

github-actions Bot commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeNetworkAbstractions
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 76%
click to see 🤖 AI reasoning details

E2E Test Selection:
The change is isolated to app/components/Views/NetworksManagement/components/AdditionalNetworkItem.tsx, which is part of the Network Management UI. This directly impacts the network selection and management layer (e.g., enabling/disabling networks, displaying additional networks, selector interactions). These flows are covered by SmokeNetworkAbstractions. There are no indications of changes to controllers, Engine, multi-chain provider logic, or dApp session APIs, so SmokeNetworkExpansion and SmokeMultiChainAPI are not required. No changes suggest impact to transactions, swaps, identity, trending, or other wallet platform features.

Performance Test Selection:
The change is limited to a single UI component within the network management screen. There is no indication of modifications to rendering-heavy lists, controllers, startup logic, asset loading, or critical user flows. Therefore, no measurable performance impact is expected.

View GitHub Actions results

@PatrykLucka PatrykLucka marked this pull request as ready for review March 16, 2026 10:34
@sonarqubecloud

sonarqubecloud Bot commented Mar 16, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

✅ E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

@PatrykLucka PatrykLucka added this pull request to the merge queue Mar 16, 2026
Merged via the queue into main with commit c1e2acc Mar 16, 2026
215 of 219 checks passed
@PatrykLucka PatrykLucka deleted the TMCU-521-we-should-remove-the-bg-on-the-icon-on-networks branch March 16, 2026 13:07
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 16, 2026
@metamaskbot metamaskbot added the release-7.71.0 Issue or pull request that will be included in release 7.71.0 label Mar 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wachunei wachunei wachunei approved these changes

Assignees

@PatrykLucka PatrykLucka

Labels

release-7.71.0 Issue or pull request that will be included in release 7.71.0 size-XS team-mobile-ux Mobile UX team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PatrykLucka @wachunei @metamaskbot