Skip to content

fix(homepage): add dot separator between price and variation for token rows (TMCU-569)#27449

Merged
wachunei merged 5 commits into
mainfrom
TMCU-569-add-dot-separator-musd-row
Mar 13, 2026
Merged

fix(homepage): add dot separator between price and variation for token rows (TMCU-569)#27449
wachunei merged 5 commits into
mainfrom
TMCU-569-add-dot-separator-musd-row

Conversation

@wachunei

@wachunei wachunei commented Mar 12, 2026

Copy link
Copy Markdown
Member

Description

This PR adds a dot separator (•) between the price and variation text in token rows on the homepage, aligning with the price • variation format used in TokenListItemV2.

1. What is the reason for the change?

  • Token rows in the Cash section and Popular Tokens section did not follow the same layout as token list items
  • TokenListItemV2 displays price and variation as $1.00 • +5.25% (or similar)
  • The MUSD row in Cash and the Popular Token rows were missing this separator

2. What is the improvement/solution?

  • Insert the Unicode bullet (\u2022) between the price and variation
  • Update PopularTokenRow so price and percentage display as price • variation
  • Update CashGetMusdEmptyState for the MUSD empty state
  • Adjust test assertions in PopularTokenRow.test.tsx to match the new format

Changelog

CHANGELOG entry: Fixed token row display on homepage to show price and variation separated by a dot for consistency with token list items

Related issues

Fixes: TMCU-569

Manual testing steps

Feature: Homepage token row display consistency

  Scenario: user views token rows with price and variation
    Given the user is on the Homepage
    And the Cash section shows MUSD or Popular Tokens shows tokens with price/variation
    When the user views the token row
    Then price and variation are separated by a dot (•)
    And the layout matches TokenListItemV2 (e.g. "$1.00 • 3% bonus" or "$1,234.56 • +5.25%")

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI-only change to text/layout formatting plus corresponding test updates; no data, auth, or navigation logic changes.

Overview
Aligns homepage token rows with the price • variation display by inserting a Unicode bullet separator between the price and percentage/bonus text.

Updates PopularTokenRow to render the separator only when a percentage value is present (and simplifies the layout), and tweaks CashGetMusdEmptyState to show the same separator for the mUSD row. Tests are updated to assert the new formatting and ensure no trailing bullet appears when variation is absent/invalid.

Written by Cursor Bugbot for commit dcda7cd. This will update automatically on new commits. Configure here.

…n rows (TMCU-569)

- Add dot separator in PopularTokenRow to match TokenListItemV2 layout
- Update PopularTokenRow test assertions for new price • variation format
- Minor CashGetMusdEmptyState update
@metamaskbot metamaskbot added the team-money-movement issues related to Money Movement features label Mar 12, 2026
@wachunei wachunei marked this pull request as ready for review March 12, 2026 18:48
@wachunei wachunei removed the team-money-movement issues related to Money Movement features label Mar 12, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment thread app/components/Views/Homepage/Sections/Tokens/components/PopularTokenRow.tsx Outdated
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are limited to Homepage UI components under app/components/Views/Homepage/Sections/ (Cash and Tokens), specifically CashGetMusdEmptyState.tsx and PopularTokenRow.tsx plus its unit test. These components are part of the Homepage/Trending experience, which is covered by SmokeWalletPlatform (Trending discovery tab, embedded sections like Tokens, Perps, Predictions, and wallet platform integrations). Since these updates affect UI rendering within Homepage sections, they may impact Trending display and wallet platform flows. No changes were made to controllers, Engine, confirmations, network management, swaps, perps, predictions logic, or snaps infrastructure, so other E2E tags are not required. No dependency rules require additional tags.

Performance Test Selection:
The changes are limited to UI components and a related unit test. There is no indication of modifications to list virtualization, data fetching, controller logic, rendering loops, or performance-critical flows such as onboarding, login, swaps, predictions, perps, or asset loading infrastructure. Therefore, no dedicated performance tests are required.

View GitHub Actions results

@wachunei wachunei added the team-mobile-ux Mobile UX team label Mar 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

@sonarqubecloud

Copy link
Copy Markdown

@wachunei wachunei enabled auto-merge March 12, 2026 19:35
@wachunei wachunei added this pull request to the merge queue Mar 13, 2026
Merged via the queue into main with commit d6fd3c4 Mar 13, 2026
98 of 99 checks passed
@wachunei wachunei deleted the TMCU-569-add-dot-separator-musd-row branch March 13, 2026 05:00
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 13, 2026
@metamaskbot metamaskbot added the release-7.71.0 Issue or pull request that will be included in release 7.71.0 label Mar 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.71.0 Issue or pull request that will be included in release 7.71.0 size-S team-mobile-ux Mobile UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants